[geeklog-devel] Draft of schema for GL2
vfuria at gmail.com
Thu Dec 16 14:46:04 EST 2004
I didn't look at slashcode. But most other CMSs I looked at just grab
all the comments from the DB and use a recursive php algorithm. I
didn't see any that had an efficient (or smart) way of grabbing
The implementation is original, the algorithm was spelled out in a
couple different places with slight variations in the details.
On Thu, 16 Dec 2004 13:35:07 -0600, Tony Bibbs <tony at tonybibbs.com> wrote:
> Vincent Furia wrote:
> >Yes. If you look in the geeklog code for calls to SEC_inGroup() it is
> >really only used for the Root group. Most of the other instance
> >where it is used it is used against a group id variable. The
> >remainder I would argue are redundant if we better respected
> >privileges in 1.3.x. I'd recommend a "isRoot" function, but I think
> >"inGroup" is really not needed except when actually administering
> >group membership.
> Ok, I say we yank it...adding that column in if deemed appropriate isn't
> too hard.
> >Better names for those columns wouldn't hurt, I just couldn't come up
> >with anything better when I was implementing it in 1.3.x. I looked
> >around at other algorithms when I was first looking into improving the
> >performance of comments and didn't find anything better. If you do
> >find something let me know. This was, by far, the best I found. The
> >biggest downside is that I had to lock the table during inserts, but
> >that is really OBE since we can use transactions.
> Was this an original implementation or was it one you borrowed from
> someplace? WTF does slashcode use...you'd think they'd have to have
> this issue nailed down by now.
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
More information about the geeklog-devel