[geeklog-devel] Re: FileMgmt Comments (1.3.10rc1)

[Vincent Furia]

OK,

First of all way that Geeklog currently handles plugins for comments
could use a bit of work.  It looks like there is some over riding of
the "cid" variable (that is pretty confusing).  Something I'd like to
clean up for 1.3.11 (1.4?), but I'm not sure how many plugins use the
plugin comment engine and I really don't want to break them. 
Recommendations?  Feelings? (Blaine?)

In any case, I think I know what the immediate problem is with the
filemgmt plugin and comments.  Right now the comments.php file
assumes, due to the use of COM_applyFilter, that the cid is an
integer.  This should be valid, but in the world of plugin comments
the cid can get over ridden to hold the plugins item id which doesn't
necesarily need to be an integer (and for filemgmt plugin installed on
geeklog it isn't)...

So I think the short term fix for this is to change this code at the
end of comment.php (stating around line 881):

        if (isset ($HTTP_POST_VARS['cid'])) {
            $cid = COM_applyFilter ($HTTP_POST_VARS['cid'], true);
        } else {
            $cid = COM_applyFilter ($HTTP_GET_VARS['cid'], true);
        }

to:

        if (isset ($HTTP_POST_VARS['cid'])) {
            $cid = COM_applyFilter ($HTTP_POST_VARS['cid']);
        } else {
            $cid = COM_applyFilter ($HTTP_GET_VARS['cid']);
        }

I don't have the filemgmt installed in any of my sites to test this,
so there may be other problems as well.  Can some one check this and
make sure that is the only problem?

Thanks,
Vinny

On Wed, 20 Oct 2004 09:36:57 -0400, Vincent Furia <vfuria at gmail.com> wrote:
> http://www.geeklog.net/comment.php?cid=12219&type=article&mode=view
> 
> Looks like there are some problems with the comment code code and
> plugins.  I don't have filemgmt installed on any of my test sites, nor
> I have I ever looked at its code.  Anyone want to work with me to get
> these issues resolved (presumably someone with filemgmt experience)?
> 
> Alternatively if I could get access to geeklog.net via ssh so I can
> look at the comments table, check out the error.log and examine the
> source I should be able to take care of this myself.
> 
> Thanks,
> Vinny
>