[geeklog-devel] Dynamic Comments...

Vincent Furia vfuria at gmail.com
Fri Feb 4 09:06:01 EST 2005


Blaine,

I'll be checking it all into CVS soon.

Current ToDo List for dynamic comments:
* get new images that better match the professional theme (Simon?  Anyone?)
* create a $_CONF variable to disable dynamic comments and implement
the disable in the code

-Vinny

On Fri, 4 Feb 2005 00:07:51 -0500, Blaine Lang <geeklog at langfamily.ca> wrote:
> This is real a neat feature Vinny - nice work.
> I like the fact that now I can collapse it again once I view the comment.
> 
> Do you have any code that you can send me or direct me to better understand
> how this is being done.
> I see immediate use for this in some of my projects.
> 
> Blaine
> ----- Original Message -----
> From: "Vincent Furia" <vfuria at gmail.com>
> To: <geeklog-devel at lists.geeklog.net>
> Sent: Thursday, February 03, 2005 11:29 PM
> Subject: Re: [geeklog-devel] Dynamic Comments...
> 
> On Mon, 31 Jan 2005 21:44:03 +0100, Niels Leenheer <niels at creatype.nl>
> wrote:
> > However, I can see a couple of problems with the code you are currently
> > using.
> >
> > First of all, you are using a single XMLHttpRequest object without
> > protecting
> > it from being called more than once. As a result it is possible to
> > interrupt an
> > ongoing request. Try clicking on quickly on multiple triangles after
> > each other,
> > without waiting for one to finish loading. Only the request clicked on
> > last will
> > be honoured, the other ones will be 'loading' indefinately.
> >
> This was a big problem, I didn't quite use the solution you suggested
> (I couldn't quite get it to work), but I did (if I may say so) a
> ingenous little workaround.
> 
> >
> > Secondly, there is a bug in the XMLHttpRequest implementation of Opera,
> > which basically requeres and extra check inside the onreadystatechange
> > function, otherwise it will be called multiple times after each other,
> > but only the first time with the proper responseText.
> >
> OK, changed the code around to account for this.  Hopefully it will
> work with Opera now.
> 
> Thanks for all the suggestions Niels.  Anyone else see any problems
> (http://vfuria.dyndns.org:8080/article.php?story=geeklog-1.3.10rc2&mode=dynamic#comments)
> 
> Thanks,
> Vinny
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://lists.geeklog.net/listinfo/geeklog-devel
> 
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://lists.geeklog.net/listinfo/geeklog-devel
>



More information about the geeklog-devel mailing list