[geeklog-devel] Comments for static pages?

[Heather Engineering]

Oliver,

If you're still looking at the staticpages plugin: in public_html/ 
staticpages/index.php, if there is an error/denied access, right  
blocks are automatically shown no matter what site settings you use:

public_html/staticpages/index.php from about line 202:

     if ($failflg) {
         $retval = COM_siteHeader ('menu');
         $retval .= COM_startBlock ($LANG_LOGIN[1], '',
                             COM_getBlockTemplate ('_msg_block',  
'header'));
         $login = new Template ($_CONF['path_layout'] . 'submit');
         $login->set_file (array ('login' =>  
'submitloginrequired.thtml'));
         $login->set_var ('login_message', $LANG_LOGIN[2]);
         $login->set_var ('site_url', $_CONF['site_url']);
         $login->set_var ('lang_login', $LANG_LOGIN[3]);
         $login->set_var ('lang_newuser', $LANG_LOGIN[4]);
         $login->parse ('output', 'login');
         $retval .= $login->finish ($login->get_var ('output'));
         $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block',  
'footer'));
         $retval .= COM_siteFooter (true);
     } else {
         $retval = COM_siteHeader ('menu');
	    $retval .= COM_startBlock ($LANG_ACCESS['accessdenied'], '',
                             COM_getBlockTemplate ('_msg_block',  
'header'));
     	$retval .= $LANG_STATIC['deny_msg'];
	    $retval .= COM_endBlock (COM_getBlockTemplate ('_msg_block',  
'footer'));
     	$retval .= COM_siteFooter (true);
     }

Personally I think that each site footer call should be

if ($_CONF['show_right_blocks']) {
     $retval .= COM_siteFooter (true);
} else {
     $retval .= COM_siteFooter ();
}

Cheers,

Euan.




On 2007/08/09, at 14:32, Oliver Spiesshofer wrote:


> Ah yes, thats something that is needed for all edited Items I  

> suppose. It regularly freaks me out in stories, users etc etc.

>

> Oliver

>

> Heather Engineering wrote:

>> While you're at it, an option in config.php to redirect to the  

>> page just edited instead of the staticpage admin list would be  

>> nice. I have some code somewhere if you want but it is trivial to  

>> implement.

>>

>> Cheers,

>>

>> Euan.

>>

>>

>> On 2007/08/09, at 13:26, Oliver Spiesshofer wrote:

>>

>>> Off course. It will work just like comments for stories.

>>>

>>> Oliver

>>>

>>> Joe Mucchiello wrote:

>>>> A great idea as long as comments can be turned on or off for  

>>>> each individual staticpage.

>>>>

>>>> At 10:37 PM 8/8/2007, Oliver Spiesshofer wrote:

>>>>> Is there any objection to implement (optional) comments for  

>>>>> static pages?

>>>>>

>>>>> I think this could be really helpful

>>>>> wonder if this came up already...

>>>>

>>>> ----

>>>> Joe Mucchiello

>>>> Throwing Dice Games

>>>> http://www.throwingdice.com

>>>> _______________________________________________

>>>> geeklog-devel mailing list

>>>> geeklog-devel at lists.geeklog.net

>>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel

>>>>

>>>>

>>>

>>> _______________________________________________

>>> geeklog-devel mailing list

>>> geeklog-devel at lists.geeklog.net

>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel

>>

>> _______________________________________________

>> geeklog-devel mailing list

>> geeklog-devel at lists.geeklog.net

>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel

>>

>>

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://eight.pairlist.net/mailman/listinfo/geeklog-devel