[geeklog-devel] [geeklog-cvs] Geeklog-1.x/system/classes config.class.php, 1.9, 1.10

[Joe Mucchiello]

At 07:11 PM 12/29/2007, Aaron Blankstein wrote:

>Update of /cvsroot/geeklog/Geeklog-1.x/system/classes

>In directory qs1489.pair.com:/tmp/cvs-serv59652/Geeklog-1.x/system/classes

>

>Modified Files:

>         config.class.php

>Log Message:

>Updated config class to run more smoothly with PHP4.

>Changed config class's plugin support.

>Added barebones handling of static page's config options in the config class.


Oh, man, Aaron, I had just started coding this into the calendar 
plugin when you checked this in. Thankfully I hadn't gotten too far.

A couple questions about the new method plus I think there's a whole 
in the upgrade stuff.

First, is this basically all I need to be compatible with 1.4.1 and 1.5?

// if class exists, load config from DB
if (class_exists('config')) {
     $_CA_CONF = config->get_instance()->get_config('calendar');
}
// still no config? load the file.
if (empty($_CA_CONF)) {
     require_once ($_CONF['path'] . 'plugins/calendar/config.php');
}

I'm not sure I like the idea that the entire config data is loaded at 
once. Makes me think it might be faster to serialize the whole thing 
to a file and just load it back from the file. But then I'm into 
caches. More to follow....


----
Joe Mucchiello
Throwing Dice Games
http://www.throwingdice.com