[geeklog-devel] Story images & Icons

[Oliver Spiesshofer]

Joe Mucchiello wrote:
> At 01:38 PM 6/27/2007, Dirk Haun wrote:
>> Oliver Spiesshofer wrote:
>>
>> >currently the story icons (Topic icons) are set to left or right with
>> >the config.php setting and a <img aling="left/right"...>
>>
>> Actually, there already is a {story_anchortag_and_image_no_align} in CVS
>> that you can use to align it whichever way you want. So I don't really
>> see the need for a change here.
>
> I would think the benefit in less PHP code would be the reason. The 
> CVS change must increase the code a bit so that both template vars 
> {story_anchortag_and_image} and {story_anchortag_and_image_no_align} 
> are set even though only one will ever be used. I would also think we 
> should be going through the code and removing align= attributes that 
> are replaceable with standard CSS. That would give the theme designers 
> the most flexibility.
>
The PHP code reduction is minimal. However, we could remove on of the 
two variables if we go that way. I do not think this should be the 
actual reason however. I think that out of the box,. CSS should be the 
creator of the layout and not PHP code. So using the non-align variable 
and removing the old one would be my first choice right now.

Oliver