[geeklog-devel] The Mysterious Case of the Double Blocks (was 1.5.1 - what's left to do?)

[Mark Howard]

Hi -

Chameleon uses it's own functions.inc of course, which has the hack as
posted in the original bug report - but happy to use the much cooler magic
beans once I can discover the details.

Thanks!

-Mark (mst3kroqs)

-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Michael Jervis
Sent: Saturday, August 16, 2008 1:24 PM
To: Geeklog Development
Subject: Re: [geeklog-devel] The Mysterious Case of the Double Blocks (was
1.5.1 - what's left to do?)

And to resolve the following:

http://project.geeklog.net/tracking/view.php?id=684

How would people feel if I changed professional/functions.inc to NOT
set blockheader-left and blockfooter-right based on the database.
Changed the templates to left-blockheader and right-blockheader and
changed COM_getBlockTemplate to look and see if there is a
$side_[template] and if so switch to it?

This might involve some changes to the APIs for COM_getBlockTemplate
and the call stack above it to introduce an (optional, defaulting to
blank) $side variable.

Seems the most sensible solution, and eliminates a call to the
database for the theme.

Issues with this?

I don't think it would break any other theme. They'd work as is. But
if Chameleon wanted to update to use the new magic beans it could.

Cheers,

Mike
_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel