From sc1245 at messiah.edu Wed Jul 1 14:19:30 2009 From: sc1245 at messiah.edu (Sean Clark) Date: Wed, 01 Jul 2009 14:19:30 -0400 Subject: [geeklog-devel] This week... Message-ID: <4A4B7072020000CB0001FD20@gwia.messiah.edu> Err, sorry about sending that last message to geeklog-devel, not sure how that found its way into the address field. From dirk at haun-online.de Wed Jul 1 15:59:53 2009 From: dirk at haun-online.de (Dirk Haun) Date: Wed, 1 Jul 2009 21:59:53 +0200 Subject: [geeklog-devel] This week... In-Reply-To: <4A4A760D020000CB0001FC76@gwia.messiah.edu> References: <4A4A760D020000CB0001FC76@gwia.messiah.edu> Message-ID: <20090701195953.218639694@smtp.haun-online.de> Hey Sean, >Right now I'm working my way through lib-common, trying to figure out >ingenious ways to test it - but wanted to make sure I'm on the right track. Sounds good. lib-common is certainly one of the more important pieces of code - and one of the most tricky ones to test. Once you've proved how to test this, I think we should take a break from writing tests for a while and document what you achieved so far. Then try to set up some automated tests and see if we can get one of the other students (or devs!) to use it. >(evaluations are coming up next week, after all). Nothing you should worry about ;-) bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From dirk at haun-online.de Mon Jul 6 01:05:54 2009 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 6 Jul 2009 07:05:54 +0200 Subject: [geeklog-devel] Fwd: [contact-us] array getting fetched?! Message-ID: <20090706050554.1621244056@smtp.haun-online.de> ---------------- Anfang Weiterleitung ---------------- Betreff: [contact-us] array getting fetched?! Gesendet: Sonntag, 5. Juli 2009 18:44 Uhr Von: ????????? An: contact-us at lists.geeklog.net Hey, I'm having some curiosities about line 558 on lib-comment.php code: * } while( $A = DB_fetchArray( $comments ));* * * This code is stuck in a do-while loop :P But they way I see it getting passed and treated, $comments is not a resource. It seems to work fine on MySQL, but I can't seem to get away with it on pgSQL. Not really sure how this worked before if it is indeed an array and I'm just not missing something. -- Warmly, Stanislav _______________________________________________ contact-us mailing list contact-us at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/contact-us ----------------- Ende Weiterleitung ----------------- -- http://www.geeklog.net/ http://geeklog.info/ From vfuria at gmail.com Mon Jul 6 23:16:11 2009 From: vfuria at gmail.com (Vincent Furia) Date: Mon, 6 Jul 2009 21:16:11 -0600 Subject: [geeklog-devel] Fwd: [contact-us] array getting fetched?! In-Reply-To: <20090706050554.1621244056@smtp.haun-online.de> References: <20090706050554.1621244056@smtp.haun-online.de> Message-ID: <8319e2d60907062016t2d6d253h1080b9c263965d4c@mail.gmail.com> Sorry for the late reply. I talked to Stan and we got this straightened out. The CMT_getComment function overloads the use of the $comments variable in a way that pgsql doesn't like. We have a work around. Stan will be submitting a bug to the bugtracker to refactor that function (which I imagine I'll end up doing at some point). -Vinny On Sun, Jul 5, 2009 at 11:05 PM, Dirk Haun wrote: > ---------------- Anfang Weiterleitung ---------------- > Betreff: [contact-us] array getting fetched?! > Gesendet: Sonntag, 5. Juli 2009 18:44 Uhr > Von: ????????? > An: contact-us at lists.geeklog.net > > Hey, > I'm having some curiosities about line 558 on lib-comment.php > > code: * } while( $A = DB_fetchArray( $comments ));* > * > * > This code is stuck in a do-while loop :P But they way I see it getting > passed and treated, $comments is not a resource. It seems to work fine on > MySQL, but I can't seem to get away with it on pgSQL. > Not really sure how this worked before if it is indeed an array and I'm > just > not missing something. > > > -- > Warmly, > > Stanislav > _______________________________________________ > contact-us mailing list > contact-us at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/contact-us > > ----------------- Ende Weiterleitung ----------------- > > -- > http://www.geeklog.net/ > http://geeklog.info/ > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: From dirk at haun-online.de Tue Jul 7 14:40:20 2009 From: dirk at haun-online.de (Dirk Haun) Date: Tue, 7 Jul 2009 20:40:20 +0200 Subject: [geeklog-devel] FCKeditor 2.6.4.1 Message-ID: <20090707184020.149800669@smtp.haun-online.de> I just pushed what I think are the required changes to update FCKeditor 2.6.4 to 2.6.4.1, supposedly fixing the security issue. Could someone try it out, please? The image upload hasn't been working for me for a while now anyway, so I don't see any difference ... bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From komma at ivywe.co.jp Tue Jul 7 16:10:52 2009 From: komma at ivywe.co.jp (=?ISO-2022-JP?B?GyRCOiM2cBsoQkBJdnlXZQ==?=) Date: Wed, 8 Jul 2009 05:10:52 +0900 Subject: [geeklog-devel] FCKeditor 2.6.4.1 In-Reply-To: <20090707184020.149800669@smtp.haun-online.de> References: <20090707184020.149800669@smtp.haun-online.de> Message-ID: Hi Dirk, > Could someone try it out, please? The image upload hasn't been working > for me for a while now anyway, so I don't see any difference ... /fckeditor/editor/filemanager/connectors/php/config.php file -> File image -> Image ... $Config['FileTypesPath']['File'] = $Config['UserFilesPath'] . 'file/' ; $Config['FileTypesPath']['Image'] = $Config['UserFilesPath'] . 'image/' ; $Config['FileTypesAbsolutePath']['Flash']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'flash/ $Config['FileTypesAbsolutePath']['Media']= ($Config['UserFilesAbsolutePath'] == '') ? '' : $Config['UserFilesAbsolutePath'].'media/ bye Ivy -- http://www.geeklog.jp http://www.ivywe.co.jp From dirk at haun-online.de Fri Jul 10 01:50:04 2009 From: dirk at haun-online.de (Dirk Haun) Date: Fri, 10 Jul 2009 07:50:04 +0200 Subject: [geeklog-devel] [contact-us] Fun with PHP 5.3 In-Reply-To: <4A568654.50409@gmail.com> References: <4A568654.50409@gmail.com> Message-ID: <20090710055004.1397110441@smtp.haun-online.de> Full quote below, as I think this belongs on geeklog-devel. I did some tests on PHP 5.3 (betas and release candidates) and didn't see the crash. Interesting ... The bugreport mentions that the bug has been there for almost a year. I assume that refers to the 5.3 branch? If it were in 5.2.x as well, we would have heard of it by now. bye, Dirk Justin Carlson wrote: >I'm not sure how I always run up against this stuff... > >Seems there's a bug in 5.3 that causes the Geeklog install process to crash. > >The bug: >http://bugs.php.net/bug.php?id=48754 > >The first place that contains this, is in >public_html/admin/install/index.php at line 102. > > @mysql_close (); > >Nothing @todo, just sending a note in case anyone asks why the install >process dies with no error. > >(Apache crashes in windows, assume it'd segfault in Linux but I have not >confirmed this.) > >Later, >Justin > >_______________________________________________ >contact-us mailing list >contact-us at lists.geeklog.net >http://eight.pairlist.net/mailman/listinfo/contact-us -- http://www.geeklog.net/ http://geeklog.info/ From dirk at haun-online.de Sun Jul 19 16:12:20 2009 From: dirk at haun-online.de (Dirk Haun) Date: Sun, 19 Jul 2009 22:12:20 +0200 Subject: [geeklog-devel] Fwd: [contact-us] array getting fetched?! In-Reply-To: <8319e2d60907062016t2d6d253h1080b9c263965d4c@mail.gmail.com> References: <20090706050554.1621244056@smtp.haun-online.de> <8319e2d60907062016t2d6d253h1080b9c263965d4c@mail.gmail.com> Message-ID: <20090719201220.714191134@smtp.haun-online.de> Vincent Furia wrote: >The CMT_getComment function overloads the use of the $comments variable in a >way that pgsql doesn't like. We have a work around. Stan will be submitting >a bug to the bugtracker to refactor that function (which I imagine I'll end >up doing at some point). From what I see, it's only a one-line fix. Or is there more coming? http://project.geeklog.net/tracking/view.php?id=927 Since 1.6.0 is out, the repository is open for commits again. Stan, I assigned you that bug - feel free to commit your fix. bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From vfuria at gmail.com Mon Jul 20 13:42:45 2009 From: vfuria at gmail.com (Vincent Furia) Date: Mon, 20 Jul 2009 11:42:45 -0600 Subject: [geeklog-devel] Fwd: [contact-us] array getting fetched?! In-Reply-To: <20090719201220.714191134@smtp.haun-online.de> References: <20090706050554.1621244056@smtp.haun-online.de> <8319e2d60907062016t2d6d253h1080b9c263965d4c@mail.gmail.com> <20090719201220.714191134@smtp.haun-online.de> Message-ID: <8319e2d60907201042n3ed139d9h21d62934d9150156@mail.gmail.com> The one line fix for this problem will be in Stan's GSOC repository. I assigned this bug to myself so that I can refactor that function and make it more logical. There is no reason we should be overloading the CMT_getComment function in that way. First, I'll have to evaluate if any plugins are using that function directly to make sure I don't end up breaking things. In the mean time, it is working correctly with mysql and mssql. With the one line change in Stan's repository it will work with pgsql as well so there isn't a rush to get this done. -Vinny On Sun, Jul 19, 2009 at 2:12 PM, Dirk Haun wrote: > Vincent Furia wrote: > >>The CMT_getComment function overloads the use of the $comments variable in a >>way that pgsql doesn't like. We have a work around. Stan will be submitting >>a bug to the bugtracker to refactor that function (which I imagine I'll end >>up doing at some point). > > >From what I see, it's only a one-line fix. Or is there more coming? > > ? ?http://project.geeklog.net/tracking/view.php?id=927 > > Since 1.6.0 is out, the repository is open for commits again. Stan, I > assigned you that bug - feel free to commit your fix. > > bye, Dirk > > > -- > http://www.geeklog.net/ > http://geeklog.info/ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > From dirk at haun-online.de Mon Jul 20 14:21:39 2009 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 20 Jul 2009 20:21:39 +0200 Subject: [geeklog-devel] Fwd: [contact-us] array getting fetched?! In-Reply-To: <8319e2d60907201042n3ed139d9h21d62934d9150156@mail.gmail.com> References: <20090706050554.1621244056@smtp.haun-online.de> <8319e2d60907062016t2d6d253h1080b9c263965d4c@mail.gmail.com> <20090719201220.714191134@smtp.haun-online.de> <8319e2d60907201042n3ed139d9h21d62934d9150156@mail.gmail.com> Message-ID: <20090720182139.1530475510@smtp.haun-online.de> Vincent Furia wrote: >In the mean time, it is working correctly with mysql and mssql. With >the one line change in Stan's repository it will work with pgsql as >well so there isn't a rush to get this done. Thanks for the explanation. I thought it was an easy fix and wanted to get it off the list. Since it isn't - take your time :-) bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From dirk at haun-online.de Sat Jul 25 04:51:32 2009 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 25 Jul 2009 10:51:32 +0200 Subject: [geeklog-devel] Merge vs. Rebase Message-ID: <20090725085132.497888536@smtp.haun-online.de> When you take a look at our Mercurial repository right now, you'll notice a rather odd timeline for the latest couple of changes: --- snip --- 2 weeks ago Dirk Haun For Remote Users, display their service name in the User Editor 2 weeks ago Dirk Haun Replaced hard-coded 'N/A' with $LANG_ADMIN['na'] 2 weeks ago Dirk Haun Use COM_numberFormat to format the number of registered and anonymous users displayed in the Who's Online block 5 days ago Dirk Haun Added tag geeklog_1_6_0_stable for changeset f461a0655b76 --- snip --- So how can changes from two weeks ago end up being on top of newer changes? Two weeks ago, I made those changes on a separate branch. 1.6.0 was almost done, so I didn't want to introduce new changes at the last minute, but I had some free time and wanted to prepare a few things for future Geeklog versions. So far, so good. So now that 1.6.0 is out, how can I get these changes into the main repository? The standard way would be to do a merge between 1.6.0 and my feature-branch (the name of my local repository). A merge would 1) introduce an additional merge commit 2) hide the changes somewhere in the history, since these changes happened two weeks ago For this and other situations, an alternative approach is to do a rebase. Here's a nice article that explains things better (and with pictures) than I could: In a nutshell, a rebase cuts out the changes from the feature branch and applies them on top of the current branch. And this is exactly what I did here. I know that a few people (including our GSoC students) are working on new features using their own branches and I just wanted to point out an alternative to merging. Whether using merge or rebase makes more sense depends on the context and the type of changes, I guess. bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From dirk at haun-online.de Sat Jul 25 13:47:43 2009 From: dirk at haun-online.de (Dirk Haun) Date: Sat, 25 Jul 2009 19:47:43 +0200 Subject: [geeklog-devel] [geeklog-cvs] geeklog: Added support for Bcc - Blind copy. In-Reply-To: <20090615184714.299668630@smtp.haun-online.de> References: <20090615184714.299668630@smtp.haun-online.de> Message-ID: <20090725174743.1946161279@smtp.haun-online.de> Coming back to this: >>details: http://project.geeklog.net/cgi-bin/hgweb.cgi/rev/3b8700815448 >>changeset: 7122:3b8700815448 >>user: blaine Lang >>date: Mon Jun 15 10:07:53 2009 -0400 >>description: >>Added support for Bcc - Blind copy. > >Blaine, any objections if we roll back that change and push it to 1.6.1 >instead? COM_mail currently looks like this: function COM_mail( $to, $subject, $message, $from = '', $html = false, $priority = 0, $cc = '' ) My suggestion would be to turn $cc into an array of additional email headers. If it's an array, then it's supposed to consist of Header Name / Value pairs, e.g. array('Cc' => 'john at example.com', 'Bcc' => 'jane at example.com', ...) For backward compatibility, we would of course also accept a string value, in which case it's simply the CC address. Comments? bye, Dirk -- http://www.geeklog.net/ http://geeklog.info/ From vfuria at gmail.com Sun Jul 26 22:37:09 2009 From: vfuria at gmail.com (Vincent Furia) Date: Sun, 26 Jul 2009 20:37:09 -0600 Subject: [geeklog-devel] [geeklog-cvs] geeklog: Added support for Bcc - Blind copy. In-Reply-To: <20090725174743.1946161279@smtp.haun-online.de> References: <20090615184714.299668630@smtp.haun-online.de> <20090725174743.1946161279@smtp.haun-online.de> Message-ID: <8319e2d60907261937k52b6cd48y155c050dc0872016@mail.gmail.com> Sounds good to me. But maybe we should consider marking the function as obsolete and create a "COM_mail" class to send email? -Vinny On Sat, Jul 25, 2009 at 11:47 AM, Dirk Haun wrote: > Coming back to this: > > >>details: http://project.geeklog.net/cgi-bin/hgweb.cgi/rev/3b8700815448 > >>changeset: 7122:3b8700815448 > >>user: blaine Lang > >>date: Mon Jun 15 10:07:53 2009 -0400 > >>description: > >>Added support for Bcc - Blind copy. > > > >Blaine, any objections if we roll back that change and push it to 1.6.1 > >instead? > > COM_mail currently looks like this: > > function COM_mail( $to, $subject, $message, $from = '', $html = false, > $priority = 0, $cc = '' ) > > My suggestion would be to turn $cc into an array of additional email > headers. If it's an array, then it's supposed to consist of Header > Name / Value pairs, e.g. > > array('Cc' => 'john at example.com', 'Bcc' => 'jane at example.com', ...) > > For backward compatibility, we would of course also accept a string > value, in which case it's simply the CC address. > > Comments? > > bye, Dirk > > > -- > http://www.geeklog.net/ > http://geeklog.info/ > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > -------------- next part -------------- An HTML attachment was scrubbed... URL: