[geeklog-devel] Updating a plugin in the Plugin Repository

[Matt West]

On May 28, 2009, at 4:42 PM, Dirk Haun wrote:


> Tim asked about this on IRC and we decided to move the discussion  

> here.

>

> So say you already have a plugin in the Plugin Repository. Now someone

> (the developer or an admin) wants to update it. How would that work?

>

> My take is to model this somewhat after how the File Management plugin

> does it (minus the bugs):

>

> - Click on an "Edit" link

> - You can now edit the description and select a new file for upload

> - Click "update"

>

> What happens then depends on a variety of options we talked about

> before, e.g. is the person allowed to update the plugin directly or  

> does

> it have to go through re-approval by a moderator?

>

> If it goes into the moderation queue, you should still be able to

> download the old version until the update is approved. So you would  

> need

> two db entries (which you would need anyway, if you're using the

> Moderation API).

>

> Who can replace a file? A "Plugin Repository Admin" in any case. And  

> if

> you allow public uploads (as, say, on geeklog.net) then anybody should

> be able to submit an update. Plugins may change ownership or two  

> people

> may be working on a plugin, etc., so I don't see a reason to  

> restrict that.

>

> Also, it shouldn't require that the newly uploaded file has a  

> different

> filename than the old version (as the File Management plugin does - I

> consider this a bug). Preferrably, the file name would be editable

> without having to re-upload the file (typos happen ...).


I think the method you suggested would work well. Have we decided if  
we're supporting multiple plugin "owners/maintainers" or just one? I  
think we should support multiple. We could keep a list of  
"maintainers" for each plugin that could be defined both when the  
plugin is first uploaded and edited later.

As far as moderation, maybe let that be determined with a moderation  
setting in the repository's configuration:
- Require moderation for all updated plugins.
- Don't require moderation for updated plugins, allow plugin owners  
and maintainers complete control.

I think we should apply these same requirements for deleting plugins.

Matt