[geeklog-devel] plugin_autoinstall - two more issues
Randy.Kolenko at nextide.ca
Tue Oct 6 09:26:23 EDT 2009
> returned by plugin_autoinstall_foo it's own function. If the function
> was successful, it returned a string containing a SQL statement that
> would undo whatever that function just did. This value is assigned
So, how does returning 1 line of sql help remove data structures created
in a dependent plugin's table structure -- especially when the table
structure is relational?
I would have thought a simpler approach would have been to include the
failed installed plugin's functions.inc file and simply call the
autouninstall function to cleanly uninstall it.
You have to write the uninstall function anyways, so might as well use
it properly.. The original bug noted by Blaine is that the PLG_uninstall
will never work during a failure in the autoinstall method due to the
functions.inc file not being included for the failed plugin.
More information about the geeklog-devel