From websitemaster at cogeco.net Sat Oct 1 10:31:36 2011 From: websitemaster at cogeco.net (Tom) Date: Sat, 1 Oct 2011 10:31:36 -0400 Subject: [geeklog-devel] Geeklog Topics - This is how they will work In-Reply-To: <1317432070.35743.YahooMailNeo@web161404.mail.bf1.yahoo.com> References: <1317432070.35743.YahooMailNeo@web161404.mail.bf1.yahoo.com> Message-ID: <026201cc8046$d3496390$79dc2ab0$@cogeco.net> I just looked at the session code a bit and I see what you mean. Anonymous users are not really tracked. As far as I can tell no session cookie is set for them and the session id just keeps changing when an anonymous user goes from page to page, it looks like anonymous users are just tracked by ip. I do not really want to get into modifying the session library but it looks like I probably do not have a choice if this is the direction I want to go. The library probably should be rewritten to use php sessions but that is beyond the scope of what I have planned to do. Does anyone have a problem if I go ahead and add in anonymous user tracking by the use of the session cookie and then add in the ability of Geeklog to set the current topic in the Geeklog sessions table? Would this create any problems elsewhere? Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Joe Mucchiello Sent: September-30-11 9:21 PM To: geeklog-devel at lists.geeklog.net Subject: Re: [geeklog-devel] Geeklog Topics - This is how they will work When I last looked at this, the problem was the session code. I don't think it has changed much since then. There is no reliable way to find out what session is the "current" session because lib-session does not expose such a variable. And there are a few edge cases in the code that makes it a bit of a hassle to try exposing the session with a healthy restructuring of the session code. IIRC, going from not logged in to logged in is one of those edge cases. _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From dirk at haun-online.de Mon Oct 3 11:19:56 2011 From: dirk at haun-online.de (Dirk Haun) Date: Mon, 3 Oct 2011 17:19:56 +0200 Subject: [geeklog-devel] 1.8.1 In-Reply-To: <01a401cc7ac6$e9e3b770$bdab2650$@cogeco.net> References: <20110624133138.9164384jmqc7tuas@webmail.df.eu> <1308916307.1804.8.camel@roccivic-pc> <025901cc3267$570753a0$0515fae0$@cogeco.net> <20110624164720.9052387slu8vhl0k@webmail.df.eu> <312E4896-7DC1-4197-A1CB-0806E1151F0D@haun-online.de> <009801cc6c17$98ee1850$caca48f0$@cogeco.net> <7554C68E-0B1D-4636-BE78-5B7AF4A8781B@haun-online.de> <00e001cc6c9e$bf687bb0$3e397310$@cogeco.net> <74018DD2-E2D2-4B87-B0C2-18EC213AD460@haun-online.de> <7E72692B-6360-4DB3-B171-9F7162EAFF48@haun-online.de> <01a401cc7ac6$e9e3b770$bdab2650$@cogeco.net> Message-ID: <115D173E-5933-4A84-9912-876762077107@haun-online.de> Tom wrote: > You probably noticed but I have added 2 censor bug reports (one with a fix) Okay, so the two censoring bugs #1392 and #1393 are fixed. I think we should push the follow-up bug #1395 to 1.9.0 and think about releasing 1.8.1 real soon now. Does anyone think we need an rc2? I'd rather see us move on to 1.9.0 now. We also need to get the plugin authors on board to test their plugins with 1.9.0 (remember that we have "nightly" tarballs) so that plugins can be updated for the topic/blocks changes and tested with MySQLi (which is more picky than the old MySQL API - I've had a few issues with older plugins ?). bye, Dirk From websitemaster at cogeco.net Mon Oct 3 12:25:32 2011 From: websitemaster at cogeco.net (Tom) Date: Mon, 3 Oct 2011 12:25:32 -0400 Subject: [geeklog-devel] 1.8.1 In-Reply-To: <115D173E-5933-4A84-9912-876762077107@haun-online.de> References: <20110624133138.9164384jmqc7tuas@webmail.df.eu> <1308916307.1804.8.camel@roccivic-pc> <025901cc3267$570753a0$0515fae0$@cogeco.net> <20110624164720.9052387slu8vhl0k@webmail.df.eu> <312E4896-7DC1-4197-A1CB-0806E1151F0D@haun-online.de> <009801cc6c17$98ee1850$caca48f0$@cogeco.net> <7554C68E-0B1D-4636-BE78-5B7AF4A8781B@haun-on <115D173E-5933-4A84-9912-876762077107@haun-online.de> Message-ID: <00a601cc81e9$12906dc0$37b14940$@cogeco.net> That sounds fine with me. I don't think we need a RC2. >> We also need to get the plugin authors on board to test their plugins with 1.9.0 Most plugin authors who use blocks "the old way" should be able to switch them to dynamic with few problems (use the updated polls or calendar code as example) and still retain all the functionality of a regular PHP Block. We should discourage Plugin authors from accessing the blocks table directly (or any Core table). The multiple topics and child topics stuff I am working on shouldn't require any changes by plugin authors. Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-03-11 11:20 AM To: Geeklog Development Subject: Re: [geeklog-devel] 1.8.1 Tom wrote: > You probably noticed but I have added 2 censor bug reports (one with a fix) Okay, so the two censoring bugs #1392 and #1393 are fixed. I think we should push the follow-up bug #1395 to 1.9.0 and think about releasing 1.8.1 real soon now. Does anyone think we need an rc2? I'd rather see us move on to 1.9.0 now. We also need to get the plugin authors on board to test their plugins with 1.9.0 (remember that we have "nightly" tarballs) so that plugins can be updated for the topic/blocks changes and tested with MySQLi (which is more picky than the old MySQL API - I've had a few issues with older plugins .). bye, Dirk _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Tue Oct 4 10:04:35 2011 From: websitemaster at cogeco.net (Tom) Date: Tue, 4 Oct 2011 10:04:35 -0400 Subject: [geeklog-devel] Geeklog Sessions Message-ID: <00fd01cc829e$8e25fe40$aa71fac0$@cogeco.net> Okay, I have Geeklog tracking ongoing anonymous sessions properly now. At some point I will be adding a column to the sessions table called topic. The topic column will be added to the $_User variable and will allow Geeklog and plugins to figure out which topic to display. I am thinking that I should add a another column to the sessions table for the who's online block. Right now the who's online block deletes records from the sessions table that reaches the Session Threshold defined in the configuration under the who's online block (default 300 seconds). We also have the Session Timeout (default 2 hours) and Permanent Timeout options under Cookies. I think the session records should only be deleted when the Session Timeout is reached. The who's online block should just flag records in the sessions table that do not meet its standard of being online. Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-01-11 10:32 AM To: 'Joe Mucchiello'; 'Geeklog Development' Subject: Re: [geeklog-devel] Geeklog Topics - This is how they will work I just looked at the session code a bit and I see what you mean. Anonymous users are not really tracked. As far as I can tell no session cookie is set for them and the session id just keeps changing when an anonymous user goes from page to page, it looks like anonymous users are just tracked by ip. I do not really want to get into modifying the session library but it looks like I probably do not have a choice if this is the direction I want to go. The library probably should be rewritten to use php sessions but that is beyond the scope of what I have planned to do. Does anyone have a problem if I go ahead and add in anonymous user tracking by the use of the session cookie and then add in the ability of Geeklog to set the current topic in the Geeklog sessions table? Would this create any problems elsewhere? Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Joe Mucchiello Sent: September-30-11 9:21 PM To: geeklog-devel at lists.geeklog.net Subject: Re: [geeklog-devel] Geeklog Topics - This is how they will work When I last looked at this, the problem was the session code. I don't think it has changed much since then. There is no reliable way to find out what session is the "current" session because lib-session does not expose such a variable. And there are a few edge cases in the code that makes it a bit of a hassle to try exposing the session with a healthy restructuring of the session code. IIRC, going from not logged in to logged in is one of those edge cases. _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Wed Oct 5 14:16:12 2011 From: websitemaster at cogeco.net (Tom) Date: Wed, 5 Oct 2011 14:16:12 -0400 Subject: [geeklog-devel] Geeklog.net Forum Message-ID: <019b01cc838a$dcee1de0$96ca59a0$@cogeco.net> FYI I have updated the Geeklog Forum with a bug fix that deals with users not receiving notification of replies on forum topics. This bug would happen if a user replied to a post and checked the "Notify me of replies" checkbox. The checkbox had no value specified so the notification request was never recorded when the post was saved. If you notice any problems with the forum due to notifications still, please let me know. Tom From websitemaster at cogeco.net Fri Oct 7 15:19:05 2011 From: websitemaster at cogeco.net (Tom) Date: Fri, 7 Oct 2011 15:19:05 -0400 Subject: [geeklog-devel] Geeklog Topics Message-ID: <002601cc8525$faa0d430$efe27c90$@cogeco.net> Okay, I am going to be checking in the Geeklog Sessions update and part of the Topic update soon (next week sometime) so more testing can be done since I might have missed something. I also want to make sure everyone agrees with how the security, etc. works. The session changes include the ability to track anonymous users, and the who's online block now uses a column in the session table to track online versus offline users. The topic updates includes the ability to add a topic as a child to another topic. New fields in the Topic admin form include parent topic, hidden and inherit. New rules have been added to this form so admin's shouldn't be able to have the parent topic of a topic be the child (or grandchild, etc.) of the same topic. You also shouldn't be able to make your topic be a child of a topic you do not have access to. Admins are going to have to keep an eye on what topics are hidden and what security is set. If you remove read access for anonymous from the top topic then anonymous users will not have access to that topic only. They still would have access to child topics if their security allowed it (though these will not be displayed in the topics block since the path is broken). At some point we could add a checkbox to the Access Rights section to allow permissions to be set for child topics as well if checked and the topic was saved. The Topics block has been updated. It now shows the tree structure of the topics. Topics have several properties that affect them being displayed in this block. These are Security, if it is Hidden, and if it is a Topic for a different language. How it works is if the visitor doesn't have access to the child topic, or if it is hidden or in another language then it is not displayed. If it is not displayed then none of its child topics are displayed (even if the visitor would have access to the topic) Right now stories display in their topic but are not inherited (and no stories in multiple topics yet) Next up I will be working on getting the blocks from a child topic to be inherited by a parent topic when viewed. So once I have committed these changes and if you have a few moments I could use some people to just double check that the topics work as advertised. Thanks Tom From cordiste at free.fr Sat Oct 8 05:51:58 2011 From: cordiste at free.fr (cordiste) Date: Sat, 8 Oct 2011 11:51:58 +0200 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <002601cc8525$faa0d430$efe27c90$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> Message-ID: >> I could use some people to just double check that the topics work as advertised Ok Ben 2011/10/7 Tom : > Okay, > > I am going to be checking in the Geeklog Sessions update and part of the > Topic update soon (next week sometime) so more testing can be done since I > might have missed something. I also want to make sure everyone agrees with > how the security, etc. works. > > The session changes include the ability to track anonymous users, and the > who's online block now uses a column in the session table to track online > versus offline users. > > The topic updates includes the ability to add a topic as a child to another > topic. New fields in the Topic admin form include parent topic, hidden and > inherit. New rules have been added to this form so admin's shouldn't be able > to have the parent topic of a topic be the child (or grandchild, etc.) of > the same topic. You also shouldn't be able to make your topic be a child of > a topic you do not have access to. > > Admins are going to have to keep an eye on what topics are hidden and what > security is set. If you remove read access for anonymous from the top topic > then anonymous users will not have access to that topic only. They still > would have access to child topics if their security allowed it (though these > will not be displayed in the topics block since the path is broken). At some > point we could add a checkbox to the Access Rights section to allow > permissions to be set for child topics as well if checked and the topic was > saved. > > The Topics block has been updated. It now shows the tree structure of the > topics. Topics have several properties that affect them being displayed in > this block. These are Security, if it is Hidden, and if it is a Topic for a > different language. How it works is if the visitor doesn't have access to > the child topic, or if it is hidden or in another language then it is not > displayed. If it is not displayed then none of its child topics are > displayed (even if the visitor would have access to the topic) > > Right now stories display in their topic but are not inherited (and no > stories in multiple topics yet) > > Next up I will be working on getting the blocks from a child topic to be > inherited by a parent topic when viewed. > > So once I have committed these changes and if you have a few moments I could > use some people to just double check that the topics work as advertised. > > Thanks > > Tom > > > > _______________________________________________ > geeklog-devel mailing list > geeklog-devel at lists.geeklog.net > http://eight.pairlist.net/mailman/listinfo/geeklog-devel > > From jamil_fawad at hotmail.com Sun Oct 9 00:25:22 2011 From: jamil_fawad at hotmail.com (jamil_fawad at hotmail.com) Date: Sun, 9 Oct 2011 09:25:22 +0500 Subject: [geeklog-devel] I am my own boss... Message-ID: Hi Friend. I needed money fast I was back on my feet in no time because of this now im in this for the long run you would really love this http://berlineronlinen.be.funpic.de/CarlMitchell70.html see you. -------------- next part -------------- An HTML attachment was scrubbed... URL: From websitemaster at cogeco.net Mon Oct 10 14:33:58 2011 From: websitemaster at cogeco.net (Tom) Date: Mon, 10 Oct 2011 14:33:58 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <002601cc8525$faa0d430$efe27c90$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> Message-ID: <00f801cc877b$2c644e00$852cea00$@cogeco.net> Okay I have committed the parent topic and session changes. New installs and upgrades have been tested in mysql but not mssql or pgsql. There are also a few functions that I still need to comment, and I will be depreciation a few topic functions in lib-common and moving them to lib-topic. The topic functions may also change slightly still as I work on adding - allowing a story to have multiple topics (plus everything else that is connected to stories and topics) - allowing stories to be inherited by parent topics - allowing a staticpage to be displayed in multiple topics (instead of just all topics) As I said before, my next step will be finishing work on the blocks and getting them to be inherited by topics. Once this is finished I will commit this work and then start on the story stuff Please let me know if you find any bugs related to this commit. Thanks Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-07-11 3:19 PM To: 'Geeklog Development' Subject: [geeklog-devel] Geeklog Topics Okay, I am going to be checking in the Geeklog Sessions update and part of the Topic update soon (next week sometime) so more testing can be done since I might have missed something. I also want to make sure everyone agrees with how the security, etc. works. The session changes include the ability to track anonymous users, and the who's online block now uses a column in the session table to track online versus offline users. The topic updates includes the ability to add a topic as a child to another topic. New fields in the Topic admin form include parent topic, hidden and inherit. New rules have been added to this form so admin's shouldn't be able to have the parent topic of a topic be the child (or grandchild, etc.) of the same topic. You also shouldn't be able to make your topic be a child of a topic you do not have access to. Admins are going to have to keep an eye on what topics are hidden and what security is set. If you remove read access for anonymous from the top topic then anonymous users will not have access to that topic only. They still would have access to child topics if their security allowed it (though these will not be displayed in the topics block since the path is broken). At some point we could add a checkbox to the Access Rights section to allow permissions to be set for child topics as well if checked and the topic was saved. The Topics block has been updated. It now shows the tree structure of the topics. Topics have several properties that affect them being displayed in this block. These are Security, if it is Hidden, and if it is a Topic for a different language. How it works is if the visitor doesn't have access to the child topic, or if it is hidden or in another language then it is not displayed. If it is not displayed then none of its child topics are displayed (even if the visitor would have access to the topic) Right now stories display in their topic but are not inherited (and no stories in multiple topics yet) Next up I will be working on getting the blocks from a child topic to be inherited by a parent topic when viewed. So once I have committed these changes and if you have a few moments I could use some people to just double check that the topics work as advertised. Thanks Tom _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Thu Oct 13 14:12:13 2011 From: websitemaster at cogeco.net (Tom) Date: Thu, 13 Oct 2011 14:12:13 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <00f801cc877b$2c644e00$852cea00$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> Message-ID: <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> My latest commit includes: Blocks can now be inherited from child topics. Remember Blocks being inherited is affected by several things including security, the language of the block, the inherited flag set for that topic assignment for the block, and if the topics themselves allow objects to be inherited. I have also worked out a topic selection control that is used by blocks and will be used by stories and plugins (if needed). The control functions may change as I update the stories and staticpage plugins. Right now there is a function to call to get the control for the admin edit form, a function to call to check if the user does still indeed have access to all the topics he has selected and a function to save the data from the control. Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-10-11 2:34 PM To: 'Geeklog Development' Subject: Re: [geeklog-devel] Geeklog Topics Okay I have committed the parent topic and session changes. New installs and upgrades have been tested in mysql but not mssql or pgsql. There are also a few functions that I still need to comment, and I will be depreciation a few topic functions in lib-common and moving them to lib-topic. The topic functions may also change slightly still as I work on adding - allowing a story to have multiple topics (plus everything else that is connected to stories and topics) - allowing stories to be inherited by parent topics - allowing a staticpage to be displayed in multiple topics (instead of just all topics) As I said before, my next step will be finishing work on the blocks and getting them to be inherited by topics. Once this is finished I will commit this work and then start on the story stuff Please let me know if you find any bugs related to this commit. Thanks Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-07-11 3:19 PM To: 'Geeklog Development' Subject: [geeklog-devel] Geeklog Topics Okay, I am going to be checking in the Geeklog Sessions update and part of the Topic update soon (next week sometime) so more testing can be done since I might have missed something. I also want to make sure everyone agrees with how the security, etc. works. The session changes include the ability to track anonymous users, and the who's online block now uses a column in the session table to track online versus offline users. The topic updates includes the ability to add a topic as a child to another topic. New fields in the Topic admin form include parent topic, hidden and inherit. New rules have been added to this form so admin's shouldn't be able to have the parent topic of a topic be the child (or grandchild, etc.) of the same topic. You also shouldn't be able to make your topic be a child of a topic you do not have access to. Admins are going to have to keep an eye on what topics are hidden and what security is set. If you remove read access for anonymous from the top topic then anonymous users will not have access to that topic only. They still would have access to child topics if their security allowed it (though these will not be displayed in the topics block since the path is broken). At some point we could add a checkbox to the Access Rights section to allow permissions to be set for child topics as well if checked and the topic was saved. The Topics block has been updated. It now shows the tree structure of the topics. Topics have several properties that affect them being displayed in this block. These are Security, if it is Hidden, and if it is a Topic for a different language. How it works is if the visitor doesn't have access to the child topic, or if it is hidden or in another language then it is not displayed. If it is not displayed then none of its child topics are displayed (even if the visitor would have access to the topic) Right now stories display in their topic but are not inherited (and no stories in multiple topics yet) Next up I will be working on getting the blocks from a child topic to be inherited by a parent topic when viewed. So once I have committed these changes and if you have a few moments I could use some people to just double check that the topics work as advertised. Thanks Tom _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From dirk at haun-online.de Thu Oct 13 15:02:40 2011 From: dirk at haun-online.de (Dirk Haun) Date: Thu, 13 Oct 2011 21:02:40 +0200 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> Message-ID: <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> Just got a chance to poke around a bit, so here are some quick observations: I promptly ran into an error in the old forum plugin (forgot the details, but it did involve "tid") when trying to migrate a geeklog.net backup to my local test setup. So this is one example of a plugin that we need to tell people about (I assume the new forum plugin will have addressed that by the time 1.9.0 is out). I get an SQL error when calling up directory.php. There's an empty IN() in the SQL here: "SELECT b.*,UNIX_TIMESTAMP(rdfupdated) AS date FROM blocks b, topic_assignments ta WHERE ta.type = 'block' AND ta.id = bid AND is_enabled = 1 AND onleft = 1 AND (ta.tid IN() AND (ta.inherit = 1 OR (ta.inherit = 0 AND ta.tid = 'all')) OR ta.tid = 'all') ORDER BY blockorder,title ASC" which comes from line 3608ff in lib-common.php: if(!empty($topic)) { // Retrieve list of inherited topics $tid_list = TOPIC_getChildList($topic); I guess the $tid_list is empty. Do you plan to redesign the admin's list of topics, too? Now that we have subtopics, there should be a way to see that relationship (like with categories in the Links plugin). There's an old feature request for this: http://project.geeklog.net/tracking/view.php?id=968 Playing with the security aspect of subtopics, I get the same SQL error as above like so: Topic Subtopic Subsubtopic Then make "Subtopic" not accessible for Anonymous users and try to call up the URL of a story in "Subsubtopic". I don't understand the code enough yet to know whether an empty $tid_list is already a problem - or if it's allowed and the code just has to check for it. bye, Dirk From websitemaster at cogeco.net Thu Oct 13 16:37:17 2011 From: websitemaster at cogeco.net (Tom) Date: Thu, 13 Oct 2011 16:37:17 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> Message-ID: <008e01cc89e7$e5c93040$b15b90c0$@cogeco.net> Thanks Dirk I will take a look at the issues. I think I know what the problem is. I am surprised I didn't run into it before with my test topic tree that has 22 topics with all of its different permissions, language and inherit settings ;-) >> Do you plan to redesign the admin's list of topics, too? It is like the last thing on the list. The current form works but obviously it doesn't show the relationships. I was hoping someone else may take a stab at it ... maybe even use a tree control from jQuery or something ... Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-13-11 3:03 PM To: Geeklog Development Subject: Re: [geeklog-devel] Geeklog Topics Just got a chance to poke around a bit, so here are some quick observations: I promptly ran into an error in the old forum plugin (forgot the details, but it did involve "tid") when trying to migrate a geeklog.net backup to my local test setup. So this is one example of a plugin that we need to tell people about (I assume the new forum plugin will have addressed that by the time 1.9.0 is out). I get an SQL error when calling up directory.php. There's an empty IN() in the SQL here: "SELECT b.*,UNIX_TIMESTAMP(rdfupdated) AS date FROM blocks b, topic_assignments ta WHERE ta.type = 'block' AND ta.id = bid AND is_enabled = 1 AND onleft = 1 AND (ta.tid IN() AND (ta.inherit = 1 OR (ta.inherit = 0 AND ta.tid = 'all')) OR ta.tid = 'all') ORDER BY blockorder,title ASC" which comes from line 3608ff in lib-common.php: if(!empty($topic)) { // Retrieve list of inherited topics $tid_list = TOPIC_getChildList($topic); I guess the $tid_list is empty. Do you plan to redesign the admin's list of topics, too? Now that we have subtopics, there should be a way to see that relationship (like with categories in the Links plugin). There's an old feature request for this: http://project.geeklog.net/tracking/view.php?id=968 Playing with the security aspect of subtopics, I get the same SQL error as above like so: Topic Subtopic Subsubtopic Then make "Subtopic" not accessible for Anonymous users and try to call up the URL of a story in "Subsubtopic". I don't understand the code enough yet to know whether an empty $tid_list is already a problem - or if it's allowed and the code just has to check for it. bye, Dirk _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Mon Oct 17 11:39:41 2011 From: websitemaster at cogeco.net (Tom) Date: Mon, 17 Oct 2011 11:39:41 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <008e01cc89e7$e5c93040$b15b90c0$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> <008e01cc89e7$e5c93040$b15b90c0$@cogeco.net> Message-ID: <01ff01cc8ce2$fc9df690$f5d9e3b0$@cogeco.net> For Multilanguage sites I currently allow topics not assigned to a language to be displayed along with any topics assigned to that language (blocks do this as well) in the Topics Block. I just realized that previously only topics assigned to that language would display in the topics block. So for Multilanguage sites do we want topics not assigned to any language to display in this block or should I switch it back to the old way? Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-13-11 4:37 PM To: 'Geeklog Development' Subject: Re: [geeklog-devel] Geeklog Topics Thanks Dirk I will take a look at the issues. I think I know what the problem is. I am surprised I didn't run into it before with my test topic tree that has 22 topics with all of its different permissions, language and inherit settings ;-) >> Do you plan to redesign the admin's list of topics, too? It is like the last thing on the list. The current form works but obviously it doesn't show the relationships. I was hoping someone else may take a stab at it ... maybe even use a tree control from jQuery or something ... Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-13-11 3:03 PM To: Geeklog Development Subject: Re: [geeklog-devel] Geeklog Topics Just got a chance to poke around a bit, so here are some quick observations: I promptly ran into an error in the old forum plugin (forgot the details, but it did involve "tid") when trying to migrate a geeklog.net backup to my local test setup. So this is one example of a plugin that we need to tell people about (I assume the new forum plugin will have addressed that by the time 1.9.0 is out). I get an SQL error when calling up directory.php. There's an empty IN() in the SQL here: "SELECT b.*,UNIX_TIMESTAMP(rdfupdated) AS date FROM blocks b, topic_assignments ta WHERE ta.type = 'block' AND ta.id = bid AND is_enabled = 1 AND onleft = 1 AND (ta.tid IN() AND (ta.inherit = 1 OR (ta.inherit = 0 AND ta.tid = 'all')) OR ta.tid = 'all') ORDER BY blockorder,title ASC" which comes from line 3608ff in lib-common.php: if(!empty($topic)) { // Retrieve list of inherited topics $tid_list = TOPIC_getChildList($topic); I guess the $tid_list is empty. Do you plan to redesign the admin's list of topics, too? Now that we have subtopics, there should be a way to see that relationship (like with categories in the Links plugin). There's an old feature request for this: http://project.geeklog.net/tracking/view.php?id=968 Playing with the security aspect of subtopics, I get the same SQL error as above like so: Topic Subtopic Subsubtopic Then make "Subtopic" not accessible for Anonymous users and try to call up the URL of a story in "Subsubtopic". I don't understand the code enough yet to know whether an empty $tid_list is already a problem - or if it's allowed and the code just has to check for it. bye, Dirk _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Wed Oct 19 10:43:53 2011 From: websitemaster at cogeco.net (Tom) Date: Wed, 19 Oct 2011 10:43:53 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> Message-ID: <00b501cc8e6d$85df38c0$919daa40$@cogeco.net> Okay the directory and child topic permissions issue has been fixed and committed. Please continue testing. Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-13-11 3:03 PM To: Geeklog Development Subject: Re: [geeklog-devel] Geeklog Topics Just got a chance to poke around a bit, so here are some quick observations: I promptly ran into an error in the old forum plugin (forgot the details, but it did involve "tid") when trying to migrate a geeklog.net backup to my local test setup. So this is one example of a plugin that we need to tell people about (I assume the new forum plugin will have addressed that by the time 1.9.0 is out). I get an SQL error when calling up directory.php. There's an empty IN() in the SQL here: "SELECT b.*,UNIX_TIMESTAMP(rdfupdated) AS date FROM blocks b, topic_assignments ta WHERE ta.type = 'block' AND ta.id = bid AND is_enabled = 1 AND onleft = 1 AND (ta.tid IN() AND (ta.inherit = 1 OR (ta.inherit = 0 AND ta.tid = 'all')) OR ta.tid = 'all') ORDER BY blockorder,title ASC" which comes from line 3608ff in lib-common.php: if(!empty($topic)) { // Retrieve list of inherited topics $tid_list = TOPIC_getChildList($topic); I guess the $tid_list is empty. Do you plan to redesign the admin's list of topics, too? Now that we have subtopics, there should be a way to see that relationship (like with categories in the Links plugin). There's an old feature request for this: http://project.geeklog.net/tracking/view.php?id=968 Playing with the security aspect of subtopics, I get the same SQL error as above like so: Topic Subtopic Subsubtopic Then make "Subtopic" not accessible for Anonymous users and try to call up the URL of a story in "Subsubtopic". I don't understand the code enough yet to know whether an empty $tid_list is already a problem - or if it's allowed and the code just has to check for it. bye, Dirk _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Tue Oct 25 12:21:15 2011 From: websitemaster at cogeco.net (Tom) Date: Tue, 25 Oct 2011 12:21:15 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <00b501cc8e6d$85df38c0$919daa40$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> <00b501cc8e6d$85df38c0$919daa40$@cogeco.net> Message-ID: <017f01cc9332$1e65aed0$5b310c70$@cogeco.net> Just a quick update: I am slowly working in adding multiple topics for stories (a lot of changes) and I realized I had not properly dealt with an Archive Topic. Here are the rules for an Archive Topic: - You are allowed only one. This is the same as before but at some point we may want to change this since it doesn't work well with a multi language Geeklog install (I would assume most admins would want an archive topic per language unless there was a reason this was not added?). - Cannot be hidden - Cannot have Child Topics - Cannot be inherited - Stories that are archived can only belong to this topic and no other Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom Sent: October-19-11 10:44 AM To: 'Geeklog Development' Subject: Re: [geeklog-devel] Geeklog Topics Okay the directory and child topic permissions issue has been fixed and committed. Please continue testing. Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-13-11 3:03 PM To: Geeklog Development Subject: Re: [geeklog-devel] Geeklog Topics Just got a chance to poke around a bit, so here are some quick observations: I promptly ran into an error in the old forum plugin (forgot the details, but it did involve "tid") when trying to migrate a geeklog.net backup to my local test setup. So this is one example of a plugin that we need to tell people about (I assume the new forum plugin will have addressed that by the time 1.9.0 is out). I get an SQL error when calling up directory.php. There's an empty IN() in the SQL here: "SELECT b.*,UNIX_TIMESTAMP(rdfupdated) AS date FROM blocks b, topic_assignments ta WHERE ta.type = 'block' AND ta.id = bid AND is_enabled = 1 AND onleft = 1 AND (ta.tid IN() AND (ta.inherit = 1 OR (ta.inherit = 0 AND ta.tid = 'all')) OR ta.tid = 'all') ORDER BY blockorder,title ASC" which comes from line 3608ff in lib-common.php: if(!empty($topic)) { // Retrieve list of inherited topics $tid_list = TOPIC_getChildList($topic); I guess the $tid_list is empty. Do you plan to redesign the admin's list of topics, too? Now that we have subtopics, there should be a way to see that relationship (like with categories in the Links plugin). There's an old feature request for this: http://project.geeklog.net/tracking/view.php?id=968 Playing with the security aspect of subtopics, I get the same SQL error as above like so: Topic Subtopic Subsubtopic Then make "Subtopic" not accessible for Anonymous users and try to call up the URL of a story in "Subsubtopic". I don't understand the code enough yet to know whether an empty $tid_list is already a problem - or if it's allowed and the code just has to check for it. bye, Dirk _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From dirk at haun-online.de Tue Oct 25 15:50:44 2011 From: dirk at haun-online.de (Dirk Haun) Date: Tue, 25 Oct 2011 21:50:44 +0200 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <017f01cc9332$1e65aed0$5b310c70$@cogeco.net> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> <00b501cc8e6d$85df38c0$919daa40$@cogeco.net> <017f01cc9332$1e65aed0$5b310c70$@cogeco.net> Message-ID: <07FFAF9F-9386-4ED0-AFAB-DD92390A2242@haun-online.de> Tom wrote: > - You are allowed only one. This is the same as before but at some point we > may want to change this since it doesn't work well with a multi language > Geeklog install (I would assume most admins would want an archive topic per > language unless there was a reason this was not added?). This may simply have been an oversight. The archive topic, as it is, isn't really all that useful - I'm wondering if people actually use it. So I'm open to changing how it works (at a later point, I guess). I think there's even an issue or two in the bugtracker. bye, Dirk -- http://www.themobilepresenter.com/ From websitemaster at cogeco.net Tue Oct 25 20:15:28 2011 From: websitemaster at cogeco.net (Tom) Date: Tue, 25 Oct 2011 20:15:28 -0400 Subject: [geeklog-devel] Geeklog Topics In-Reply-To: <07FFAF9F-9386-4ED0-AFAB-DD92390A2242@haun-online.de> References: <002601cc8525$faa0d430$efe27c90$@cogeco.net> <00f801cc877b$2c644e00$852cea00$@cogeco.net> <008401cc89d3$a1b2dbe0$e51893a0$@cogeco.net> <22DF3D94-0909-49DC-BE71-662FC820D60E@haun-online.de> <00b501cc8e6d$85df38c0$919daa40$@cogeco.net> <017f01cc9332$1e65aed0$5b310c70$@cogeco.net> <07FFAF9F-9386-4ED0-AFAB-DD92390A2242@haun-online.de> Message-ID: <01d101cc9374$5de3a070$19aae150$@cogeco.net> Most other CMS have some sort of archive topic. I have never used it but I am curious to find out how many people do. I added a feature request so we do not forget about the multi language archive topic. It shouldn't be too hard to do. One thing we will have to remember is when a site is switched from a multi language site to a single language that we make sure that there is only one archive topic again (not that this will happen often). Tom -----Original Message----- From: geeklog-devel-bounces at lists.geeklog.net [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun Sent: October-25-11 3:51 PM To: Geeklog Development Subject: Re: [geeklog-devel] Geeklog Topics Tom wrote: > - You are allowed only one. This is the same as before but at some > point we may want to change this since it doesn't work well with a > multi language Geeklog install (I would assume most admins would want > an archive topic per language unless there was a reason this was not added?). This may simply have been an oversight. The archive topic, as it is, isn't really all that useful - I'm wondering if people actually use it. So I'm open to changing how it works (at a later point, I guess). I think there's even an issue or two in the bugtracker. bye, Dirk -- http://www.themobilepresenter.com/ _______________________________________________ geeklog-devel mailing list geeklog-devel at lists.geeklog.net http://eight.pairlist.net/mailman/listinfo/geeklog-devel From websitemaster at cogeco.net Mon Oct 31 14:19:23 2011 From: websitemaster at cogeco.net (Tom) Date: Mon, 31 Oct 2011 14:19:23 -0400 Subject: [geeklog-devel] Topics and Featured articles Message-ID: <008001cc97f9$9dbf90d0$d93eb270$@cogeco.net> For now I have decided to leave featured topics working pretty much as is. Initially the thought was to move the featured flag from the stories table and store the article id that is featured in the topic, in the topic table. This will not work as expected since this will not let me store if an article is featured or not, if the article is published in the future. The other issue is that storing the featured article id in the topic table doesn't help if I need to figure out if it is a homepage featured story since I still need that featured flag found in the stories table. All of this of course could be thought over and fixed but I have a bit more work than I thought here converting stories to multiple topics. So, or now featured articles will work pretty much the same as before. If a story is featured it will be considered feature for all topics it is in. Tom