[geeklog-devel] emailstories from userprefs

[Dirk Haun]

Tom wrote:

> Not sure why there would be both. The 2 differences I see is the call in
> lib-user checks $_CONF['custom_registration'] first to see if it needs to
> call 
> 
> CUSTOM_userCreate($uid,$batchimport);
> 
> Plus it has the $batchimport flag.
> 
> Maybe Dirk knows more…


This looks like an accident / oversight. CUSTOM_userCreate was introduced with the $_CONF['custom_registration'] flag and CUSTOM_user_create was introduced to make sure all PLG_xxx functions have a corresponding CUSTOM_xxx function.

Not sure in which order the two additions were made, but the second change probably didn't realize that the other function already existed.

I'd vote for making the two calls behave the same and deprecating one of them. Technically, though, the call would better be suited for implementation in lib-plugins.php, but there it doesn't have access to $batchimport. Hmm ...

In any case, Ben, can you file a bug for this, please? Thanks.

bye, Dirk


-- 
http://www.themobilepresenter.com/