[geeklog-devel] Geeklog Feeds and how they are suppose to work?

[cordiste]

+1 for the comment feed integration into the core

Ben

2012/10/9 Tom <websitemaster at cogeco.net>:
> Grrr.... :-)
>
> While working on this fix I just realized why Geeklog feeds was run for all
> plugins in index.php and not just for articles.
>
> I think it mainly has to do with the commentfeeds plugin. This is the only
> way the commentfeeds plugin can currently be triggered since when a comment
> is created/updated/deleted no notification goes out to the plugins (and
> therefore it has no idea that the comment feed needs updating).
>
> I never really understood why we had a separate commentfeeds plugin and why
> the comment feed code was not just incorporated into Geeklog since the rest
> of the comment code is part of core.
>
> I think the best way around this is for me to go ahead and make comment
> feeds a part of core. This should be the only plugin affected since comments
> was the only part of core that did not have a feed.
>
> Too bad I wasted time updating the commentsfeed plugin. Anyways let me know
> who is for or against this change (and the reason why)
>
> Thanks
>
> Tom
>
>
>
> -----Original Message-----
> From: geeklog-devel-bounces at lists.geeklog.net
> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Tom
> Sent: October-06-12 4:48 PM
> To: 'Geeklog Development'
> Subject: Re: [geeklog-devel] Geeklog Feeds and how they are suppose to work?
>
>>> I'm still a little worried about a possible performance impact but if
>>> you
> think you've got that covered - go ahead.
>
> I think it will be okay,  it will be just doing a simple check against dates
> for the most part (sort of how the Geeklog cron works).
>
>
> -----Original Message-----
> From: geeklog-devel-bounces at lists.geeklog.net
> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun
> Sent: October-06-12 3:27 PM
> To: Geeklog Development
> Subject: Re: [geeklog-devel] Geeklog Feeds and how they are suppose to work?
>
> Tom wrote:
>
>> No that is not what it is doing. If you pass a type it does nothing
>> but pass it to all the plugins that have a feed.
>> plugin_feedupdatecheck_xxx is run for every plugin regardless of what
>> type
> is passed.
>
> You're right. And that doesn't make any sense.
>
>
>> So I will change the function to if a type is passed just run the
>> feed(s) for that plugin.
>
> I guess it would be enough to fix the first $sql assignment to check for
> (type = '$updated_type') instead of (type <> 'article')
>
>
>> What I plan to do is move the call to COM_rdfUpToDateCheck to
>> lib_common but it will only run for articles if it needs too. I will
>> store in Geeklog Var table the date/time of the lastest story that has
>> been publish. If a quick check of this compared to the article table
>> fails then COM_rdfUpToDateCheck will run for the articles and then the
>> var table will be updated. When an article is saved/updated/deleted I
>> will have to add an update to the var table as well.
>>
>> I do not plan to run it for other plugins in lib-common. Plugins can
>> take care of that themselves. :-)
>>
>> If that makes sense then I will go ahead and update the code.
>
>
> I'm still a little worried about a possible performance impact but if you
> think you've got that covered - go ahead.
>
> bye, Dirk
>
>
> --
> http://www.themobilepresenter.com/
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>