[geeklog-devel] Geeklog.net 2.1.0 Beta 1 Upgrade

[Tom]

Thanks for finding the point where the "1" gets added. Looking at the code I
don't see anywhere that function subst gets checked if it returns true.  A
string is assumed returned and the code continues. Your fix should work fine
for at least preventing the "1" from showing.

I still need to figure out why it happens in the first place sometimes for
instance caching (why the featured story was replaced by a "1") .

Tom

-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Wim Niemans
Sent: March-23-14 9:10 AM
To: Geeklog Development
Subject: Re: [geeklog-devel] Geeklog.net 2.1.0 Beta 1 Upgrade

Having the code examined, learns the following:

1. the cache routines make extensive use of 'file_get_contents' and handle
the return values in a buggy fashion.

2. The '1' is generated in the function subst($varname) by returning true:

           } else if (isset($this->varvals[$varname]) OR empty($varname)) {
               return $this->slow_subst($varname);
           } else {
               // $varname does not reference a file so return
               if ($this->debug & 4) {
                   echo "<p><b>subst:</b> varname $varname does not
reference a file</p>\n";
               }
               return true;
           }

3. Changing 'return true' into " return '' " removes the '1' occurrence.

4. The construct is present twice in the function. See lines 705, 738.

I am not sure if this change will do, or would generate other noise. 
Though I find it most strange for return true values in this function.

After all, this '1' is generated by parsing a unset varname ?? Really?

Wim


On 21 Mar 2014, at 11:40, Tom <websitemaster at cogeco.net> wrote:

> Thanks Wim. It gives me a place to start.
> 
> Tom
> 
> -----Original Message-----
> From: geeklog-devel-bounces at lists.geeklog.net
> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Wim 
> Niemans
> Sent: March-21-14 5:58 AM
> To: Geeklog Development
> Subject: Re: [geeklog-devel] Geeklog.net 2.1.0 Beta 1 Upgrade
> 
> It looks like the function file_get_contents can return a false or a 
> false-alike since php5.
> 
> Wim
> 
> On 19 Mar 2014, at 22:27, Tom <websitemaster at cogeco.net> wrote:
> 
>> This problem has happened again so I have disabled template caching 
>> on Geeklog.net. If anyone else notices a "1" where it really 
>> shouldn't be let me know.
>> 
>> When I get a chance I will look into the issue.
>> 
>> Thanks
>> 
>> Tom
>> 
>> -----Original Message-----
>> From: geeklog-devel-bounces at lists.geeklog.net
>> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Wim 
>> Niemans
>> Sent: March-13-14 7:42 AM
>> To: Geeklog Development
>> Subject: Re: [geeklog-devel] Geeklog.net 2.1.0 Beta 1 Upgrade
>> 
>> 
>> Filed a bug for this already.
>> See http://project.geeklog.net/tracking/view.php?id=1750
>> 
>> On 13 Mar 2014, at 12:30, Dirk Haun <dirk at haun-online.de> wrote:
>> 
>>> Tom <websitemaster at cogeco.net> wrote:
>>> 
>>>> I have updated Geeklog.net to the still unreleased Geeklog 2.1.0 Beta
1.
>>> 
>>> When you're not logged in, there's a "1" displaying on the front 
>>> page,
>> just below the "About Geeklog" block. I don't think it's coming from 
>> any of the static pages that we display on the front page (About 
>> Geeklog is one, or the international support one, if your browser 
>> defaults to a language other than English).
>>> 
>>> Could this be because we don't currently have a featured story?
>>> 
>>> bye, Dirk
>>> 
>>> 
>>> --
>>> http://www.themobilepresenter.com/
>>> 
>>> _______________________________________________
>>> geeklog-devel mailing list
>>> geeklog-devel at lists.geeklog.net
>>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>>> 
>> 
>> _______________________________________________
>> geeklog-devel mailing list
>> geeklog-devel at lists.geeklog.net
>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>> 
>> _______________________________________________
>> geeklog-devel mailing list
>> geeklog-devel at lists.geeklog.net
>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>> 
> 
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
> 
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
> 

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel