[geeklog-devel] Contributing to a Github repository

[cordiste]

Tom,

As a Geeklog community member do I need to open an issue for a bug or
enhancement in the Github repository or can I just commit my changes?
And if I can commit directly, do I make it in the master branch or I
need to create a new branch?

For exemple:

- Gus plugin I maked a pull request
https://github.com/Geeklog-Plugins/gus/pull/2

- Forum plugin I added some issues
https://github.com/Geeklog-Plugins/forum/issues/created_by/hostellerie

We really need to clarify how everybody contribute :)

Ben

2016-01-20 13:07 GMT+01:00 Tom <websitemaster at cogeco.net>:
> That is a good idea especially since we can't do patches anymore. (at least
> like how we did before).
>
> I was also wanted to add a good practices page or something on our
> wiki/readme explaining the best way to contribute, add issues, and
> committing code. Here are a few help pages I have looked at so far.
>
> General Help
> https://help.github.com/
>
> Glossary
> https://help.github.com/articles/github-glossary/
>
>
> Contributing (Pull Requests)
> https://guides.github.com/activities/contributing-to-open-source/
> https://guides.github.com/activities/forking/
>
> Commits
> https://help.github.com/categories/commits/
>
> Guides
> https://guides.github.com/
>
> https://help.github.com/categories/commits/
>
> Issue Guide
> https://guides.github.com/features/issues/
>
> Markdown Guide
> https://guides.github.com/features/mastering-markdown/
> https://help.github.com/categories/writing-on-github/
>
>
>
> -----Original Message-----
> From: geeklog-devel [mailto:geeklog-devel-bounces at lists.geeklog.net] On
> Behalf Of cordiste
> Sent: Wednesday, January 20, 2016 6:17 AM
> To: Geeklog <geeklog-devel at lists.geeklog.net>
> Subject: [geeklog-devel] Contributing to a Github repository
>
> Now that we are on Github, we must decide what is the best way for people to
> contribute to code.
>
> It seems to be a good practice to add a CONTRIBUTING label in the README.md
> file, so I propose the following steps based on the Github
> documentation:
>
> 1. Fork the repository and clone it locally.
> 2. Create a branch: your branch name should be descriptive, so that others
> can see what is being worked on.
> 3.Add commits to your branch: add, edit, or delete one or more files and
> make tests 4.Open a Pull Request: by using GitHub's @mention system in your
> Pull Request message, you can ask for feedback from specific people or teams
> 5.Before merging we discuss and review your code. The person or team
> reviewing your changes may have questions or comments.
>
> Thank you to modify and / or supplement this.
>
> Ben
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> https://pairlist8.pair.net/mailman/listinfo/geeklog-devel
>