[geeklog-devtalk] geeklog-devel digest, Vol 1 #274 - 4 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. The first 1.3.9rc1 bugs are in ... (Dirk Haun)
   2. Re: The first 1.3.9rc1 bugs are in ... (Vincent Furia)
   3. Re: The first 1.3.9rc1 bugs are in ... (Dirk Haun)
   4. Re: The first 1.3.9rc1 bugs are in ... (Vincent Furia)

--__--__--

Message: 1
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Date: Tue, 17 Feb 2004 23:55:31 +0100
Organization: Terra Software Systems
Subject: [geeklog-devel] The first 1.3.9rc1 bugs are in ...
Reply-To: geeklog-devel at lists.geeklog.net

1. PATH_SEPARATOR is only defined as of PHP 4.3.0 - any older versions
will have the actual text "PATH_SEPARATOR" in the path ...

Affects the ini_set call for the path to PEAR in lib-common.php. Needs a
workaround, something like

    if( defined( PATH_SEPARATOR )) {
        // use it
    } else {
        // try to guess it
    }


2. function COM_getComment() needs a

    $template->set_var( 'order', $order );


3. (reported by Turias over on the contact-us list):

>You probably already know this, but it appears as though threaded

>comments are broken.  Clicking on a non-root level comment brings up a

>blank screen.


Actually, I think it only happens with the very last comment in each thread.

Vinny, is this (#3) something you could be looking into?

bye, Dirk


-- 
http://www.haun-online.de/
http://www.tinyweb.de/


--__--__--

Message: 2
Date: Tue, 17 Feb 2004 20:22:38 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] The first 1.3.9rc1 bugs are in ...
Reply-To: geeklog-devel at lists.geeklog.net

Dirk Haun wrote:


>3. (reported by Turias over on the contact-us list):

>  

>

>>You probably already know this, but it appears as though threaded

>>comments are broken.  Clicking on a non-root level comment brings up a

>>blank screen.

>>    

>>

>

>Actually, I think it only happens with the very last comment in each thread.

>

>Vinny, is this (#3) something you could be looking into?

>

>bye, Dirk

>

>

>  

>

Ooops.  Looks like a small mistake got thrown in.  Change is in 
lib-common.php around line 2678:
This line:
   $template->set_var( 'pid', $A['cid'] );
Should be:
   $template->set_var( 'pid', $A['pid'] );

-Vinny

--__--__--

Message: 3
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] The first 1.3.9rc1 bugs are in ...
Date: Wed, 18 Feb 2004 08:10:41 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vinny,


>Ooops.  Looks like a small mistake got thrown in.  Change is in 

>lib-common.php around line 2678:

>This line:

>   $template->set_var( 'pid', $A['cid'] );

>Should be:

>   $template->set_var( 'pid', $A['pid'] );


Applied on geeklog.net, looking good. Thanks.

bye, Dirk


-- 
http://www.haun-online.de/
http://www.haun.info/


--__--__--

Message: 4
Date: Wed, 18 Feb 2004 10:21:50 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] The first 1.3.9rc1 bugs are in ...
Reply-To: geeklog-devel at lists.geeklog.net

OKay,

Found a slightly deeper problem that is all tied up in this.  With the 
below change the reply-to-link is now broken (it responds to the 
comment/story an extra level up).

The easy way to change this is to add a line:
$template->set_var( 'cid', $A['cid'] );

to the comment function and then change the themes (comment.thtml) so 
that the reply-to-link has "pid={cid}".

The better fix is to add a reply_to_link theme variable (along with 
theme variables for the other links that the comments have) and 
eliminate the 'extra' theme variables.

If you give me some guidance on how you want to handle this I can code 
up the changes.  Write cvs access would be convenient at this point. ;)

Another minor issue is that the "parent" link is missing when browsing 
non-top-level comments in threaded mode.  This should be easy to add.

-Vinny

Dirk Haun wrote:

> Vinny,

> 

> 

>>Ooops.  Looks like a small mistake got thrown in.  Change is in 

>>lib-common.php around line 2678:

>>This line:

>>  $template->set_var( 'pid', $A['cid'] );

>>Should be:

>>  $template->set_var( 'pid', $A['pid'] );

> 

> 

> Applied on geeklog.net, looking good. Thanks.

> 

> bye, Dirk

> 

> 



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest