[geeklog-devtalk] geeklog-devel digest, Vol 1 #277 - 8 msgs

geeklog-devel-request at lists.geeklog.net geeklog-devel-request at lists.geeklog.net
Sat Feb 21 13:00:10 EST 2004

Previous message: [geeklog-devtalk] geeklog-devel digest, Vol 1 #276 - 2 msgs
Next message: [geeklog-devtalk] Smtp mail in Forums
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Send geeklog-devel mailing list submissions to
geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."

Today's Topics:

1. Re: Spam to members of lists (Dirk Haun)
2. COM_extractlinks (Vincent Furia)
3. comment.php (Vincent Furia)
4. Re: comment.php (Blaine Lang)
5. Re: comment.php (Vincent Furia)
6. Re: comment.php (Blaine Lang)
7. Re: comment.php (Dirk Haun)
8. Re: comment.php (Blaine Lang)

--__--__--

Message: 1
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Spam to members of lists
Date: Fri, 20 Feb 2004 19:45:53 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vinny wrote:

>Note that the SPAMers could have gotten his email by scouring the

>archive. Some people do a reply-to that includes something like:

>

> joe at some.email.com said:

I found the two posts by Drago. Tony responded to both of them, but
without quoting his email address. There were no other replies. A search
for Drago's email address (in my local mail database) only returns his
own posts. So that's not the way the address got out.

Of course, everyone else on the list has his email address on their PC as
well and if they caught a virus, for example, it's possible that the
address got out that way (e.g. used as a fake return address).

>Maybe there is a way to

>filter email addresses out of the body of messages before they posted to

>the archive?

That would still be a good idea.

bye, Dirk

--
http://www.haun-online.de/
http://geeklog.info/

--__--__--

Message: 2
Date: Fri, 20 Feb 2004 20:29:18 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: [geeklog-devel] COM_extractlinks
Reply-To: geeklog-devel at lists.geeklog.net

I noticed this post in the Forum:

http://www.geeklog.net/forum/viewtopic.php?forum=10&showtopic=30857

You probably don't want to go with (quite) what the suggestion there is
(due to problems the author states). But the function getting confused
by the image tags is Not A Good Thing. (-rc2 perhaps?)

I'll fix this if no one else wants to. I'll just need to brush up on my
regexs a bit first.

-Vinny

--__--__--

Message: 3
Date: Fri, 20 Feb 2004 21:59:10 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: [geeklog-devel] comment.php
Reply-To: geeklog-devel at lists.geeklog.net

In 1.3.8, when displaying comments using comment.php (?mode=display) GL
would assume threaded mode. This made sense since the other comment
modes (nested, flat) can display all the comments on a single page
without needing a click through to see more comments.

In 1.3.9's comment.php we are setting the comment mode (threaded,
nested, etc) to the user's choice or the default value. Unfortunately
if a user has his prefs set to 'nested' but then uses the title bar to
select 'threaded' and then clicks on a threaded comment it causes the
comment to display as his preferenced value.

So I guess I'm asking is what is the desired behavior here? Should
comment.php only be used to display threaded comments (notice the code
to display in comment.php takes a 'pid' rather than a 'cid' to display
all the children of a parent - but not the parent, rather than a
particular comment and its children). Or should it use whatever the
user's preferences indicate (overriding a previous commentbar choice).
Or should it 1st go by choice, then preference? Or something else...

After that question is answered here is an related enhancement for
comment.php that we may consider looking at: we can add a bit of logic
to display a comment based on 'cid' (along with its children) in
addition to the current display by parent ('pid'). This would allow
users to link to a particular comment in a story/poll/plugin/etc.

Have enough time to think about all that? Once you have my opinion
(vote?) is below.

/////////////////////

My opinion: I think the comment.php display as it is ('pid') should
only be available in threaded comments. It doesn't make much sense to
have it for nested or flat comments. I like the idea of being able to
link to a particular comment, so I'd vote yes for that feature
(available in any comment mode).

I'll code it all up once the votes are in. Also if you vote yes the
display by 'cid' should it be in 1.3.9 or should it wait for 1.3.10.

-Vinny

--__--__--

Message: 4
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] comment.php
Date: Fri, 20 Feb 2004 23:44:49 -0500
Reply-To: geeklog-devel at lists.geeklog.net

What I see is that nested looks like flat mode now.
I've tried setting my preference to nested and threaded and really did not
see a difference when viewing comments in nested mode. They always appeared
as flat. Nested used to have the threaded look but would expand out all the
comments.

Example story with 50 comments:
http://www.geeklog.net/article.php?story=20021208122743130

Blaine
----- Original Message -----
From: "Vincent Furia" <vmf at abtech.org>
To: <geeklog-devel at lists.geeklog.net>
Sent: Friday, February 20, 2004 9:59 PM
Subject: [geeklog-devel] comment.php

> In 1.3.8, when displaying comments using comment.php (?mode=display) GL

> would assume threaded mode. This made sense since the other comment

> modes (nested, flat) can display all the comments on a single page

> without needing a click through to see more comments.

>

> In 1.3.9's comment.php we are setting the comment mode (threaded,

> nested, etc) to the user's choice or the default value. Unfortunately

> if a user has his prefs set to 'nested' but then uses the title bar to

> select 'threaded' and then clicks on a threaded comment it causes the

> comment to display as his preferenced value.

>

> So I guess I'm asking is what is the desired behavior here? Should

> comment.php only be used to display threaded comments (notice the code

> to display in comment.php takes a 'pid' rather than a 'cid' to display

> all the children of a parent - but not the parent, rather than a

> particular comment and its children). Or should it use whatever the

> user's preferences indicate (overriding a previous commentbar choice).

> Or should it 1st go by choice, then preference? Or something else...

>

> After that question is answered here is an related enhancement for

> comment.php that we may consider looking at: we can add a bit of logic

> to display a comment based on 'cid' (along with its children) in

> addition to the current display by parent ('pid'). This would allow

> users to link to a particular comment in a story/poll/plugin/etc.

>

> Have enough time to think about all that? Once you have my opinion

> (vote?) is below.

>

> /////////////////////

>

> My opinion: I think the comment.php display as it is ('pid') should

> only be available in threaded comments. It doesn't make much sense to

> have it for nested or flat comments. I like the idea of being able to

> link to a particular comment, so I'd vote yes for that feature

> (available in any comment mode).

>

> I'll code it all up once the votes are in. Also if you vote yes the

> display by 'cid' should it be in 1.3.9 or should it wait for 1.3.10.

>

> -Vinny

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

--__--__--

Message: 5
Date: Sat, 21 Feb 2004 08:17:52 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] comment.php
Reply-To: geeklog-devel at lists.geeklog.net

There was a bug in -rc1 that was contributing to that. I don't see a
problem with the article you pointed to (I'm seeing it nested just
fine). What browser/OS (brand and version) are you using?

Are you seeing threaded sub-comments indented in? If possible a
screenshot or two of what you're seeing would be helpful in trouble
shooting.

Thanks,
Vinny

Blaine Lang wrote:

> What I see is that nested looks like flat mode now.

> I've tried setting my preference to nested and threaded and really did not

> see a difference when viewing comments in nested mode. They always appeared

> as flat. Nested used to have the threaded look but would expand out all the

> comments.

>

> Example story with 50 comments:

> http://www.geeklog.net/article.php?story=20021208122743130

>

> Blaine

> ----- Original Message -----

> From: "Vincent Furia" <vmf at abtech.org>

> To: <geeklog-devel at lists.geeklog.net>

> Sent: Friday, February 20, 2004 9:59 PM

> Subject: [geeklog-devel] comment.php

>

>

>

>>In 1.3.8, when displaying comments using comment.php (?mode=display) GL

>>would assume threaded mode. This made sense since the other comment

>>modes (nested, flat) can display all the comments on a single page

>>without needing a click through to see more comments.

>>

>>In 1.3.9's comment.php we are setting the comment mode (threaded,

>>nested, etc) to the user's choice or the default value. Unfortunately

>>if a user has his prefs set to 'nested' but then uses the title bar to

>>select 'threaded' and then clicks on a threaded comment it causes the

>>comment to display as his preferenced value.

>>

>>So I guess I'm asking is what is the desired behavior here? Should

>>comment.php only be used to display threaded comments (notice the code

>>to display in comment.php takes a 'pid' rather than a 'cid' to display

>>all the children of a parent - but not the parent, rather than a

>>particular comment and its children). Or should it use whatever the

>>user's preferences indicate (overriding a previous commentbar choice).

>>Or should it 1st go by choice, then preference? Or something else...

>>

>>After that question is answered here is an related enhancement for

>>comment.php that we may consider looking at: we can add a bit of logic

>>to display a comment based on 'cid' (along with its children) in

>>addition to the current display by parent ('pid'). This would allow

>>users to link to a particular comment in a story/poll/plugin/etc.

>>

>>Have enough time to think about all that? Once you have my opinion

>>(vote?) is below.

>>

>>/////////////////////

>>

>>My opinion: I think the comment.php display as it is ('pid') should

>>only be available in threaded comments. It doesn't make much sense to

>>have it for nested or flat comments. I like the idea of being able to

>>link to a particular comment, so I'd vote yes for that feature

>>(available in any comment mode).

>>

>>I'll code it all up once the votes are in. Also if you vote yes the

>>display by 'cid' should it be in 1.3.9 or should it wait for 1.3.10.

>>

>>-Vinny

>>_______________________________________________

>>geeklog-devel mailing list

>>geeklog-devel at lists.geeklog.net

>>http://lists.geeklog.net/listinfo/geeklog-devel

>

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>

--__--__--

Message: 6
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] comment.php
Date: Sat, 21 Feb 2004 11:24:09 -0500
Reply-To: geeklog-devel at lists.geeklog.net

Vinny,

I am using IE 6 and have uploaded two images for you to see.

http://www.langfamily.ca/temp/threaded.jpg
http://www.langfamily.ca/temp/nested.jpg

Blaine
----- Original Message -----
From: "Vincent Furia" <vmf at abtech.org>
To: <geeklog-devel at lists.geeklog.net>
Sent: Saturday, February 21, 2004 8:17 AM
Subject: Re: [geeklog-devel] comment.php

> There was a bug in -rc1 that was contributing to that. I don't see a

> problem with the article you pointed to (I'm seeing it nested just

> fine). What browser/OS (brand and version) are you using?

>

> Are you seeing threaded sub-comments indented in? If possible a

> screenshot or two of what you're seeing would be helpful in trouble

> shooting.

>

> Thanks,

> Vinny

>

> Blaine Lang wrote:

> > What I see is that nested looks like flat mode now.

> > I've tried setting my preference to nested and threaded and really did

not

> > see a difference when viewing comments in nested mode. They always

appeared

> > as flat. Nested used to have the threaded look but would expand out all

the

> > comments.

> >

> > Example story with 50 comments:

> > http://www.geeklog.net/article.php?story=20021208122743130

> >

> > Blaine

> > ----- Original Message -----

> > From: "Vincent Furia" <vmf at abtech.org>

> > To: <geeklog-devel at lists.geeklog.net>

> > Sent: Friday, February 20, 2004 9:59 PM

> > Subject: [geeklog-devel] comment.php

> >

> >

> >

> >>In 1.3.8, when displaying comments using comment.php (?mode=display) GL

> >>would assume threaded mode. This made sense since the other comment

> >>modes (nested, flat) can display all the comments on a single page

> >>without needing a click through to see more comments.

> >>

> >>In 1.3.9's comment.php we are setting the comment mode (threaded,

> >>nested, etc) to the user's choice or the default value. Unfortunately

> >>if a user has his prefs set to 'nested' but then uses the title bar to

> >>select 'threaded' and then clicks on a threaded comment it causes the

> >>comment to display as his preferenced value.

> >>

> >>So I guess I'm asking is what is the desired behavior here? Should

> >>comment.php only be used to display threaded comments (notice the code

> >>to display in comment.php takes a 'pid' rather than a 'cid' to display

> >>all the children of a parent - but not the parent, rather than a

> >>particular comment and its children). Or should it use whatever the

> >>user's preferences indicate (overriding a previous commentbar choice).

> >>Or should it 1st go by choice, then preference? Or something else...

> >>

> >>After that question is answered here is an related enhancement for

> >>comment.php that we may consider looking at: we can add a bit of logic

> >>to display a comment based on 'cid' (along with its children) in

> >>addition to the current display by parent ('pid'). This would allow

> >>users to link to a particular comment in a story/poll/plugin/etc.

> >>

> >>Have enough time to think about all that? Once you have my opinion

> >>(vote?) is below.

> >>

> >>/////////////////////

> >>

> >>My opinion: I think the comment.php display as it is ('pid') should

> >>only be available in threaded comments. It doesn't make much sense to

> >>have it for nested or flat comments. I like the idea of being able to

> >>link to a particular comment, so I'd vote yes for that feature

> >>(available in any comment mode).

> >>

> >>I'll code it all up once the votes are in. Also if you vote yes the

> >>display by 'cid' should it be in 1.3.9 or should it wait for 1.3.10.

> >>

> >>-Vinny

> >>_______________________________________________

> >>geeklog-devel mailing list

> >>geeklog-devel at lists.geeklog.net

> >>http://lists.geeklog.net/listinfo/geeklog-devel

> >

> >

> > _______________________________________________

> > geeklog-devel mailing list

> > geeklog-devel at lists.geeklog.net

> > http://lists.geeklog.net/listinfo/geeklog-devel

> >

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

--__--__--

Message: 7
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] comment.php
Date: Sat, 21 Feb 2004 17:45:54 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Blaine,

>http://www.langfamily.ca/temp/threaded.jpg

That's how it should look like (at least I think so ...).

>http://www.langfamily.ca/temp/nested.jpg

That's not okay, though. But it looks fine (i.e. nested) in Mozilla.
Blame Microsoft ...

bye, Dirk

P.S. geeklog.net is running on the latest CVS version of lib-common.php
(1.289), not the one from the rc1 tarball.

--
http://www.haun-online.de/
http://geeklog.info/

--__--__--

Message: 8
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] comment.php
Date: Sat, 21 Feb 2004 12:13:28 -0500
Reply-To: geeklog-devel at lists.geeklog.net

> >http://www.langfamily.ca/temp/threaded.jpg

>

> That's how it should look like (at least I think so ...).

Agree that what I had noted in my previous email , it's nested that is not
showing correct

I had not tried Mozilla but yeh, it does appear to be IE related.

The issue is with the CSS for padding being defined at the TABLE level and
not the TD level
style="padding-left: 50px"Have a look at this
testhttp://www.langfamily.ca/temp/tablestyletest.htmlBlaine
----- Original Message -----
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Sent: Saturday, February 21, 2004 11:45 AM
Subject: Re: [geeklog-devel] comment.php

> Blaine,

>

> >http://www.langfamily.ca/temp/threaded.jpg

>

> That's how it should look like (at least I think so ...).

>

>

> >http://www.langfamily.ca/temp/nested.jpg

>

> That's not okay, though. But it looks fine (i.e. nested) in Mozilla.

> Blame Microsoft ...

>

> bye, Dirk

>

> P.S. geeklog.net is running on the latest CVS version of lib-common.php

> (1.289), not the one from the rc1 tarball.

>

>

> --

> http://www.haun-online.de/

> http://geeklog.info/

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel

End of geeklog-devel Digest

Previous message: [geeklog-devtalk] geeklog-devel digest, Vol 1 #276 - 2 msgs
Next message: [geeklog-devtalk] Smtp mail in Forums
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the geeklog-devtalk mailing list