[geeklog-devtalk] Re: geeklog-devtalk digest, Vol 1 #258 - 3 msgs

[Wim Niemans ri]

On 28 Feb 2004 at 12:00, geeklog-devtalk-request at lists.geeklog.net wrote:


> On Moderation: I added moderatation to the forum plugin for a client. It =

> allowed the admin to setup moderation (per forum) on just new topics or =

> full moderation of all posts. I hope to release when I get some more =

> time to finish of the 2.3 release. I didn't have any problems and may =

> not fully understand your suggestions without getting my head back in =

> the code again.

> 


Blaine,

The suggestions are merely suggested extensions/corrections to 
admin/moderation.php.
First, the core doesn't check the validity of the table-names, 
subject to moderation. It just copies (dbCopy) the given fields of  
$submissiontable into $table. Than it blindly deletes the entry in 
$submissiontable.
If the tablenames are invalid, or the same, or empty this generates a 
sql error. To my opinion, GL core is (must be) able to check the 
table-names.
Second, if done that checking, this opens a whole lot of new 
functionality to moderation !!

Cheers,
wim niemans