[geeklog-devtalk] geeklog-devel digest, Vol 1 #253 - 3 msgs

geeklog-devel-request at lists.geeklog.net geeklog-devel-request at lists.geeklog.net
Thu Jan 15 13:00:11 EST 2004

Send geeklog-devel mailing list submissions to
geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

1. Theme'd Comments: Theme Fix (Vincent Furia)
2. Re: PHP in Static Pages (Dirk Haun)
3. Search Engine Friendly URLs for Stories (Vincent Furia)

--__--__--

Message: 1
Date: Wed, 14 Jan 2004 12:59:05 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: [geeklog-devel] Theme'd Comments: Theme Fix
Reply-To: geeklog-devel at lists.geeklog.net

Dirk,

Just was looking into CVS (and playing around with upcoming 1.3.9
features) and noticed that at least in the clean theme my comment
theming is broken. You need to make the following changes to the clean
theme:

clean/comment/thread.thtml
clean/comment/comment.thtml

replace "margin-left" with "padding-left"
change "{indent}" to "{indent}px"

It looks like this problem exists in the other themes as well, though I
didn't investigate very closely.

-Vinny


--__--__--

Message: 2
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] PHP in Static Pages
Date: Wed, 14 Jan 2004 19:16:39 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

I wrote:


>An option to switch off PHP from the config file would be a start.


Done (see CVS). If you set $_SP_CONF['allow_php'] = 0; in the static
pages' config.php file, PHP in static pages will not be executed any more.

I've also removed the 'staticpages.PHP' permission from the Static Page
Admin group for fresh installs. You will have to enable it first.

I wonder if I should go ahead and change the install script to remove
that permission when upgrading to 1.3.9. On the one hand, it may p*ss off
a few of our users, but on the other hands, there are probably a lot of
users who will never use PHP in a static page anyway, and so there's no
real use leaving it activated ...

bye, Dirk


--
http://www.haun-online.de/
http://www.tinyweb.de/


--__--__--

Message: 3
Date: Wed, 14 Jan 2004 15:46:48 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: [geeklog-devel] Search Engine Friendly URLs for Stories
Reply-To: geeklog-devel at lists.geeklog.net

This is a multi-part message in MIME format.
--------------060606010409080602050709
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit

I wrote this against the current CVS version of geeklog-1.3. I've
tested it pretty well on linux. I doubt it will work under Windows with
IIS since it uses the same methodology as Staticpages. Like
staticpages, it is keyed on the $_CONF['url_rewrite'] variable.

Let me know if there are any questions.

I'd also like to add the recommendation that the
"start_readmore_anchortag" and "end_readmore_anchortag" be available to
the template regardless of whether there is more text to read. The
"readmore_link" should still only be available if there is a story
body. In any case, it should be possible for there to be a link to go
directly to the article page, even for articles that have no comments
and no body (so the article page can still be crawled by search engines).

-Vinny


Index: lib-common.php
===================================================================
RCS file: /usr/cvs/geeklog/geeklog-1.3/public_html/lib-common.php,v
retrieving revision 1.274
diff -u -r1.274 lib-common.php
--- lib-common.php 13 Jan 2004 20:00:40 -0000 1.274
+++ lib-common.php 14 Jan 2004 20:32:52 -0000
@@ -487,11 +487,11 @@
$numwords = sizeof( explode( ' ', $A['bodytext'] ));
$article->set_var( 'readmore_words', $numwords );

- $article->set_var( 'readmore_link', '<a href="' .
$_CONF['site_url'
]
- . '/article.php?story=' . $A['sid'] . '">' . $LANG01[2]
+ $article->set_var( 'readmore_link', '<a href="' .
COM_buildURL($_CO
NF['site_url']
+ . '/article.php?story=' . $A['sid']) . '">' .
$LANG01[2]
. '</a> (' . $numwords . ' ' . $LANG01[62] . ') ' );
$article->set_var( 'start_readmore_anchortag', '<a href="'
- . $_CONF['site_url'] . '/article.php?story=' .
$A['sid']
+ . COM_buildURL($_CONF['site_url'] .
'/article.php?story=' .
$A['sid'])
. '">' );
$article->set_var( 'end_readmore_anchortag', '</a>' );
}
Index: article.php
===================================================================
RCS file: /usr/cvs/geeklog/geeklog-1.3/public_html/article.php,v
retrieving revision 1.39
diff -u -r1.39 article.php
--- article.php 12 Dec 2003 21:58:10 -0000 1.39
+++ article.php 14 Jan 2004 20:32:52 -0000
@@ -54,11 +54,11 @@

// MAIN

+COM_setArgNames (array ('story'));
+$story = COM_applyFilter ( COM_getArgument ('story') );
if (isset ($HTTP_POST_VARS['story'])) {
$story = COM_applyFilter($HTTP_POST_VARS['story']);
-} else {
- $story = COM_applyFilter($HTTP_GET_VARS['story']);
-}
+}
if (empty ($story)) {
echo COM_refresh ($_CONF['site_url'] . '/index.php');
exit();


--------------060606010409080602050709
Content-Type: text/plain;
name="rewrite.diff"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="rewrite.diff"

Index: lib-common.php
===================================================================
RCS file: /usr/cvs/geeklog/geeklog-1.3/public_html/lib-common.php,v
retrieving revision 1.274
diff -u -r1.274 lib-common.php
--- lib-common.php 13 Jan 2004 20:00:40 -0000 1.274
+++ lib-common.php 14 Jan 2004 20:32:52 -0000
@@ -487,11 +487,11 @@
$numwords = sizeof( explode( ' ', $A['bodytext'] ));
$article->set_var( 'readmore_words', $numwords );

- $article->set_var( 'readmore_link', '<a href="' . $_CONF['site_url']
- . '/article.php?story=' . $A['sid'] . '">' . $LANG01[2]
+ $article->set_var( 'readmore_link', '<a href="' . COM_buildURL($_CONF['site_url']
+ . '/article.php?story=' . $A['sid']) . '">' . $LANG01[2]
. '</a> (' . $numwords . ' ' . $LANG01[62] . ') ' );
$article->set_var( 'start_readmore_anchortag', '<a href="'
- . $_CONF['site_url'] . '/article.php?story=' . $A['sid']
+ . COM_buildURL($_CONF['site_url'] . '/article.php?story=' . $A['sid'])
. '">' );
$article->set_var( 'end_readmore_anchortag', '</a>' );
}
Index: article.php
===================================================================
RCS file: /usr/cvs/geeklog/geeklog-1.3/public_html/article.php,v
retrieving revision 1.39
diff -u -r1.39 article.php
--- article.php 12 Dec 2003 21:58:10 -0000 1.39
+++ article.php 14 Jan 2004 20:32:52 -0000
@@ -54,11 +54,11 @@

// MAIN

+COM_setArgNames (array ('story'));
+$story = COM_applyFilter ( COM_getArgument ('story') );
if (isset ($HTTP_POST_VARS['story'])) {
$story = COM_applyFilter($HTTP_POST_VARS['story']);
-} else {
- $story = COM_applyFilter($HTTP_GET_VARS['story']);
-}
+}
if (empty ($story)) {
echo COM_refresh ($_CONF['site_url'] . '/index.php');
exit();

--------------060606010409080602050709--



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest

More information about the geeklog-devtalk mailing list