[geeklog-devtalk] geeklog-devel digest, Vol 1 #299 - 6 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. Credits to ourselves? (Dirk Haun)
   2. Re: Credits to ourselves? (Simon Lord)
   3. Re: Comment Speed Improvement (Blaine Lang)
   4. Re: Credits to ourselves? (Blaine Lang)
   5. Re: Credits to ourselves? (Dirk Haun)
   6. Re: Credits to ourselves? (Vincent Furia)

--__--__--

Message: 1
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Date: Mon, 29 Mar 2004 21:20:07 +0100
Organization: Terra Software Systems
Subject: [geeklog-devel] Credits to ourselves?
Reply-To: geeklog-devel at lists.geeklog.net

With the addition of Vinny, there are now four people with CVS access
contributing code on a (more or less) regular basis. Which brings up the
issue of proper credits.

I've always tried to properly credit code, fixes, and other things
contributed by people outside of the core team. But what about the four
of us now? Should we start putting our names after each change
description? The PHP team does it like this, for example:

    Fixed getopt() so it works without $_SERVER (Rasmus, bfrance)

Personally, I don't care. I can always get the information I need (who
made a change a when) from CVS. But I don't want to downplay anybody's
role in this project or pocket someone's credits.

So, do we add our names to docs/history or do we stick with the rule that
changes without credits were made by an (unnamed) team member?

bye, Dirk


-- 
http://www.haun-online.de/
http://mypod.de/


--__--__--

Message: 2
From: Simon Lord <slord at marelina.com>
Subject: Re: [geeklog-devel] Credits to ourselves?
Date: Mon, 29 Mar 2004 23:15:30 -0500
To: geeklog-devel at lists.geeklog.net
Reply-To: geeklog-devel at lists.geeklog.net

I'm not even contributing to CVS other than the glpro theme, but it 
seems to me that you guys need to stick your names in there.  If 
nothing else, it's a great resume piece down the road.

GL is not some hack cms, you guys have some crazy classes in there etc 
that may prove you're the right man for the job at your next interview. 
  But if your names are not in CVS you'll have a hell of a time 
convincing them you wrote a file uploader class etc.  I'm sure if I was 
a contributor to SAMBA I'd want my name in there.

Cripes, here's a great free CMS system.  The least *all* of us can do 
is allow the major contributors to stamp their names in there 
somewhere.  Module developers can stick their names into their modules 
and theme developers can stick theirs into the css file... ;)

My two cents.


On Mar 29, 2004, at 3:20 PM, Dirk Haun wrote:


> With the addition of Vinny, there are now four people with CVS access

> contributing code on a (more or less) regular basis. Which brings up 

> the

> issue of proper credits.

>

> I've always tried to properly credit code, fixes, and other things

> contributed by people outside of the core team. But what about the four

> of us now? Should we start putting our names after each change

> description? The PHP team does it like this, for example:

>

>     Fixed getopt() so it works without $_SERVER (Rasmus, bfrance)

>

> Personally, I don't care. I can always get the information I need (who

> made a change a when) from CVS. But I don't want to downplay anybody's

> role in this project or pocket someone's credits.

>

> So, do we add our names to docs/history or do we stick with the rule 

> that

> changes without credits were made by an (unnamed) team member?

>

> bye, Dirk

>

>

> -- 

> http://www.haun-online.de/

> http://mypod.de/

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>

>

Sincerely,
Simon


--__--__--

Message: 3
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Comment Speed Improvement
Date: Tue, 30 Mar 2004 09:55:31 -0500
Reply-To: geeklog-devel at lists.geeklog.net

I had not seen the "modified preorder tree traversal method" explained
before but the article on Sitepoint and the one pointed by Dwight explained
it pretty well. This would also work nicely for the forums as I currently
use a parent/child tree model.

I think it would be a good idea to try this structure and test it on a few
large databases.

Blaine

----- Original Message ----- 
From: "Vincent Furia" <vmf at abtech.org>
To: <geeklog-devel at lists.geeklog.net>
Sent: Saturday, March 27, 2004 2:54 PM
Subject: [geeklog-devel] Comment Speed Improvement



> I've been thinking hard about improving the speed of displaying comments

> by reducing the number of queries and potentially removing the need to

> use recursive functions.

>

> While Niels solution provides a quick fix for groklaw's specific

> problems, it is pretty inefficient when you are looking at a subset of

> comments for a story.  A more elegant solution must be possilbe..

>

> I think I've found that solution, but it will take some work (including

> a database change) to implement.  While I'm fully capable of

> implementing it, I wanted to get some feed-back before jumping in.

>

> The idea is to store the comments in the database using a modified

> preorder tree traversal method.  A brief description (along with a

> comparison to our current method) can be found in this article:

>

> http://www.sitepoint.com/article/hierarchical-data-database

>

> A better description is this site:

>

> http://membres.lycos.fr/sqlpro/Tree/SQL_tree.htm

>

> However it is in French (which I don't speak).  But babelfish

> (http://babel.altavista.com) works pretty well on the first half of the

> page.  Plus it has many useful graphics.

>

> The idea is a little confusing at first, but once you wrap your head

> around it you'll think:  "Wow, hey, that's pretty darn cool".  Or maybe

> you'll think: "Mein Gott, das ist wirklich kühl.". ;)

>

> The summary:

>

> - 1 query and 2 updates to insert a new comment

> - 1 query to get all the comments (in a logical order for display)

> - 1 query to get all the children of a given comment (with or without

> the given comment)

> - 1 query to count the number of children a comment has

>

> Basically this will drastically improve the speed of comment displays of

> all types, especially for sites that have very large databases of

> comments (groklaw).  The only expense is adding two extra db queries

> when a comment gets added (including one that could potentially update

> almost every database row).

>

> The only change to the database will be the addition of two integer

> columns: left terminal (lft) and right terminal (rgt).  Optionally we

> could also remove the parent id (pid) column as it would no longer be

> technically necessary.  That being said, I think we should preserve it

> for convenience.

>

> I think the improvement will be worth it, though we'll have to write a

> slick upgrade script to take care of current comments.  A side effect of

> using this method is that we will be able to write a comment function

> that is iterative rather than recursive which will further improve

> performance.

>

> Another note is that this method is database independent.  There are

> some other pretty nice solutions that require stored procedures and I

> think Oracle has something built in.  Obviously those other solutions

> are really going to work well with MySQL.

>

> If the article above doesn't make sense, let me know and I can write a

> brief summary of what is going on in "preorder tree traversal" method.

>

> Please everyone, let me know what you think.  I'd especially like some

> input from a DB guy to make sure I'm not missing something obvious

> (Dwight, you still out there?).

>

> -Vinny

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>



--__--__--

Message: 4
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Credits to ourselves?
Date: Tue, 30 Mar 2004 10:03:01 -0500
Reply-To: geeklog-devel at lists.geeklog.net

Dirk, are you thinking there would be a 1 line comment added to the changed
file header documenting the change and author?

I agree that a comment standard with the develper name is a good idea.
The question is do we want to really add this to the header of each file - I
suspect no.
My changes are mostly noted in the history doc and I have not had a problem
with the current method.

Blaine
----- Original Message ----- 
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Sent: Monday, March 29, 2004 3:20 PM
Subject: [geeklog-devel] Credits to ourselves?



> With the addition of Vinny, there are now four people with CVS access

> contributing code on a (more or less) regular basis. Which brings up the

> issue of proper credits.

>

> I've always tried to properly credit code, fixes, and other things

> contributed by people outside of the core team. But what about the four

> of us now? Should we start putting our names after each change

> description? The PHP team does it like this, for example:

>

>     Fixed getopt() so it works without $_SERVER (Rasmus, bfrance)

>

> Personally, I don't care. I can always get the information I need (who

> made a change a when) from CVS. But I don't want to downplay anybody's

> role in this project or pocket someone's credits.

>

> So, do we add our names to docs/history or do we stick with the rule that

> changes without credits were made by an (unnamed) team member?

>

> bye, Dirk

>

>

> -- 

> http://www.haun-online.de/

> http://mypod.de/

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel



--__--__--

Message: 5
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Credits to ourselves?
Date: Tue, 30 Mar 2004 19:16:31 +0200
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Blaine,


>Dirk, are you thinking there would be a 1 line comment added to the changed

>file header documenting the change and author?


No, of course not [1]. I was talking about the history file, where we
currently have entries like

- Make sure the user's preferred comment limit is used when changing the
  comment display via the comment bar (bug #176).
- The static pages editor doesn't display a "delete" button for new and
  cloned pages any more (since, obviously, you can't delete what hasn't been
  saved yet ...).

from which you can't tell who did them.

bye, Dirk

[1] At work, there is this annoying habit of using the CVS $Log$ tag in
the header of each source file, which means that you have to scroll
through - literally - hundreds of lines of old log entries (most of which
read "empty log message" anyway ...) before you can see the actual source
code. I've silently started to use $Id$ for new files ...


-- 
http://www.haun-online.de/
http://geeklog.info/


--__--__--

Message: 6
Date: Tue, 30 Mar 2004 12:33:06 -0500
From: Vincent Furia <vmf at abtech.org>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Credits to ourselves?
Reply-To: geeklog-devel at lists.geeklog.net

Sounds fine to me.  That way everyone can see what slackers the rest of 
us are compared to Dirk. ;)

A quick related question for Dirk:  I noticed that most of the changes 
to the "history" file are by you, do you want contributers to update the 
file as they fix things, or do you prefer to add to it yourself?

-Vinny

Dirk Haun wrote:


>With the addition of Vinny, there are now four people with CVS access

>contributing code on a (more or less) regular basis. Which brings up the

>issue of proper credits.

>

>I've always tried to properly credit code, fixes, and other things

>contributed by people outside of the core team. But what about the four

>of us now? Should we start putting our names after each change

>description? The PHP team does it like this, for example:

>

>    Fixed getopt() so it works without $_SERVER (Rasmus, bfrance)

>

>Personally, I don't care. I can always get the information I need (who

>made a change a when) from CVS. But I don't want to downplay anybody's

>role in this project or pocket someone's credits.

>

>So, do we add our names to docs/history or do we stick with the rule that

>changes without credits were made by an (unnamed) team member?

>

>bye, Dirk

>

>

>  

>




--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest