[geeklog-devtalk] geeklog-devel digest, Vol 1 #405 - 15 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. Re: [Fwd: further span in comments & problem with
       security listserv signup] (Dirk Haun)
   2. Re: [Fwd: further span in comments & problem with
       security listserv signup] (Dirk Haun)
   3. Re: [Fwd: further span in comments & problem with
       security listserv signup] (Dirk Haun)
   4. PDF support, was [Fwd: further span in comments & problem with security
       listserv signup] (Tony Bibbs)
   5. Re: PDF support, was [Fwd: further span in comments & problem with security listserv signup] (Vincent Furia)
   6. A lib-common mod to highlight newest comments (Rob Griffiths)
   7. Re: A lib-common mod to highlight newest comments (Vincent Furia)
   8. Re: A lib-common mod to highlight newest comments (Rob Griffiths)
   9. users table (Blaine Lang)
  10. Re: users table (Tony Bibbs)
  11. Re: users table (Blaine Lang)

--__--__--

Message: 1
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] [Fwd: further span in comments & problem with
 security listserv signup]
Date: Tue, 5 Oct 2004 19:02:31 +0200
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

(splitting my reply so I can cc: Michael on the other issues)


>Did the story aging thing ever get formally approved?


If anyone's going to write it, I'll include it. Since the idea was to
write it as a SpamX "plugin", we can easily add it later in the process,
so it shouldn't be a showstopper for a 1.3.10rc1.



>I'll try and make 

>myself available in IRC to help clean up any remaining tasks that are 

>holding up our 1.3.10 release.


There's PDF, PDF, and ... PDF ;-)

bye, Dirk


-- 
http://www.haun-online.de/
http://www.handful-of-sparks.de/


--__--__--

Message: 2
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Cc: <M.D.Fischer at kent.ac.uk>
Subject: Re: [geeklog-devel] [Fwd: further span in comments & problem with
 security listserv signup]
Date: Tue, 5 Oct 2004 19:02:34 +0200
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Michael,


>Apparently the spammers are back ... I had new incidents on September 

>25 and Oct 4th  using 1.3.9-sr1, with anonymous access disabled.


Were those comments anonymous? If the spammers got into the trouble of
actually registering an account, they could, of course, post as they like
since that is, after all, the whole idea behind the comment option.

In that case, I would suggest installing the SpamX plugin.



>I am using email because I tried to sign up with the security listserv 

>and got an 'internal error' message.


You can't subscribe to the geeklog-security list, but you simply can post
to the list address.



>The site, btw, is sasci.anthrosciences.org.


It seems to allow anonymous posting anyway. Is that on purpose?

bye, Dirk


-- 
http://www.geeklog.net/
http://geeklog.info/


--__--__--

Message: 3
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] [Fwd: further span in comments & problem with
 security listserv signup]
Date: Tue, 5 Oct 2004 22:29:24 +0200
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

I wrote:


>There's PDF, PDF, and ... PDF ;-)


To be a bit more precise:

- generated PDFs not being deleted
- uses XHTML, even though htmldoc doesn't understand it
- as a consequence of the above: Do we need the Tidy support then?

And, most importantly, it doesn't work - at least not for me:

"The PDF you requested either does not exist or you tried to illegally
access a file."

The PDF was created (htmldoc is installed and working, no permission
problems), but it's simply not displayed ...

bye, Dirk


-- 
http://www.haun-online.de/
http://geeklog.info/


--__--__--

Message: 4
Date: Tue, 05 Oct 2004 15:58:56 -0500
From: Tony Bibbs <tony at tonybibbs.com>
To: geeklog-devel at lists.geeklog.net
Subject: [geeklog-devel] PDF support, was [Fwd: further span in comments & problem with security
 listserv signup]
Reply-To: geeklog-devel at lists.geeklog.net

Dirk Haun wrote:


> To be a bit more precise:

>

>- generated PDFs not being deleted

>  

>

Should be easy enough to fix.  Main problem, though, is the currently 
implementation gives a timestamp as the name of the PDF.  Sounds fine 
but if the same one is clicked over and over we regenerate copies of the 
PDF.  This was donated code so I'll have to monkey with it.  My 
inclination is to use the SID and append the timestamp to the end of the 
file.  That would give something like 
<some_story_id>_<some_timestamp>.pdf.  The codecan then easily modify 
the timestamp portion on subsequent views so that the purge process works.


>- uses XHTML, even though htmldoc doesn't understand it

>- as a consequence of the above: Do we need the Tidy support then?

>  

>

No.  Not sure WTF I was thinking.


>And, most importantly, it doesn't work - at least not for me:

>  

>

Lol, works for me ;-).  More testing will be needed after the above 
changes are needed.

Vinny, what's your plate looking like?  I'm tied up tonight, might have 
time tomorrow and won't have time after that until Saturday morning.

--Tony

--__--__--

Message: 5
Date: Tue, 5 Oct 2004 23:30:30 -0400
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] PDF support, was [Fwd: further span in comments & problem with security listserv signup]
Reply-To: geeklog-devel at lists.geeklog.net

I just started looking at the code, haven't actually done a successful
test yet (this is probably my fault).  Like Tony though, I won't have
significant time until this weekend.  I'll let everyone know if I make
any progress (on this or adding to the SpamX plugin, I'll make PDF a
priority though).

-Vinny

On Tue, 05 Oct 2004 15:58:56 -0500, Tony Bibbs <tony at tonybibbs.com> wrote:

> Dirk Haun wrote:

> 

> > To be a bit more precise:

> >

> >- generated PDFs not being deleted

> >

> >

> Should be easy enough to fix.  Main problem, though, is the currently

> implementation gives a timestamp as the name of the PDF.  Sounds fine

> but if the same one is clicked over and over we regenerate copies of the

> PDF.  This was donated code so I'll have to monkey with it.  My

> inclination is to use the SID and append the timestamp to the end of the

> file.  That would give something like

> <some_story_id>_<some_timestamp>.pdf.  The codecan then easily modify

> the timestamp portion on subsequent views so that the purge process works.

> 

> >- uses XHTML, even though htmldoc doesn't understand it

> >- as a consequence of the above: Do we need the Tidy support then?

> >

> >

> No.  Not sure WTF I was thinking.

> 

> >And, most importantly, it doesn't work - at least not for me:

> >

> >

> Lol, works for me ;-).  More testing will be needed after the above

> changes are needed.

> 

> Vinny, what's your plate looking like?  I'm tied up tonight, might have

> time tomorrow and won't have time after that until Saturday morning.

> 

> --Tony

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>


--__--__--

Message: 6
To: geeklog-devel at lists.geeklog.net
From: Rob Griffiths <robg at macosxhints.com>
Date: Tue, 5 Oct 2004 21:02:47 -0700
Subject: [geeklog-devel] A lib-common mod to highlight newest comments
Reply-To: geeklog-devel at lists.geeklog.net

GL Team:

Below is my latest tweak to the core GL code ... driven by my desire to 
keep up better with the comments on my site.

I prefer to read comments on my site in nested mode, as I find it the 
easiest way to follow the conversations. However, what's not easy is 
finding the newest comments in nested mode, even with sort by newest. 
Obviously, this is because a new reply may be the 10th in line to a 
very old comment, which will push it down the sort order.

So I modified lib-common today to support the concept of highlighting 
the five newest hints, regardless of sort order. Now when I read 
through the comments, the five newest ones will always be visually 
called out, making them very easy to spot.

I've detailed my changes below; I would be interested in any help that 
might be provided to clean it up (in particular, it strikes me that 
building the array the way I do is somewhat redundant, but it's the 
only way I could get it to work). I would also be interested in some 
way of doing this in lib-custom, but I didn't see an easy solution 
there, especially given my lack of programming experience. I know it's 
not ideal to be setting style names in the PHP files, but again, I 
didn't see an easy way around it. Finally, this has not been tested on 
anything other than my local dev box, and then, only (so far) in nested 
mode.

Feel free to use, change, delete, etc., as you wish, but I thought I'd 
at least share the hack. Details follow...

-rob.

===============================

Changes in lib-common.php (based on 1.3.9sr2); approximate line numbers 
provided, though they will be off based on other changes I've made.

Function COM_getComment:

  * [Line 2704] Change the first line to pass the array of newest 
comments:

    function COM_getComment( $A, $mode, $type, $order, $new_comments, 
$delete_option = false, $preview = false)

  * [line 2807] Add in the routine to check for a match between the 
current comment and the array. Insert this just
    after the "nice_date" check:

    if ( in_array($A['cid'], $new_comments, TRUE)) {
       $template->set_var( 'rstyle', "hidate");
     } else {
       $template->set_var( 'rstyle', "lodate");
     }

  * [line 2891] Add in the array to the recursive function call:

    $retval .= COM_getComment( $A, $mode, $type, $order, $new_comments, 
$delete_option );

Now in function COM_userComments...

  * [line 2977] Add the routine to build the array of newest comments; 
insert this just below the
    "$result = DB_query( $q )" line:

    $myquery = "select CID from {$_TABLES['comments']} WHERE sid='" . 
$sid . "' ORDER BY DATE DESC LIMIT 5";
    $r1array  = DB_query($myquery);
    $nrows = db_NumRows($r1array);
    for( $i = 0; $i < $nrows; $i++ ) {
      $r1r      = DB_fetchArray($r1array);
      $new_comments[] = $r1r['CID'];
    }

  * [line 2991] Add in the array of newest comments to the list of 
passed variables:

    $thecomments .= COM_getComment( $A, $mode, $type, $order, 
$new_comments,
                                    $delete_option);

Now just create two classes, lodate and hidate, in your CSS, and place 
a call to the new variable 'rstyle' in the comment.thtml file. I've 
chosen to highlight the date, but you could obviously use the style to 
do whatever you wish with the newest comments. Here's how my date row 
looks:

   <tr><td colspan="2"><span class="{rstyle}">{date}</span></td></tr>

-rob.


--__--__--

Message: 7
Date: Wed, 6 Oct 2004 08:01:46 -0400
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] A lib-common mod to highlight newest comments
Reply-To: geeklog-devel at lists.geeklog.net

Rob,

Sounds like a good idea.  I think though if we do this we should do a
more thorough job and emulate Scoop and other CMSs which place "[new]"
or some similar indication next to all the comments that have been
posted since the user last viewed the article.

Although that sounds difficult, it really isn't.  All that is needed
is to keep track of when each user last viewed a story.  Then as
comments are display the indicator is placed next to comments more
recent than the last view.

It's something that I have been thinking about but putting off because
of everything else that has to be done.

-Vinny


On Tue, 5 Oct 2004 21:02:47 -0700, Rob Griffiths <robg at macosxhints.com> wrote:

> GL Team:

> 

> Below is my latest tweak to the core GL code ... driven by my desire to

> keep up better with the comments on my site.

> 

> I prefer to read comments on my site in nested mode, as I find it the

> easiest way to follow the conversations. However, what's not easy is

> finding the newest comments in nested mode, even with sort by newest.

> Obviously, this is because a new reply may be the 10th in line to a

> very old comment, which will push it down the sort order.

> 

> So I modified lib-common today to support the concept of highlighting

> the five newest hints, regardless of sort order. Now when I read

> through the comments, the five newest ones will always be visually

> called out, making them very easy to spot.

> 

> I've detailed my changes below; I would be interested in any help that

> might be provided to clean it up (in particular, it strikes me that

> building the array the way I do is somewhat redundant, but it's the

> only way I could get it to work). I would also be interested in some

> way of doing this in lib-custom, but I didn't see an easy solution

> there, especially given my lack of programming experience. I know it's

> not ideal to be setting style names in the PHP files, but again, I

> didn't see an easy way around it. Finally, this has not been tested on

> anything other than my local dev box, and then, only (so far) in nested

> mode.

> 

> Feel free to use, change, delete, etc., as you wish, but I thought I'd

> at least share the hack. Details follow...

> 

> -rob.

> 

> ===============================

> 

> Changes in lib-common.php (based on 1.3.9sr2); approximate line numbers

> provided, though they will be off based on other changes I've made.

> 

> Function COM_getComment:

> 

>   * [Line 2704] Change the first line to pass the array of newest

> comments:

> 

>     function COM_getComment( $A, $mode, $type, $order, $new_comments,

> $delete_option = false, $preview = false)

> 

>   * [line 2807] Add in the routine to check for a match between the

> current comment and the array. Insert this just

>     after the "nice_date" check:

> 

>     if ( in_array($A['cid'], $new_comments, TRUE)) {

>        $template->set_var( 'rstyle', "hidate");

>      } else {

>        $template->set_var( 'rstyle', "lodate");

>      }

> 

>   * [line 2891] Add in the array to the recursive function call:

> 

>     $retval .= COM_getComment( $A, $mode, $type, $order, $new_comments,

> $delete_option );

> 

> Now in function COM_userComments...

> 

>   * [line 2977] Add the routine to build the array of newest comments;

> insert this just below the

>     "$result = DB_query( $q )" line:

> 

>     $myquery = "select CID from {$_TABLES['comments']} WHERE sid='" .

> $sid . "' ORDER BY DATE DESC LIMIT 5";

>     $r1array  = DB_query($myquery);

>     $nrows = db_NumRows($r1array);

>     for( $i = 0; $i < $nrows; $i++ ) {

>       $r1r      = DB_fetchArray($r1array);

>       $new_comments[] = $r1r['CID'];

>     }

> 

>   * [line 2991] Add in the array of newest comments to the list of

> passed variables:

> 

>     $thecomments .= COM_getComment( $A, $mode, $type, $order,

> $new_comments,

>                                     $delete_option);

> 

> Now just create two classes, lodate and hidate, in your CSS, and place

> a call to the new variable 'rstyle' in the comment.thtml file. I've

> chosen to highlight the date, but you could obviously use the style to

> do whatever you wish with the newest comments. Here's how my date row

> looks:

> 

>    <tr><td colspan="2"><span class="{rstyle}">{date}</span></td></tr>

> 

> -rob.

> 

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>


--__--__--

Message: 8
From: Rob Griffiths <robg at macosxhints.com>
Subject: Re: [geeklog-devel] A lib-common mod to highlight newest comments
Date: Wed, 6 Oct 2004 05:06:53 -0700
To: geeklog-devel at lists.geeklog.net
Reply-To: geeklog-devel at lists.geeklog.net

On Oct 6, 2004, at 5:01 AM, Vincent Furia wrote:


> Sounds like a good idea.  I think though if we do this we should do a

> more thorough job and emulate Scoop and other CMSs which place "[new]"


I would certainly welcome such an enhancement! It's one of the things I 
like about Scoop, in fact.


> Although that sounds difficult, it really isn't.  All that is needed


For you :). For me, this was the quick and dirty solution, and even it 
pushed my limited PHP abilities! BTW, I tweaked it a bit more this 
morning so that the highlights won't show up if there are less than 10 
comments...


> It's something that I have been thinking about but putting off because

> of everything else that has to be done.


I'd be glad to help you test it, but I can't really say I could 
contribute to the coding at all!

regards;
-rob.


--__--__--

Message: 9
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Date: Wed, 6 Oct 2004 11:01:03 -0400
Subject: [geeklog-devel] users table
Reply-To: geeklog-devel at lists.geeklog.net

I was wondering if should not have a location field in the userinfo table. 
It certainly would be used more then "pgpkey" which I know had a good 
reason.

I vote yes -- anyone have an issue?

Blaine 


--__--__--

Message: 10
Date: Wed, 06 Oct 2004 11:16:13 -0500
From: Tony Bibbs <tony at tonybibbs.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] users table
Reply-To: geeklog-devel at lists.geeklog.net

If we do that, this should at least open up the possibility of 
dynamically adding extended user attributes.  I know there is a hack out 
there that does this and I don't know how it works but an ideal solution 
would allow the following:

1) Ability to give the field a name
2) Allow field tag (shown on forms) to be represented in different languages
3) Ability to mark as required
4) Ability to give a min and/or max value
5) Ability to give a set of possible values (i.e. to be used in a drop down)
6) Ability to indicate a data type for better validation.
7) Doesn't require template changes when new fields are added.
8) Oh, and most importantly, don't require a database change in order to 
add a new field

This should all be doable via the administration pages.  This could, 
arguably, be a for-profit solution as I argue implementing those 
features isn't trivial.

I'm ok, with you adding the field to itch the immediate scratch...just 
thinking out loud.

--Tony

I'm OK with adding the field to itch the immediate scratch
Blaine Lang wrote:


>I was wondering if should not have a location field in the userinfo table. 

>It certainly would be used more then "pgpkey" which I know had a good 

>reason.

>

>I vote yes -- anyone have an issue?

>

>Blaine 

>

>_______________________________________________

>geeklog-devel mailing list

>geeklog-devel at lists.geeklog.net

>http://lists.geeklog.net/listinfo/geeklog-devel

>  

>



--__--__--

Message: 11
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] users table
Date: Wed, 6 Oct 2004 12:28:07 -0400
Reply-To: geeklog-devel at lists.geeklog.net

Hi Tony,

That sounds more like the formEditor Plugin that I've developed for a client 

:)


I can see a subset of the formEditor plugin being re-purposed as a flexible 
plugin for creating custom fields for the user registration and user 
profile. I'll have to ponder that one some more and see if I get some time 
but I like the idea.

Blaine
----- Original Message ----- 
From: "Tony Bibbs" <tony at tonybibbs.com>
To: <geeklog-devel at lists.geeklog.net>
Sent: Wednesday, October 06, 2004 12:16 PM
Subject: Re: [geeklog-devel] users table


If we do that, this should at least open up the possibility of
dynamically adding extended user attributes.  I know there is a hack out
there that does this and I don't know how it works but an ideal solution
would allow the following:

1) Ability to give the field a name
2) Allow field tag (shown on forms) to be represented in different languages
3) Ability to mark as required
4) Ability to give a min and/or max value
5) Ability to give a set of possible values (i.e. to be used in a drop down)
6) Ability to indicate a data type for better validation.
7) Doesn't require template changes when new fields are added.
8) Oh, and most importantly, don't require a database change in order to
add a new field

This should all be doable via the administration pages.  This could,
arguably, be a for-profit solution as I argue implementing those
features isn't trivial.

I'm ok, with you adding the field to itch the immediate scratch...just
thinking out loud.

--Tony

I'm OK with adding the field to itch the immediate scratch
Blaine Lang wrote:


>I was wondering if should not have a location field in the userinfo table.

>It certainly would be used more then "pgpkey" which I know had a good

>reason.

>

>I vote yes -- anyone have an issue?

>

>Blaine

>

>_______________________________________________

>geeklog-devel mailing list

>geeklog-devel at lists.geeklog.net

>http://lists.geeklog.net/listinfo/geeklog-devel

>

>


_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel 



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest