[geeklog-devtalk] geeklog-devel digest, Vol 1 #498 - 6 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. Re: Dynamic Comments... (Dirk Haun)
   2. Re: Dynamic Comments... (Vincent Furia)
   3. Re: Dynamic Comments... (Dirk Haun)
   4. Re: Dynamic Comments... (Vincent Furia)
   5. Re: Dynamic Comments... (Niels Leenheer)
   6. Re: Dynamic Comments... (Justin Carlson)

--__--__--

Message: 1
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Dynamic Comments...
Date: Mon, 31 Jan 2005 21:00:10 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vinny,


>What do people think (try clicking on the blue arrows).


Nice. When can we expect it in CVS? ;-)

bye, Dirk


-- 
http://www.haun-online.de/
http://www.haun.info/


--__--__--

Message: 2
Date: Mon, 31 Jan 2005 15:12:18 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Dynamic Comments...
Reply-To: geeklog-devel at lists.geeklog.net

I'm working on getting it past the prototype stage.  While it (just)
works now, I need to do some modifications to make it integrate
cleanly and to not be embarrassed by my code.  Hopefully I'll have it
checked into CVS in the next couple days.

Now, some possible downsides:
1. Each time a person clicks to expand (or collapse) a comment it is a
http request to the server, which means loading lib-common.php, etc. 
While the page load for just the comment is relatively fast, server
load could be problem for a really popular server (especially, say,
during a slashdotting).

2. The images I'm using I grabbed from http://kuro5hin.org.  I need to
check their licensing to make sure I don't piss anyone off.

3. Of course, as with all good things, theme updates are required.

-Vinny

--__--__--

Message: 3
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Dynamic Comments...
Date: Mon, 31 Jan 2005 21:20:00 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vinny,


>While the page load for just the comment is relatively fast, server

>load could be problem for a really popular server (especially, say,

>during a slashdotting).


I was about to ask about the server load :-)

Any chance this could be made configurable? Comment-heavy sites like
groklaw could then switch it off.



>2. The images I'm using I grabbed from http://kuro5hin.org.  I need to

>check their licensing to make sure I don't piss anyone off.


They don't quite fit in with the Professional theme anyway, IMHO. They
look a bit too heavy to me.

I'm sure Simon can come up with something royalty-free ;-)

bye, Dirk


-- 
http://www.haun-online.de/
http://www.haun.info/


--__--__--

Message: 4
Date: Mon, 31 Jan 2005 15:31:15 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Dynamic Comments...
Reply-To: geeklog-devel at lists.geeklog.net

On Mon, 31 Jan 2005 21:20:00 +0100, Dirk Haun <dirk at haun-online.de> wrote:

> I was about to ask about the server load :-)

> 

> Any chance this could be made configurable? Comment-heavy sites like

> groklaw could then switch it off.

>

I'm sure its possible, I'm not sure it it will be easy or pretty
though.  The comment modes are kept in the database now, so switching
"off" dynamic comments would at least require an admin to modify the
database and probably a $_CONF variable that would ignore requests for
single comments (outside the geeklog header/footer framework) and
ignore requests for comments to be displayed dynamically.
 

> 

> They don't quite fit in with the Professional theme anyway, IMHO. They

> look a bit too heavy to me.

> 

> I'm sure Simon can come up with something royalty-free ;-)

> 

Simon: think you can whip something up?

-Vinny

--__--__--

Message: 5
Date: Mon, 31 Jan 2005 21:44:03 +0100
From: Niels Leenheer <niels at creatype.nl>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Dynamic Comments...
Reply-To: geeklog-devel at lists.geeklog.net

Vincent Furia wrote:


>I'm working on getting it past the prototype stage.  While it (just)

>works now, I need to do some modifications to make it integrate

>cleanly and to not be embarrassed by my code.  Hopefully I'll have it

>checked into CVS in the next couple days.

>  

>

Vincent, great idea!

However, I can see a couple of problems with the code you are currently 
using.

First of all, you are using a single XMLHttpRequest object without 
protecting
it from being called more than once. As a result it is possible to 
interrupt an
ongoing request. Try clicking on quickly on multiple triangles after 
each other,
without waiting for one to finish loading. Only the request clicked on 
last will
be honoured, the other ones will be 'loading' indefinately.

The solution to this problem would be to use an array and push each
request in it. Then use a timer to frequently look at this array, shift
one request of the bottom and execute it. Repeat until the array is
empty...

Secondly, there is a bug in the XMLHttpRequest implementation of Opera,
which basically requeres and extra check inside the onreadystatechange
function, otherwise it will be called multiple times after each other,
but only the first time with the proper responseText.

var inprogress = false;

function loadFragmentInToElement(fragment_url, element_id) {
    var element = document.getElementById(element_id);
    element.innerHTML = '<img src="/images/dynwait.gif" 
alt="Loading..."/>Loading ...';
    xmlhttp.open("GET", fragment_url);
    xmlhttp.onreadystatechange = function() {
        if (inprogress == true && xmlhttp.readyState == 4 && 
xmlhttp.status == 200) {
            inprogress = false;
            element.innerHTML = xmlhttp.responseText;
        }
    }
    xmlhttp.send(null);
    inprogress = true;
}

Niels
-- 
www.rakaz.nl

--__--__--

Message: 6
Date: Mon, 31 Jan 2005 16:54:58 -0600
From: Justin Carlson <justin.carlson at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Dynamic Comments...
Reply-To: geeklog-devel at lists.geeklog.net

It looks like it works well.

I do not see myself using it, and definitely request it to be optional.



On Mon, 31 Jan 2005 21:44:03 +0100, Niels Leenheer <niels at creatype.nl> wrote:

> Vincent Furia wrote:

> 

> >I'm working on getting it past the prototype stage.  While it (just)

> >works now, I need to do some modifications to make it integrate

> >cleanly and to not be embarrassed by my code.  Hopefully I'll have it

> >checked into CVS in the next couple days.

> >

> >

> Vincent, great idea!

> 

> However, I can see a couple of problems with the code you are currently

> using.

> 

> First of all, you are using a single XMLHttpRequest object without

> protecting

> it from being called more than once. As a result it is possible to

> interrupt an

> ongoing request. Try clicking on quickly on multiple triangles after

> each other,

> without waiting for one to finish loading. Only the request clicked on

> last will

> be honoured, the other ones will be 'loading' indefinately.

> 

> The solution to this problem would be to use an array and push each

> request in it. Then use a timer to frequently look at this array, shift

> one request of the bottom and execute it. Repeat until the array is

> empty...

> 

> Secondly, there is a bug in the XMLHttpRequest implementation of Opera,

> which basically requeres and extra check inside the onreadystatechange

> function, otherwise it will be called multiple times after each other,

> but only the first time with the proper responseText.

> 

> var inprogress = false;

> 

> function loadFragmentInToElement(fragment_url, element_id) {

>    var element = document.getElementById(element_id);

>    element.innerHTML = '<img src="/images/dynwait.gif"

> alt="Loading..."/>Loading ...';

>    xmlhttp.open("GET", fragment_url);

>    xmlhttp.onreadystatechange = function() {

>        if (inprogress == true && xmlhttp.readyState == 4 &&

> xmlhttp.status == 200) {

>            inprogress = false;

>            element.innerHTML = xmlhttp.responseText;

>        }

>    }

>    xmlhttp.send(null);

>    inprogress = true;

> }

> 

> Niels

> --

> www.rakaz.nl

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest