[geeklog-devtalk] geeklog-devel digest, Vol 1 #502 - 5 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. Re: Time flys (Tony Bibbs)
   2. Fwd: Re: Interested in Geeklog patches? (Vincent Furia)
   3. Re: Dynamic Comments... (Vincent Furia)
   4. Re: Dynamic Comments... (Dirk Haun)
   5. Re: Dynamic Comments... (Dirk Haun)

--__--__--

Message: 1
Date: Fri, 04 Feb 2005 20:59:48 -0600
From: Tony Bibbs <tony at tonybibbs.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Time flys
Reply-To: geeklog-devel at lists.geeklog.net

Sounds good.  Don't worry, I understand.  FWIW, vinny and I have got it 
into presentable shape, though, I'm sure there is room for improvements

--Tony

Dwight Trumbower wrote:


> Sorry Tony for not responding to the database questions. I just 

> glanced at all the emails since 12/1/04. I will try to look at the ddl 

> this week. You might need to kick me a few more times.

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel




--__--__--

Message: 2
Date: Fri, 4 Feb 2005 23:13:27 -0500
From: Vincent Furia <vfuria at gmail.com>
To: Geeklog Devel <geeklog-devel at lists.geeklog.net>
Subject: [geeklog-devel] Fwd: Re: Interested in Geeklog patches?
Reply-To: geeklog-devel at lists.geeklog.net

Oops, sent this one only to Dirk...


---------- Forwarded message ----------
From: Vincent Furia <vfuria at gmail.com>
Date: Fri, 4 Feb 2005 14:00:55 -0500
Subject: Re: Re: Interested in Geeklog patches?
To: Dirk Haun <dirk at haun-online.de>


OK... spend a few minutes looking into this patch (to stop comments
after a certain amount of time).  And...

...I'm going to have redo this patch from scratch.  It will only work
with stories, patched as is it would choke on polls and plugins.  Plus
it won't apply cleanly on top of the changes I just made to the
comment system anyway. I'll accept any recommendations on how to
handle this functionality for plugins (or should I just let plugins
handle this themselves in the new savecomment function?).

-Vinny

P.S.  I need help from at lease one plugin developer who is/will be
using the comment API to document the new API.  Anyone?  Most of the
work is done, I just need example code!

On Tue, 1 Feb 2005 23:16:35 +0100, Dirk Haun <dirk at haun-online.de> wrote:

> Vinny,

>

> Here's the original email and the patches. It's not as much as I thought

> it was - and relatively recent ...

>

> bye, Dirk

>

> ---------------- Anfang Weiterleitung ----------------

> Betreff: Re: Interested in Geeklog patches?

> Gesendet: Sonntag, 5. Dezember 2004 9:16 Uhr

> Von: Steve McInerney <steve at stedee.id.au>

> An: Dirk Haun <dirk at haun-online.de>

>

> Hi Dirk,

>

> patches attached. I've not sent the complete diff against comment.php -

> mainly as most of the diff is whitespace/indentation changes. And

> obscures the actual changes too well.

>

> I have not actually tested this against the 1.3.10 code; but it looks

> like we're running a comment.php that is very near identical to

> 1.3.10's. It was pretty much a drop in replacement.

>

> I've only recently stepped in to do some coding for this site. The lead

> programmer has been very busy lately and unable to devote as much time

> as he or we would like unfortunately.

>

> [snip]

>

> >>A speed limiter that (was backported?) helped a great deal as well.

> > I don't remember the details, but there were a few bugs with the comment

> > speed limit in earlier versions of Geeklog.

>

> Looking at the 1.3.10 code, we have the same one. And the same missing

> global declaration in savecomment. :-)

>

> Comments/Criticism's always welcome.

>

> Cheers!

>

> - Steve


--__--__--

Message: 3
Date: Sat, 5 Feb 2005 00:11:14 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Dynamic Comments...
Reply-To: geeklog-devel at lists.geeklog.net

OK, code changes are checked in.  I'm still waiting on better
graphics, but for now the kuro5hin (scoop) graphics will work.

Please test, don't forget to update the commentmodes table (see
sql/mysql_1.3.11_1.3.12.sql)...

-Vinny


On Fri, 4 Feb 2005 09:06:01 -0500, Vincent Furia <vfuria at gmail.com> wrote:

> Blaine,

> 

> I'll be checking it all into CVS soon.

> 

> Current ToDo List for dynamic comments:

> * get new images that better match the professional theme (Simon?  Anyone?)

> * create a $_CONF variable to disable dynamic comments and implement

> the disable in the code

> 

> -Vinny

> 

> On Fri, 4 Feb 2005 00:07:51 -0500, Blaine Lang <geeklog at langfamily.ca> wrote:

> > This is real a neat feature Vinny - nice work.

> > I like the fact that now I can collapse it again once I view the comment.

> >

> > Do you have any code that you can send me or direct me to better understand

> > how this is being done.

> > I see immediate use for this in some of my projects.

> >

> > Blaine

> > ----- Original Message -----

> > From: "Vincent Furia" <vfuria at gmail.com>

> > To: <geeklog-devel at lists.geeklog.net>

> > Sent: Thursday, February 03, 2005 11:29 PM

> > Subject: Re: [geeklog-devel] Dynamic Comments...

> >

> > On Mon, 31 Jan 2005 21:44:03 +0100, Niels Leenheer <niels at creatype.nl>

> > wrote:

> > > However, I can see a couple of problems with the code you are currently

> > > using.

> > >

> > > First of all, you are using a single XMLHttpRequest object without

> > > protecting

> > > it from being called more than once. As a result it is possible to

> > > interrupt an

> > > ongoing request. Try clicking on quickly on multiple triangles after

> > > each other,

> > > without waiting for one to finish loading. Only the request clicked on

> > > last will

> > > be honoured, the other ones will be 'loading' indefinately.

> > >

> > This was a big problem, I didn't quite use the solution you suggested

> > (I couldn't quite get it to work), but I did (if I may say so) a

> > ingenous little workaround.

> >

> > >

> > > Secondly, there is a bug in the XMLHttpRequest implementation of Opera,

> > > which basically requeres and extra check inside the onreadystatechange

> > > function, otherwise it will be called multiple times after each other,

> > > but only the first time with the proper responseText.

> > >

> > OK, changed the code around to account for this.  Hopefully it will

> > work with Opera now.

> >

> > Thanks for all the suggestions Niels.  Anyone else see any problems

> > (http://vfuria.dyndns.org:8080/article.php?story=geeklog-1.3.10rc2&mode=dynamic#comments)

> >

> > Thanks,

> > Vinny

> > _______________________________________________

> > geeklog-devel mailing list

> > geeklog-devel at lists.geeklog.net

> > http://lists.geeklog.net/listinfo/geeklog-devel

> >

> > _______________________________________________

> > geeklog-devel mailing list

> > geeklog-devel at lists.geeklog.net

> > http://lists.geeklog.net/listinfo/geeklog-devel

> >

>


--__--__--

Message: 4
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Dynamic Comments...
Date: Sat, 5 Feb 2005 11:11:04 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vincent Furia wrote:


>Please test, don't forget to update the commentmodes table (see

>sql/mysql_1.3.11_1.3.12.sql)...


Thanks Vinny, working nicely.

One odd issue, though: It seems to be messing with the character set.
When I collapse a comment and expand it again, all of the German umlauts
have turned into question marks (only in that comment, the rest of the
page is fine). Any ideas?

This is with my local install. I'll upgrade geeklog.info later today and
see if I can reproduce the problem there as well.

bye, Dirk


-- 
http://www.haun-online.de/
http://mypod.de/


--__--__--

Message: 5
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Dynamic Comments...
Date: Sat, 5 Feb 2005 14:04:31 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

I wrote:


>One odd issue, though: It seems to be messing with the character set.

>When I collapse a comment and expand it again, all of the German umlauts

>have turned into question marks


The same thing is happening on geeklog.info:

<http://geeklog.info/article.php?stor
y=20020829000431524&mode=dynamic#comments>


And now for the browser compatibility test (fasten your seatbelts ...):

- The collapsing icon doesn't show up in Safari. You can expand comments,
but then the icon vanishes.

- The same thing happens in OmniWeb 5.1.

- Doesn't work at all in Mac-IE 5.2.3: The collapsing icons don't show
up; the expanding icons do show up but don't work.

- The exact same thing happens in iCab 2.9.8

- The collapsing icon doesn't show up in Opera 7.54u2 for Mac. Expanding
doesn't work (switches to "Loading ..." and stays there).

- The exact same thing happens in OmniWeb 4.5 and iCab 3.0.0 beta 227.



>From Opera, I get the following error message in the JavaScript console:


Event thread: onclick
Error:
name: TypeError
message: Statement on line 61: Expression did not evaluate to a function
object: xmlhttp.open
Backtrace:
  Line 61 of linked script http://geeklog.info/dynamic.js
    xmlhttp.open("GET", fragment_url, true);
  In unknown script
    loadFragmentInToElement("http://geeklog.info/comment.php?
mode=fetch&cid=192&full=true", "192");
  At unknown location
    {event handler trampoline}

To summarize: On the Mac, it currently only works on Gecko-based
browsers. I did use the latest versions available of those browsers (and
in some cases another, older version).

bye, Dirk

-- 
http://www.haun-online.de/
http://www.macosx-faq.de/



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest