[geeklog-devtalk] Trackbacks

[Michael Jervis]

> You should, of course, use the link of the article your 

> commenting on in your post. So let me try again:


In that case there is a bug:

"I've upgraded fb.com to run 1.3.12CVS of geeklog, which means you can do
trackbacks on my posts etc. This is a very nice feature that Dirk has added
well to the system. I'm working on futher extensions that <i>hopefuly</i>
will make it into geeklog core also. Including remote authentication, so you
don't have to register <i>here</i> to comment on my site. <a
href="http://geeklog.info/article.php/neue-features">New Geeklog
Features</a>"

In Stories admin I clicked "Send Ping", then "Send Trackback":

 	
 Welcome to FuckingBrit.com, THEMike
 Saturday, February 05 2005 @ 06:28 PM GMT
Select Trackback URL	
No links found. You can not send a Trackback comment for this entry.

Had a quick look, it appears that in trackback.php (1.8 and 1.9) in mode
pretrackback, $fulltext = getItemInfo ($type, $id, 'description'); is
returning the article title, looking into getItemInfo, it appears $what is
ignored and 'title' is always sent:

function getItemInfo ($type, $id, $what)
{
    if ($type == 'article') {
        return STORY_getItemInfo ($id, 'title');
    } else {
        return PLG_getItemInfo ($type, $id, 'title');
    }
}

Changing it to:
function getItemInfo ($type, $id, $what)
{
    if ($type == 'article') {
        return STORY_getItemInfo ($id, $what);
    } else {
        return PLG_getItemInfo ($type, $id, $what);
    }
}

Fixed it, and I could now trackback to your article again, but I'll save you
the pain of duplicated english language posts on your nice clean german site
;-)

Mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3030 bytes
Desc: not available
Url : <http://eight.pairlist.net/pipermail/geeklog-devtalk/attachments/20050205/07312b1e/attachment.bin>