[geeklog-devtalk] geeklog-devel digest, Vol 1 #504 - 3 msgs

geeklog-devel-request at lists.geeklog.net geeklog-devel-request at lists.geeklog.net
Mon Feb 7 13:00:01 EST 2005

Previous message: [geeklog-devtalk] Making the Calendar A Plugin
Next message: [geeklog-devtalk] trackbacks
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Send geeklog-devel mailing list submissions to
geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."

Today's Topics:

1. Plugin API's for comments (Blaine Lang)
2. Re: Plugin API's for comments (Vincent Furia)
3. Re: Plugin API's for comments (Blaine Lang)

--__--__--

Message: 1
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Date: Sun, 6 Feb 2005 17:35:46 -0500
Subject: [geeklog-devel] Plugin API's for comments
Reply-To: geeklog-devel at lists.geeklog.net

This is a multi-part message in MIME format.

------=_NextPart_000_00D8_01C50C72.4A33C900
Content-Type: text/plain;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

Vinny,

I am writting new functions for the filemgmt plugin to use the new =
comment API's. Once I have these working well on a new install, I can =
provide some updated docs. Looks like I will need to also have a update =
script since there will be some data changes.

Looking at the commentbar - I see the URL {parent_url} set for plugins =
is an assumed plugin_dir/index.php.

This may not be too bad for most plugins and I can add code to handle =
this in my case since it's not the script I want to use.
But .. I have no idea when the plugin index.php is called that it's =
being called from the commentbar or that I should now show the comments.

The parm passed is $_POST['id'] which is too generic and most plugins =
already use a parm called id.
There needs to be another parm used or a parm passed indicating the mode =
is to displaycomments.

I'd prefer a way that we could set the URL or maybe even just have it =
call a PLG function to handle the commentbar.
We have PLG_displayComment that is used in comment.php

We could possibly set the parent_url for the "refresh" to comment.php as =
well. We already have a $type parm in this form.
comment.php already has the logic to handle plugin comments.

I noticed on other oddity with the commentbar. There is a hidden =
variable called $mode set and can be used to hold "display or view" I =
believe.
Problem is there is a second variable in the same form called $mode as =
well - the selectbox for the display mode.

Regards,
Blaine

------=_NextPart_000_00D8_01C50C72.4A33C900
Content-Type: text/html;
charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<HTML><HEAD>
<META http-equiv=3DContent-Type content=3D"text/html; =
charset=3Diso-8859-1">
<META content=3D"MSHTML 6.00.2900.2523" name=3DGENERATOR>
<STYLE></STYLE>
</HEAD>
<BODY bgColor=3D#ffffff>
<DIV><FONT face=3DArial size=3D2>Vinny,</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>I am writting new functions for the =
filemgmt plugin=20
to use the new comment API's. Once I have these working well on a new =
install, I=20
can provide some updated docs. Looks like I will need to also have a =
update=20
script since there will be some data changes.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>Looking at the commentbar - I see the =
URL=20
{parent_url} set for plugins is an assumed =
plugin_dir/index.php.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>This may not be too bad for most =
plugins and I can=20
add code to handle this in my case since it's not the script I want to=20
use.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>But .. I have no idea when the plugin =
index.php is=20
called that it's being called from the commentbar or that I should now =
show the=20
comments.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>The parm passed is $_POST['id'] which =
is too=20
generic and most plugins already use a parm called id.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>There needs to be another parm used or =
a parm=20
passed indicating the mode is to displaycomments.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>I'd prefer a way that we could set the =
URL or maybe=20
even just have it call a PLG function to handle the =
commentbar.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>We have PLG_displayComment that is used =
in=20
comment.php</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>We could possibly set the parent_url =
for the=20
"refresh" to comment.php as well. We already have a $type parm in =
this=20
form.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>comment.php already has the logic to =
handle plugin=20
comments.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>I noticed on other oddity with the =
commentbar.=20
There is a hidden variable called $mode set and can be used to hold =
"display or=20
view" I believe.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>Problem is there is a second variable =
in the same=20
form called $mode as well - the selectbox for the display =
mode.</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2>Regards,</FONT></DIV>
<DIV><FONT face=3DArial size=3D2>Blaine</FONT></DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV>
<DIV><FONT face=3DArial size=3D2></FONT> </DIV></BODY></HTML>

------=_NextPart_000_00D8_01C50C72.4A33C900--

--__--__--

Message: 2
Date: Mon, 7 Feb 2005 00:27:57 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Plugin API's for comments
Reply-To: geeklog-devel at lists.geeklog.net

On Sun, 6 Feb 2005 17:35:46 -0500, Blaine Lang <geeklog at langfamily.ca> wrote:

>

> Vinny,

>

> I am writting new functions for the filemgmt plugin to use the new comment

> API's. Once I have these working well on a new install, I can provide some

> updated docs. Looks like I will need to also have a update script since

> there will be some data changes.

>

> Looking at the commentbar - I see the URL {parent_url} set for plugins is an

> assumed plugin_dir/index.php.

>

> This may not be too bad for most plugins and I can add code to handle this

> in my case since it's not the script I want to use.

> But .. I have no idea when the plugin index.php is called that it's being

> called from the commentbar or that I should now show the comments.

>

> The parm passed is $_POST['id'] which is too generic and most plugins

> already use a parm called id.

> There needs to be another parm used or a parm passed indicating the mode is

> to displaycomments.

That ID refers to the plugins "item". It should be the unique
identifier for whatever item the comments are about. It is only used
as a link back up to the "item" that the comments are about. It is up
to the plugin if/how comments are displayed on that page.

>

> I'd prefer a way that we could set the URL or maybe even just have it call a

> PLG function to handle the commentbar.

> We have PLG_displayComment that is used in comment.php

>

I think this would be overkill. Unless you can think of a time when a
plugin would not have index.php?id=XXX go to the general view of the
"item" described by XXX.

> We could possibly set the parent_url for the "refresh" to comment.php as

> well. We already have a $type parm in this form.

> comment.php already has the logic to handle plugin comments.

>

Once on the comments page, all "refreshes" stay on the comment page.
The only thing the index.php?id=XXX link is used for is to link the
title to the "item". A "refresh" should stay on the comment page if
that is where the comments are currently being viewed.

> I noticed on other oddity with the commentbar. There is a hidden variable

> called $mode set and can be used to hold "display or view" I believe.

> Problem is there is a second variable in the same form called $mode as well

> - the selectbox for the display mode.

>

The select box changes to "format" on comment.php (instead of mode).
A mode form variable name should never appear twice (if it does let me
know...).

> Regards,

> Blaine

>

np,
Vinny

--__--__--

Message: 3
From: "Blaine Lang" <geeklog at langfamily.ca>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Plugin API's for comments
Date: Mon, 7 Feb 2005 09:23:02 -0500
Reply-To: geeklog-devel at lists.geeklog.net

Monday, February 07, 2005 12:27 AM, Vinny wrote:

> That ID refers to the plugins "item". It should be the unique

> identifier for whatever item the comments are about. It is only used

> as a link back up to the "item" that the comments are about. It is up

> to the plugin if/how comments are displayed on that page.

Vinny, ok - np. I just need to make a few changes to my plugin. Currently,
the way this plugin is written, I really want to send it to singlefile.php
and then display the file details above the commentbar. I agree with the way
it is currently should work in most cases.

I'll work on it again later this week or this weekend.

Blaine
----- Original Message -----
From: "Vincent Furia" <vfuria at gmail.com>
To: <geeklog-devel at lists.geeklog.net>
Sent: Monday, February 07, 2005 12:27 AM
Subject: Re: [geeklog-devel] Plugin API's for comments

On Sun, 6 Feb 2005 17:35:46 -0500, Blaine Lang <geeklog at langfamily.ca>
wrote:

>

> Vinny,

>

> I am writting new functions for the filemgmt plugin to use the new comment

> API's. Once I have these working well on a new install, I can provide some

> updated docs. Looks like I will need to also have a update script since

> there will be some data changes.

>

> Looking at the commentbar - I see the URL {parent_url} set for plugins is

> an

> assumed plugin_dir/index.php.

>

> This may not be too bad for most plugins and I can add code to handle this

> in my case since it's not the script I want to use.

> But .. I have no idea when the plugin index.php is called that it's being

> called from the commentbar or that I should now show the comments.

>

> The parm passed is $_POST['id'] which is too generic and most plugins

> already use a parm called id.

> There needs to be another parm used or a parm passed indicating the mode

> is

> to displaycomments.

That ID refers to the plugins "item". It should be the unique
identifier for whatever item the comments are about. It is only used
as a link back up to the "item" that the comments are about. It is up
to the plugin if/how comments are displayed on that page.

>

> I'd prefer a way that we could set the URL or maybe even just have it call

> a

> PLG function to handle the commentbar.

> We have PLG_displayComment that is used in comment.php

>

I think this would be overkill. Unless you can think of a time when a
plugin would not have index.php?id=XXX go to the general view of the
"item" described by XXX.

> We could possibly set the parent_url for the "refresh" to comment.php as

> well. We already have a $type parm in this form.

> comment.php already has the logic to handle plugin comments.

>

Once on the comments page, all "refreshes" stay on the comment page.
The only thing the index.php?id=XXX link is used for is to link the
title to the "item". A "refresh" should stay on the comment page if
that is where the comments are currently being viewed.

> I noticed on other oddity with the commentbar. There is a hidden variable

> called $mode set and can be used to hold "display or view" I believe.

> Problem is there is a second variable in the same form called $mode as

> well

> - the selectbox for the display mode.

>

The select box changes to "format" on comment.php (instead of mode).
A mode form variable name should never appear twice (if it does let me
know...).

> Regards,

> Blaine

>

np,
Vinny
_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel

--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel

End of geeklog-devel Digest

Previous message: [geeklog-devtalk] Making the Calendar A Plugin
Next message: [geeklog-devtalk] trackbacks
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the geeklog-devtalk mailing list