[geeklog-devtalk] geeklog-devel digest, Vol 1 #486 - 5 msgs

[geeklog-devel-request at lists.geeklog.net]

Send geeklog-devel mailing list submissions to
	geeklog-devel at lists.geeklog.net

To subscribe or unsubscribe via the World Wide Web, visit
	http://lists.geeklog.net/listinfo/geeklog-devel
or, via email, send a message with subject or body 'help' to
	geeklog-devel-request at lists.geeklog.net

You can reach the person managing the list at
	geeklog-devel-admin at lists.geeklog.net

When replying, please edit your Subject line so it is more specific
than "Re: Contents of geeklog-devel digest..."


Today's Topics:

   1. Re: Minimum requirements: MySQL (Tony Bibbs)
   2. Re: Deleting comments (Vincent Furia)
   3. Re: Deleting comments (Dirk Haun)
   4. Table locking (Dirk Haun)
   5. Re: Table locking (Vincent Furia)

--__--__--

Message: 1
Date: Fri, 21 Jan 2005 13:17:07 -0600
From: Tony Bibbs <tony at tonybibbs.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Minimum requirements: MySQL
Reply-To: geeklog-devel at lists.geeklog.net

Not at all.  Makes perfect sense.

--Tony

Dirk Haun wrote:


>For the next Geeklog release, I'm going to raise the minimum requirements

>_slightly_ again.

>

>This time, it's the MySQL version: The new minimum requirement will be

>3.23.2. Currently, we don't specifiy a minimum version and have even

>incorporated changes to support 3.22 in the past.

>

>As of MySQL 3.23.2 it's possible to have an index on a field that's

>DEFAULT NULL. We take that into account in the inital install, but not in

>upgrades and it's a real hassle to handle that in upgrades.

>

>I think this is reasonable. MySQL AB have stopped supporting 3.22 long

>ago, and anyone running on something older than 3.23.45 (or thereabouts)

>is vulnerable to various security issues anyway. Not to mention that the

>current version recommended for production use is 4.1.9.

>

>I'm also going to change the install script such that it aborts the

>install when it encounters PHP versions older than 4.1.0 or MySQL

>versions older than 3.23.2.

>

>Parallel to that, my goal for Geeklog 1.3.12 is to get rid of the old

>"long" PHP HTTP arrays ($HTTP_GET_VARS, etc.) and only use the "short"

>ones ($_GET). This will help people running PHP 5, where the old-style

>arrays are disabled by default.

>

>Since some plugins and add-ons may require the "long" arrays, I'm going

>to add a warning to the install script for that case (as suggested by bug

>report #360).

>

>Does anyone see a problem with any of this?

>

>bye, Dirk

>

>

>  

>



--__--__--

Message: 2
Date: Fri, 21 Jan 2005 18:34:27 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Deleting comments
Reply-To: geeklog-devel at lists.geeklog.net

The only comment function that I see in lib-common.php that is used
outside the other comment functions is COM_userComments.  I'll leave a
depreciated version of that function in lib-common.php, but the other
comment functions I'm just going to move out.

By the way, I'm placing all the COM_ comment functions and the
functions in comment.php into lib-comment.php.  Right now that looks
like about 1200 or so lines of code.  All that is checked in.

Next step is to look at redoing the comment API (especially for
deletes).  The tough part of that will be keeping it backwards
compatible.

-Vinny


On Fri, 21 Jan 2005 08:00:45 +0100, Dirk Haun <dirk at haun-online.de> wrote:

> Tony,

> 

> >Dirk, actually, in the stubbed out functions I would put the require_once:

> >

> >function COM_deleteComment()

> >{

> >    require_once '/path/to/lib-comment.php';

> >    CMT_deleteComment();

> >}

> >

> >Gets around the issue of including code that probably won't be used and

> >it provides the backwards compatibility.

> 

> Makes perfect sense, thanks.

> 

> bye, Dirk

> 

> --

> http://www.haun-online.de/

> http://www.haun.info/

> 

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>


--__--__--

Message: 3
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Subject: Re: [geeklog-devel] Deleting comments
Date: Sat, 22 Jan 2005 11:00:58 +0100
Organization: Terra Software Systems
Reply-To: geeklog-devel at lists.geeklog.net

Vincent Furia wrote:


>Next step is to look at redoing the comment API (especially for

>deletes).


For the trackback comments, I've introduced a function that only checks
with the plugin if it would be okay for the current user to delete a
comment on an object under the plugin's control. The actual delete is
then done by Geeklog.

/**
* Ask plugins to handle a trackback comment operation.
*
* Operations:
* 'accept' - does the plugin accept a trackback comment for its entry $id,
*            returns: true or false
* 'delete' - does the user have permission to delete comments on entry $id,
*            returns: true or false
* 'info'   - plugin is asked to provide information on entry $id,
*            returns: array (url, title, excerpt)
*
* @param    string  $type       plugin type
* @param    string  $id         ID of an entry under the plugin's control
* @param    string  $operation  operation to perform
* @return   mixed               depends on the operation (see above)
*
*/
function PLG_handleTrackbackComment ($type, $id, $operation)

Since this isn't used anywhere yet, we could easily change it to keep it
in sync with the plugin API for "normal" comments.



>The tough part of that will be keeping it backwards compatible.


Since the current delete is actually messing up the comments, I'd say we
should break it on purpose ...

bye, Dirk


-- 
http://www.haun-online.de/
http://mypod.de/


--__--__--

Message: 4
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Date: Sat, 22 Jan 2005 14:48:30 +0100
Organization: Terra Software Systems
Subject: [geeklog-devel] Table locking
Reply-To: geeklog-devel at lists.geeklog.net

It seems some of our users are still having problems getting their
hosting service to allow them to lock tables (needed to post comments as
of Geeklog 1.3.10).

The excuses from the hosting services I've heard so far are ... less than
convincing, to put it politely.

Can our resident database experts try and shed some light on it in this
thread, please?

    http://www.geeklog.net/forum/viewtopic.php?showtopic=45428

bye, Dirk


-- 
http://www.haun-online.de/
http://mypod.de/


--__--__--

Message: 5
Date: Sat, 22 Jan 2005 09:55:54 -0500
From: Vincent Furia <vfuria at gmail.com>
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Table locking
Reply-To: geeklog-devel at lists.geeklog.net

Just posted the following to the thread.

-Vinny

----------

Assuming your hosting service is making up a lame excuse not to give
you LOCK TABLES privileges there are a couple things you can do:

0. Tell your host that you want "LOCK TABLE" priveleges or you'll take
your business else where, all the excuses I've seen on this thread
seem very lame. Smile

1. Remove all the "LOCK TABLE" "UNLOCK TABLE" SQL calls from
comment.php. This should be okay if you have a low traffice site, but
opens up the possiblity of corruption if two or more users try to save
or delete comments at the same time.

2. Upgrade to InnoDB tables. There is a script in the admin directory
to do this. Then change every instance of "LOCK TABLE XXX" to "START
TRANSACTION" and every instance of "UNLOCK TABLE XXX" to "COMMIT". The
only downside to this is that it is untested and will only work with
InnoDB tables. If anyone tries this let me know how it works.

I appologize to everyone for the problems that the LOCK statements are
causing. They were implemented to improve comment display performance
(which was misserable).

Good Luck,
Vinny

P.S. Dirk, do you want to this to the FAQ?


On Sat, 22 Jan 2005 14:48:30 +0100, Dirk Haun <dirk at haun-online.de> wrote:

> It seems some of our users are still having problems getting their

> hosting service to allow them to lock tables (needed to post comments as

> of Geeklog 1.3.10).

> 

> The excuses from the hosting services I've heard so far are ... less than

> convincing, to put it politely.

> 

> Can our resident database experts try and shed some light on it in this

> thread, please?

> 

>     http://www.geeklog.net/forum/viewtopic.php?showtopic=45428

> 

> bye, Dirk

> 

> --

> http://www.haun-online.de/

> http://mypod.de/

> 

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>



--__--__--

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel


End of geeklog-devel Digest