[geeklog-devtalk] Syndication Re-write

[Dirk Haun]

Michael Jervis wrote (back in December):


>I've submitted a 70 ish kb tgz to the patch tracker. This includes full

>versions of each file in geeklog I've edited, plus the full versions of my

>new files.


I've finally found the time to look into these. Very impressive, thank
you very much!

A few things I stumbled across:

1) In your new COM_rdfImport, you have

    // 0 based, using < in for
    $maxheadlines = count( $feed->articles ) + 1;

The + 1 doesn't seem to be necessary. Without the new $_CONF variable
that you're using and without the proposed DB change, I am now getting an
extra entry at the end of every feed.

2) There may be a character set issue somewhere. Both feeds from
geeklog.info are displaying the 'ö' (o umlaut) in "veröffentlicht"
incorrectly. One feed is Geeklog's standard RSS 0.91 feed, the other is
created by your Atom writer class. They're both delivered as ISO-8859-15
but the reader class seems to convert it to UTF-8.

http://geeklog.info/backend/geeklog.rdf
http://geeklog.info/backend/new-feed.xml

3) I'm not sure if your copyright notice / license is compatible with the
GPL. This has prevented me from adding your code to CVS right away. Any
thoughts?

4) I didn't know you also owned "fhuckingbrit.com" ;-)

bye, Dirk


-- 
http://www.geeklog.net/
http://geeklog.info/