[geeklog-devtalk] Syndication Re-write

[Michael Jervis]

 >Very impressive, thank you very much!

No problem.


>1) In your new COM_rdfImport, you have


Yeah, quite right, I did actually spot that, but then I upgraded to .11 and
haven't re-synched since so the issue stopped happening and I neglected to
remember to fix it ;-)

Just taking the +1 out fixes it. I understand my thinking at the time, but
it was wrong. I'm still very sleep deprived. Someone should have warned me
about that before we had the baby.


>2) There may be a character set issue somewhere. 


Now that I find interesting. Xml_parser_create():

---
The optional encoding specifies the character encoding of the XML input to
be parsed. Supported encodings are "ISO-8859-1", which is also the default
if no encoding is specified, "UTF-8" and "US-ASCII". 
---

XML_OPTION_TARGET_ENCODING
---
Sets which target encoding to use in this XML parser. By default, it is set
to the same as the source encoding used by xml_parser_create(). Supported
target encodings are ISO-8859-1, US-ASCII and UTF-8. 
---

So, it should default to ISO-8859-1, and the target should follow suite, as
that was the source, but I notice in the original geeklog version:

    @xml_parser_set_option( $xml_parser, XML_OPTION_TARGET_ENCODING,
                            $_CONF['default_charset'] );

I'll introduce a charset as an option to the reader method, as optional, and
pass through default_charset see if that does anything. I don't see any
other charset code in geeklog. So I'm a bit bemused.


>3) I'm not sure if your copyright notice / license is compatible with the

GPL.

>This has prevented me from adding your code to CVS right away. Any

thoughts?

11th entry on this page:
http://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses

i.e. yes it is ;-)


>4) I didn't know you also owned "fhuckingbrit.com" ;-)



Hmm, that would work actualy. I've been looking for a less offensive domain
to alias so I can access my site at work...

I'll attach my swift tweaks, haven't got time to test for a few days, off
away on business. Note I've not updated the diffs.

Mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: syndication.tgz
Type: application/octet-stream
Size: 121467 bytes
Desc: not available
Url : <http://eight.pairlist.net/pipermail/geeklog-devtalk/attachments/20050123/889292a6/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 3030 bytes
Desc: not available
Url : <http://eight.pairlist.net/pipermail/geeklog-devtalk/attachments/20050123/889292a6/attachment.bin>