[geeklog-devtalk] Syndication Re-write

[Dirk Haun]

Michael,

I've incorporated your patches into CVS now. I made a few minor changes
here and there, but nothing substantial.

We can address any remaining issues from there now. Like these:

For existing feeds, the feed format is stored as the name of the (old)
feed writer class, e.g. 'rss' for the default feed. Your new framework
uses slightly different names, though.

So what do we do with the existing feeds? Should the names be changed
during the upgrade? I would need a table mapping the old names to the new
ones then:

    old      new
    'rss' -> 'RSS-0.9x'
etc.



>>2) There may be a character set issue somewhere. 

[...]

>So, it should default to ISO-8859-1, and the target should follow suite, as

>that was the source, but I notice in the original geeklog version:

>

>    @xml_parser_set_option( $xml_parser, XML_OPTION_TARGET_ENCODING,

>                            $_CONF['default_charset'] );


There was a bug report for this: <http://project.geeklog.net/tracker/
index.php?func=detail&aid=301&group_id=6&atid=105>

Adding the character set fixed it ...



>I'll introduce a charset as an option to the reader method, as optional, and

>pass through default_charset see if that does anything.


You didn't finish that, it seems. I see that FeedParserFactory::reader
accepts a character set as the second parameter now but doesn't use it.


(License)

>11th entry on this page:

>http://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses

>

>i.e. yes it is ;-)


Thanks. I didn't realise that it was an established license you were
using there.

bye, Dirk


-- 
http://www.haun-online.de/
http://geeklog.info/