[geeklog-devel] Comment Spam & lib-c*.php

[Tony Bibbs]

I don't see a reply to this so here is mine:

Sure send your code over for tracking IP's in comments.

As for rearranging file locations.  We'll be looking at separating 
lib-common.php into even more libraries (e.g. lib-html.php, etc) but I 
doubt we swap the location of lib-common.php and lib-custom.php just for 
support reasons (we'd get flooded with "where is lib-common.php" 
questions no matter how much we documented and advertised such a 
change).  I agree hindsite your suggestions seems the most logical, 
however, you must consider the history of those files.  lib-custom.php 
didn't exist for a long time and all there was was lib-common.php.

Thanks,

--Tony

Michael Jervis wrote:

>Hi,
>
>I've been having a lot of comment spam recently and I noticed there is no IP
>tracking on the comments, making it hard to locate and lock out repeated
>anonymous comment spam. I've modified my geeklog instance, didn't take much,
>to log the comment ip address, and display it next to the delete link if you
>have delete permissions.
>
>I think this code should be a feature. Want mine?
>
>I was thinking, as I trolled round the code changing things. IMHO
>lib-custom.php and lib-common.php are the wrong way round. Sort of.
>
>I think that your geeklog include path and custom files should be in the
>same file. lib-custom.php which should be in the public_html. lib-common.php
>should be in system. This way there are two touch points, config.php and
>lib-custom.php where users put their stuff. They shouldn't need to edit a
>'core' file, lib-common.php themselves.
>
>The content of lib-custom.php would never need to change, it's their system
>specific settings. No more editing of lib-common.php when upgrading etc. It
>just make things more logical, and better for upgrading IMHO.
>
>Just my $0.02.
>
>Mike
>
>
>_______________________________________________
>geeklog-devel mailing list
>geeklog-devel at lists.geeklog.net
>http://lists.geeklog.net/listinfo/geeklog-devel
>  
>