[geeklog-devel] Testing of getimage.php

[Dirk Haun]

>I have committed changes to CVS that use getimage.php.  That file allows 
>images outside of a webtree to be viewed (i.e. userphotos, article 
>images).

I've played a bit with it (userphotos only) and noticed a few minor things:

In "show" mode, getimage.php could display a proper error message.
Otherwise, it should at least send a "404 Not Found" header when the
image does not exist (added both).

The calls to header() (in the download class) don't need to end in a
"\n", so I removed them.

In Mozilla, right-clicking on the userphoto and selecting "View Image"
from the context menu prompts a dialog to download the image. This is
because of the "Content-Disposition:" header sent by the download class.
For an actual download, that is correct, but for an image? I guess this
could be an option, but I left it as it is.

Looks good 

-- 
http://www.haun-online.de/
http://www.macosx-faq.de/