[geeklog-devel] 1.3.10 to do list

[Blaine Lang]

Thanks for the feedback Dirk - all good points.

Item 1: The archivetopioc setting. No Problem I was just trying to not add
too many new fields.
- Adding a arhive flag is no issue.
- If I add a archivetopic field then we have to have another selectbox for
this in the editform.
Do we think users will need that extra flexibilty ?

Item2: My thinking was to make it a deliberate 2-step or 2-click process to
ensure the user was not enabling this by mistake. But have made the
suggested changed to the setting the options. Only concern is by enabling it
via the checkbox, the archive option is now also checked and the default
date is now. So - with one click if this is in error, the story will be
auto-archived upon saving.

Item3: Making this still work even with JS disabled. Well I had to think
about that one for a bit but have a nice solution (IMHO) and maybe we can
use this elseware. I added this logic to the bottom of the form and set the
template variable {showarchivedisabled} if the form area for this feature
and its controls should be disabled. Only if JS is enabled will this code
execute. I'm sure this could be enhanced or made more flexible as a
function.

   <script>
    <!-- This code will only be executed by a browser that suppports
Javascript -->
    var jstest = {showarchivedisabled}
    if (jstest) {
        document.frmstory.expire_month.disabled=true;
        .. and any other form fields
   </script>

Let me know if there is a preference for Item1
I'll hold off submitting these changes until them as it will effect the
package.

Blaine

----- Original Message ----- 
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Sent: Saturday, July 31, 2004 4:57 AM
Subject: Re: [geeklog-devel] 1.3.10 to do list


Blaine,

>I have just submitted to CVS the changes to support the Story Archive
>Feature.

Nice work. A couple of comments:

I'm not happy with the $_CONF['archivetopic'] variable. Topic IDs should
be kept out of the config.php, IMO. I can think of 2 better ways to do this:

1) Add an "Archive" flag to the topics table, similar to the default
topic flag.

2) Even more flexible: Add the archive topic id to the story table, so
that stories can be archived in different topics.

I'm open to other ideas, but please keep the topic ID out of config.php.


The user interface for that option is a bit clumsy. First you have to
enable archiving and then you have to select whether you want Auto
Archive or Auto Delete. I would assume that Auto Archive is the option
you'll want in most cases, so could you make that one selected
automatically when enabling the option?


>I have used Javascript to disable the extra
>fields in the story editor "Edit" screen if this option is disabled. The
>default is for this option to be disabled unless toggled on per story. It's
>a nice touch but I may have to disable it or find a quick way to leave
these
>new fields enabled if JS is disabled in the browser. Just about everyone
has
>JS enabled don't they :)

Thanks to Mozilla's fine-grained Javascript options, I do have Javascript
enabled most of the time. But I do use Lynx on occasion ...


>This is a topic for another day but maybe we assume JS is enabled for
>Admin's and start to use JS to improve the UI.
>I'd love to see a nice Tab'ed interface for some of these large admin
pages.

I not opposed to using Javascript to make things easier / more
comfortable, but every option should also be available without Javascript.

bye, Dirk


-- 
http://www.haun-online.de/
http://geeklog.info/

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel