[geeklog-devel] Re: FileMgmt Comments (1.3.10rc1)

[Vincent Furia]

Dirk,

I think I found most of the problems.  Of course I can't test the code
since I don't have filemgmt installed (maybe something I should get
around too???).  Anyway, if you could test the changes (checked into
cvs--lib-common.php and comment.php) on geeklog.net that would be
great.

Thanks,
Vinny


On Mon, 25 Oct 2004 16:39:10 -0400, Vincent Furia <vfuria at gmail.com> wrote:
> No, you shouldn't have to change cids to integers, that problem has
> been fixed (or will be in 1.3.10 final, it is still broken in rc2 and
> cvs).  However there are plenty of other problems to go around...  :)
> 
> 
> 
> -Vinny
> 
> On Mon, 25 Oct 2004 16:18:56 -0400, Blaine Lang <geeklog at langfamily.ca> wrote:
> > I'm currently doing the migration of my site to 1.3.10 and test out the
> > filemgmt plugin. Are you suggesting that I need to change to use integer
> > values for the cid ?
> >
> > Blaine
> >
> >
> > ----- Original Message -----
> > From: "Dirk Haun" <dirk at haun-online.de>
> > To: <geeklog-devel at lists.geeklog.net>
> > Sent: Monday, October 25, 2004 4:02 PM
> > Subject: Re: [geeklog-devel] Re: FileMgmt Comments (1.3.10rc1)
> >
> > Vinny,
> >
> > >Right now the comments.php file
> > >assumes, due to the use of COM_applyFilter, that the cid is an
> > >integer.
> >
> > That's a bug then. The file management plugin has been using non-numeric
> > cids for a while now and other plugins may have picked that up, too.
> >
> > >So I think the short term fix for this is to change this code at the
> > >end of comment.php (stating around line 881):
> >
> > I've made that change on geeklog.net now (but not in CVS - I'll leave
> > that to you).
> >
> > Doesn't seem to be the only problem, though. For example, when I go to
> >
> >   http://www.geeklog.net/comment.php?type=filemgmt&cid=filemgmt-427
> >
> > and try to switch the comment mode from Threaded to Nested, I get
> > redirected to the homepage.
> >
> > Btw, why does it display them as Threaded in the first place? My comment
> > preferences are for Nested.
> >
> > bye, Dirk
> >
> > --
> > http://www.haun-online.de/
> > http://geeklog.info/
> >
> > _______________________________________________
> > geeklog-devel mailing list
> > geeklog-devel at lists.geeklog.net
> > http://lists.geeklog.net/listinfo/geeklog-devel
> >
> > _______________________________________________
> > geeklog-devel mailing list
> > geeklog-devel at lists.geeklog.net
> > http://lists.geeklog.net/listinfo/geeklog-devel
> >
>