[geeklog-devel] Fwd: Re: Interested in Geeklog patches?

[Vincent Furia]

Oops, sent this one only to Dirk...


---------- Forwarded message ----------
From: Vincent Furia <vfuria at gmail.com>
Date: Fri, 4 Feb 2005 14:00:55 -0500
Subject: Re: Re: Interested in Geeklog patches?
To: Dirk Haun <dirk at haun-online.de>


OK... spend a few minutes looking into this patch (to stop comments
after a certain amount of time).  And...

...I'm going to have redo this patch from scratch.  It will only work
with stories, patched as is it would choke on polls and plugins.  Plus
it won't apply cleanly on top of the changes I just made to the
comment system anyway. I'll accept any recommendations on how to
handle this functionality for plugins (or should I just let plugins
handle this themselves in the new savecomment function?).

-Vinny

P.S.  I need help from at lease one plugin developer who is/will be
using the comment API to document the new API.  Anyone?  Most of the
work is done, I just need example code!

On Tue, 1 Feb 2005 23:16:35 +0100, Dirk Haun <dirk at haun-online.de> wrote:
> Vinny,
>
> Here's the original email and the patches. It's not as much as I thought
> it was - and relatively recent ...
>
> bye, Dirk
>
> ---------------- Anfang Weiterleitung ----------------
> Betreff: Re: Interested in Geeklog patches?
> Gesendet: Sonntag, 5. Dezember 2004 9:16 Uhr
> Von: Steve McInerney <steve at stedee.id.au>
> An: Dirk Haun <dirk at haun-online.de>
>
> Hi Dirk,
>
> patches attached. I've not sent the complete diff against comment.php -
> mainly as most of the diff is whitespace/indentation changes. And
> obscures the actual changes too well.
>
> I have not actually tested this against the 1.3.10 code; but it looks
> like we're running a comment.php that is very near identical to
> 1.3.10's. It was pretty much a drop in replacement.
>
> I've only recently stepped in to do some coding for this site. The lead
> programmer has been very busy lately and unable to devote as much time
> as he or we would like unfortunately.
>
> [snip]
>
> >>A speed limiter that (was backported?) helped a great deal as well.
> > I don't remember the details, but there were a few bugs with the comment
> > speed limit in earlier versions of Geeklog.
>
> Looking at the 1.3.10 code, we have the same one. And the same missing
> global declaration in savecomment. :-)
>
> Comments/Criticism's always welcome.
>
> Cheers!
>
> - Steve