Dirk,
I just checked in some thtml files that should fix the problems you
saw with the collapse button not appearing. (Also fixed some w3c
validation problems).
-Vinny
On Sat, 5 Feb 2005 15:00:43 -0500, Vincent Furia <vfuria at gmail.com> wrote:
> Dirk, the reason why the collapsing icon isn't showing up is you
> having anonymous comments turned off and this piece of code:
>
> // hide reply link from anonymous users if they can't post replies
> $hidefromanon = false;
> if( empty( $_USER['username'] ) && (( $_CONF['loginrequired'] == 1 )
> || ( $_CONF['commentsloginrequired'] == 1 ))) {
> $hidefromanon = true;
> }
>
> // this will hide HTML that should not be viewed in preview mode
> if( $preview || $hidefromanon ) {
> $template->set_var( 'hide_if_preview', 'style="display:none"' );
> } else {
> $template->set_var( 'hide_if_preview', '' );
> }
>
> Hides the entire "reply to" section of code, including the collapse
> image, from anonymous users when anonymous comments are disabled.
> Fixing it could be as easy as changing the theme around. I'll look
> into it a bit...
>
> I already knew this would not work for IE < 5.5 (all versions). I'm
> not sure what is going on with Opera, can anyone with Opera for
> windows check it out?
>
> So, in summary, I think safari will probably work after we fix the
> anonymous user problem, as will OmniWeb 5.1. IE < 5.5, iCab, and old
> versions of OmniWeb will probably never work as they don't support
> xmlhttp. Opera will take some looking into...
>
> As for the character sets I have no idea what could be messing with
> that... Can someone with experience with character sets and PHP take a
> look for me?
>
> Thanks,
>
> -Vinny
>
> On Sat, 5 Feb 2005 14:04:31 +0100, Dirk Haun <dirk at haun-online.de> wrote:
> > I wrote:
> >
> > >One odd issue, though: It seems to be messing with the character set.
> > >When I collapse a comment and expand it again, all of the German umlauts
> > >have turned into question marks
> >
> > The same thing is happening on geeklog.info:
> >
> > <http://geeklog.info/article.php?stor
> > y=20020829000431524&mode=dynamic#comments>
> >
> > And now for the browser compatibility test (fasten your seatbelts ...):
> >
> > - The collapsing icon doesn't show up in Safari. You can expand comments,
> > but then the icon vanishes.
> >
> > - The same thing happens in OmniWeb 5.1.
> >
> > - Doesn't work at all in Mac-IE 5.2.3: The collapsing icons don't show
> > up; the expanding icons do show up but don't work.
> >
> > - The exact same thing happens in iCab 2.9.8
> >
> > - The collapsing icon doesn't show up in Opera 7.54u2 for Mac. Expanding
> > doesn't work (switches to "Loading ..." and stays there).
> >
> > - The exact same thing happens in OmniWeb 4.5 and iCab 3.0.0 beta 227.
> >
> > From Opera, I get the following error message in the JavaScript console:
> >
> > Event thread: onclick
> > Error:
> > name: TypeError
> > message: Statement on line 61: Expression did not evaluate to a function
> > object: xmlhttp.open
> > Backtrace:
> > Line 61 of linked script http://geeklog.info/dynamic.js
> > xmlhttp.open("GET", fragment_url, true);
> > In unknown script
> > loadFragmentInToElement("http://geeklog.info/comment.php?
> > mode=fetch&cid=192&full=true", "192");
> > At unknown location
> > {event handler trampoline}
> >
> > To summarize: On the Mac, it currently only works on Gecko-based
> > browsers. I did use the latest versions available of those browsers (and
> > in some cases another, older version).
> >
> > bye, Dirk
> >
> > --
> > http://www.haun-online.de/
> > http://www.macosx-faq.de/
> >
> > _______________________________________________
> > geeklog-devel mailing list
> > geeklog-devel at lists.geeklog.net
> > http://lists.geeklog.net/listinfo/geeklog-devel
> >
>