[geeklog-devel] GL selectable between HTML and XHTML

[Yoshinori Tahara]

Dirk Haun wrote:

> -# $Id: english_utf-8.php,v 1.8 2007/08/29 05:25:31 ospiess Exp $
> +# $Id: english_utf-8.php,v 1.22 2007/10/09 05:39:36 ospiess Exp $

> So this is a patch against version 1.8 of the Links plugin language file
> to bring it up to version 1.22. This doesn't look like the patch was
> really done against a current CVS version. It only applies to a few
> language files, though, AFAICS.

> I just hope it doesn't un-do any other changes elsewhere ...

I'm sorry.
I thought a change to english.php to be should apply to english_utf-8.php
likewise.
I will confirm whether there is not such a thing elsewhere once again.


> Suggestion for improvement (but we can do this once the patch is in
> CVS): This looks really ugly and is a pain to type, especially in the
> language files:

> 77 => 'WARNING:<br' . XHTML . '>You have set your default encoding ...

> How about defining a constant "BR":

> define('BR', '<br' . XHTML . '>');

> Then you could write this as

> 77 => 'WARNING:' . BR . 'You have set your default encoding ...

I thought that I wanted to change it like that if possible.
Do you change it as follows?

W:\path\to\Geeklog\public_html\layout\professional\functions.php
if (!defined ('XHTML')) {
    define('XHTML',''); // change this to ' /' for XHTML
}
if (!defined ('BR')) {
    define('BR', '<br' . XHTML . '>');
}
if (!defined ('HR')) {
    define('HR', '<hr' . XHTML . '>');
}

We are ready to modify code again if demanded.

--
Yoshinori Tahara - dengen