[geeklog-devel] XHTML Changes

Sun Nov 25 05:55:50 EST 2007

Oliver Spiesshofer wrote:

> RCS file: /usr/home/geeklog2/cvsroot/geeklog/Geeklog-1.x/public_html/layout/professional/article/printable.thtml,v
> retrieving revision 1.6
> retrieving revision 1.7
> diff -C2 -d -r1.6 -r1.7
> *** printable.thtml     17 Sep 2007 02:31:03 -0000      1.6
> --- printable.thtml     25 Nov 2007 06:59:33 -0000      1.7
> ***************
> *** 1,4 ****
> ! <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
> ! <html>
>   <head>
>       <title>{page_title}</title>
> --- 1,4 ----
> ! <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
> ! <html xmlns="http://www.w3.org/1999/xhtml" xml:{lang_attribute} {lang_attribute}>
>   <head>
>       <title>{page_title}</title>
> ***************
>
> Why are we using transitional here? Where is the optional setting?
>

Here, we should have matched it with header.thtml and should have
unified it in 4.01 HTML Strict.
There is not the option setting of DOCTYPE, and it is necessary to do
a hard code.
Should we add option setting of DOCTYPE?

> *** header.thtml        17 Sep 2007 05:36:50 -0000      1.32
> --- header.thtml        25 Nov 2007 06:59:22 -0000      1.33
> ***************
> *** 1,10 ****
>   <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01//EN" "http://www.w3.org/TR/html4/strict.dtd">
>
> What will be the proper Doctype for the XHTML option?
>

We think that "HTML 4.01 Strict" is suitable for the standard.

> *** geeklog.rss 15 May 2006 05:58:55 -0000      1.2
> --- geeklog.rss 25 Nov 2007 06:58:56 -0000      1.3
> ***************
> *** 1,26 ****
> - <?xml version="1.0" encoding="UTF-8"?>
> - ...
>
> why was all of this removed?
>

The change to geeklog.rss was not included in our patch.

> *** block.php   29 Aug 2007 09:33:54 -0000      1.115
> --- block.php   25 Nov 2007 06:58:55 -0000      1.116
> ***************
> *** 164,167 ****
> --- 164,168 ----
>       $block_templates->set_var('permissions_editor', SEC_getPermissionsHTML($A['perm_owner'],$A['perm_group'],$A['perm_members'],$A['perm_anon']));
>       $block_templates->set_var('permissions_msg', $LANG_ACCESS['permmsg']);
> +     $block_templates->set_var('max_url_length', 255); // @@@@ added by dengen 2007/09/08
>       $block_templates->parse('output','editor');
>       $retval .= $block_templates->finish($block_templates->get_var('output'));
>
> Why this? If we cannot set itv as a config or functions.php-variable, we might as well keep it fixed in the template?
>

Template variable {max_url_length} was used for defaultblockeditor.thtml in CVS.
Because it was not defined in block.php, I defined it.
We want to entrust it to the judgment of the developer team whether a
hard code is suitable.

> *** style.css   6 Sep 2007 06:45:12 -0000       1.3
> --- style.css   25 Nov 2007 06:58:55 -0000      1.4
> ***************
> *** 178,182 ****
>   label {
>     padding: 0px;
> !   width: 12em;
>     float: left;
>     text-align: left;
> --- 178,182 ----
>   label {
>     padding: 0px;
> !   width: 14em;
>     float: left;
>
> Whats this here? I guess an erroneous submit?
>

I'm confirming it to mystral-kk was in charge of a revision now.

-- 
Yoshinori Tahara - dengen