[geeklog-devel] [PATCH] Allow the comment form to be displayed regardless of speed limit

Vincent Furia vfuria at gmail.com
Sat Sep 8 12:54:17 EDT 2007


I'll dig into the code tonight and tomorrow and see what I can see. I
don't think it would be difficult to get the CMT_saveComment to return
a speed limit error page. That way you could hit the "back" button
and return to your comment and wait out the speed limit. That
shouldn't break any plugin... I don't know of any third party code
changes that actually change Geeklog's comment code. Assuming that
assumption is valid we should be able to work something out.

-Vinny

On 9/8/07, Dirk Haun <dirk at haun-online.de> wrote:

> Andrew Church wrote:

>

> >the patch which is intended to allow users to display the comment

> >submission form even before the "speed limit" timeout expires, rather

> >than forcing them to wait for that period before being able to start

> >typing a new comment.

>

> Sorry for the late reply.

>

> I guess changing the behavior here would be okay. I've played with your

> patch and found one flaw, though: Now the speed limit is triggered in

> CMT_saveComment() which kicks you back to the comment submission form

> without any indication of what happened. So we would need to add the

> speedlimit warning ("Your last comment was xx seconds ago ...") there

> now. But we don't have the value for "xx" there.

>

> I'm not sure if we can change the API for CMT_saveComment (to return

> that information) without breaking some 3rd-party code ...

>

> Vinny, are you around? Any ideas?

>

> bye, Dirk

>

>

> --

> http://www.geeklog.net/

> http://geeklog.info/

>

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://eight.pairlist.net/mailman/listinfo/geeklog-devel

>




More information about the geeklog-devel mailing list