[geeklog-devel] About COM_startBlock in GL-1.4.2

[geeklog at mystral-kk.net]

Hi, all,

I downloaded Nightly CVS tarball and installed Geeklog-1.5(1.4.2?).  The
installer looks so nice!

BTW, looking into COM_startBlock function, My friend Phize found a
potnetial bug.  In this function, the $title parameter is used as a block
ID.  If $title is made up of multibyte characters, it will cause an HTML
error, for id property of HTML doesn't allow a value of multibyte
characters.

Besides, I believe line #1364 should not be
    $blockid = strtr($blockid, "!@#$%^&*()'\"\\/?~`.,;: ",
"________________________");
but
    $blockid = preg_replace( "/!@#\$%^&\*\(\)'\"\\\/\?~`\.,;: /", "_",
$blockid );
because strtr() functions is not used properly.

Lastly, I can't understand the comment on line #1368
[quote]
        for ($i=2; $i <= 5; $i++) {   // there can't be more then 5 blocks
of the same name
[/quote]
Why "not more than 5"?  Maybe a bigger number is better.  Or am I missing
something badly?
-- 
mystral-kk (Kenji ITO)
"Every cloud has a silver lining."