[geeklog-devel] About COM_startBlock in GL-1.4.2

[Blaine Lang]

geeklog at mystral-kk.net wrote:

>  I believe line #1364 should not be

>     $blockid = strtr($blockid, "!@#$%^&*()'\"\\/?~`.,;: ",

> "________________________");

> but

>     $blockid = preg_replace( "/!@#\$%^&\*\(\)'\"\\\/\?~`\.,;: /", "_",

> $blockid );

> because strtr() functions is not used properly.

>   

Thanks for identifying that - I had borrowed that line from somewhere 
that I had thought worked. Will review and address.


> Lastly, I can't understand the comment on line #1368

> [quote]

>         for ($i=2; $i <= 5; $i++) {   // there can't be more then 5 blocks

> of the same name

> [/quote]

> Why "not more than 5"?  Maybe a bigger number is better.  Or am I missing

> something badly?

>   

This code is only executed on the rare case of you naming blocks with 
the same title - why would you have more then 5 blocks with the very 
same title?

Blaine