[geeklog-devel] [geeklog-cvs] Geeklog-1.x/system/classes config.class.php, 1.16, 1.17

[Dirk Haun]

Dirk Haun wrote:

>Log Message:
>Introduced a new config type 'fn:' that calls a specified function to
>provide contents of a dropdown at runtime, e.g. for the language and
>theme selection

Can I have some opinions on this, please? Aaron, Blaine, anyone?

In a nutshell, this introduces a new config type 'fn:' which, when
written as "fn:something" calls a function configmanager_something,
expecting it to return the selection array. In other words, it's a
dynamic version of the 'select' type.

I've already implemented it for the two obvious candidates: The site's
default language and theme. As others have pointed out, we already have
functions that provide dropdowns for those, so why not use them in the
configuration (well, they both needed small wrapper functions ...).

Is the function name okay or should it start with "CONF_" instead? Any
room for improvements?

bye, Dirk


-- 
http://www.geeklog.net/
http://geeklog.info/