[geeklog-devel] Bug when approving story submissions?

[Mark R. Evans]

Dirk,

Did you change the story id on one of the stories?  Looking at
story.class.php, near line 667, you have:

        if ($this->type == 'submission') {
            /* there might be a submission, clean it up */
            DB_delete($_TABLES['storysubmission'], 'sid', $checksid);
        }

I think part of the problem is that $checksid is only set when the original
SID doesn't match the new SID (around line 584), so if you don't change the
story ID, the entire submission queue could be deleted (since checksid =
'').

How are edits in the submission queue supposed to work.  It looks like now
when you edit and save, it approves the story automatically.  I don't recall
how it worked in previous versions, but it would seem that the edit should
save back to the submission table.  Not sure what the proper method is...

Thanks!
Mark



On Wed, Jun 18, 2008 at 1:07 PM, Dirk Haun <dirk at haun-online.de> wrote:

> Interesting effect: I just approved two story submissions on
> geeklog.net. In both cases, I edited the story. One of the stories left
> a duplicate in the submission queue. For the other story, it worked as
> expected.
>
> Not sure what the difference was between the two.
>
> First one to come up with a reproducible case, please submit a bug report
> ...
>
> bye, Dirk
>
>
> --
> http://www.haun-online.de/accu/
>
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://pairlist8.pair.net/pipermail/geeklog-devel/attachments/20080618/a9ea4a9c/attachment.html>