[geeklog-devel] conf_values and class config

Joe Mucchiello joe at throwingdice.com
Tue Mar 25 09:39:11 EDT 2008


Several issues exist still.

config class has no update function. What happens in subsequent 
versions when you want to delete or alter a config option? Suppose a 
select object is changed to a text or you want to move some fields 
into a new subgroup or fieldset. Is the plugin/core supposed to just 
update the CONF_VALUE table directly? Please finish the interface 
with update and delete functions

Originally I was going to say the INSERT in add should be a REPLACE 
but the conf_values table has no indexes. There should at least be a 
unique (and primary) key on (group_name, name) to avoid multiple 
calls to add() causing all sorts of havoc.


----
Joe Mucchiello
Throwing Dice Games
http://www.throwingdice.com 




More information about the geeklog-devel mailing list