[geeklog-devel] Patch for bug id 771
singh.roshan08 at gmail.com
Sun Apr 12 22:55:28 EDT 2009
On Mon, Apr 13, 2009 at 12:34 AM, Dirk Haun <dirk at haun-online.de> wrote:
> Roshan Singh wrote:
> >I have worked on Bug id 771. The idea was to add a new option for CC in
> >various mails that are sent.
> Thanks. I've seen it working, so let's have a look at the other side:
> > <td><input type="checkbox" name="cc" value=1></td>
> Geeklog can be switched to XHTML compliant mode, so all templates must
> be XHTML compliant, too. That should be value="1".
I will change this.
> $newsubject="copy of ".$subject; // to indicate that it
>is a carbon copy
The "copy of" should of course also go into the language file so that it
> can be translated.
> Is anyone aware of a convention to mark emails as a copy in the email's
> subject (similar to "Fwd:" for forwarded emails)?
> Oh btw, a "patch" usually refers to a file that only contains the
> differences between two versions of a file, usually produced by the
> "diff" command. The profiles.php in the trunk contains other changes
> that are missing from the copy you sent and would be lost if I used your
> copy. Using a proper patch avoids these problems.
> bye, Dirk
Yeah i know that patch is a diff, i do not have time right now, may after
first exam is over i should be able to send you the patch. I have thought
that in the mail message itself we can mention.
"Copy of mail sent to xyz"
That should be sufficient i suppose. I would like you to see
http://bugzilla.gnome.org/show_bug.cgi?id=395636 which I had fixed. I have
checked out the source using mercurial.
By the way is there any other thing to be added. If everything is fine I
will send a patch that you can apply.
Roshan Kumar Singh
IRC - #nitdgplug on Freenode
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the geeklog-devel