[geeklog-devel] Patch for bug id 771

Dirk Haun dirk at haun-online.de
Sun Apr 12 15:04:16 EDT 2009

Roshan Singh wrote:

>I have worked on Bug id 771. The idea was to add a new option for CC in the
>various mails that are sent.

Thanks. I've seen it working, so let's have a look at the other side:

>            <td><input type="checkbox" name="cc" value=1></td>

Geeklog can be switched to XHTML compliant mode, so all templates must
be XHTML compliant, too. That should be value="1".

>                $newsubject="copy of ".$subject;     // to indicate that it
>is a carbon copy

The "copy of" should of course also go into the language file so that it
can be translated.

Is anyone aware of a convention to mark emails as a copy in the email's
subject (similar to "Fwd:" for forwarded emails)?

Oh btw, a "patch" usually refers to a file that only contains the
differences between two versions of a file, usually produced by the
"diff" command. The profiles.php in the trunk contains other changes
that are missing from the copy you sent and would be lost if I used your
copy. Using a proper patch avoids these problems.

bye, Dirk


More information about the geeklog-devel mailing list