[geeklog-devel] Upgrade bug in 1.8.0

[Tom]

The latest version of the Calendar plugin (and all the other core plugins)
requires Geeklog 1.8.0 to run.  The Geeklog database needs to be at 1.8.0
(just like the Geeklog code is) to run the 1.1.1 to 1.1.2 Calendar upgrade. 

(I haven't looked at the code yet) Doesn't migrate check the min Geeklog
version required for the Calendar plugin in the autoinstall.php? Looking at
plugin_compatible_with_this_version_calendar do we need to add 

    if (!function_exists('COM_ versionCompare')) { // This function was
introduced in Geeklog 1.8.0
        return false;
    }


So that the calendar upgrade is not run until the Geeklog DB is at version
1.8.0?

Tom



-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Dirk Haun
Sent: May-28-11 8:04 AM
To: Geeklog Development
Subject: [geeklog-devel] Upgrade bug in 1.8.0

Trying to reproduce someone's upgrade problems, I found an unrelated upgrade
problem in 1.8.0:

When you're upgrading from a pre-1.5.0 version, the plugin upgrades (e.g.
for the Calendar) fail when trying to initialize the Configuration:

Fatal error: 1054: Unknown column 'tab' in 'field list' in
/geeklog/system/databases/mysql.class.php on line 260

Call Stack
#   Time    Memory  Function    Location
1   0.0115  591372  {main}( )   ../migrate.php:0
2   0.1030  1373756 INST_doDatabaseUpgrades( )  ../migrate.php:784
3   3.6755  2265908 upgrade_CalendarPlugin( )   ../lib-upgrade.php:408
4   3.6771  2303464 plugin_initconfig_calendar( )
../mysql_1.4.1_to_1.5.0.php:482
5   3.6774  2305140 config->add( )  ../install_defaults.php:147
6   3.6776  2306568 config->_DB_escapedQuery( ) ../config.class.php:523
7   3.6776  2306568 DB_query( ) ../config.class.php:1752
8   3.6776  2306624 database->dbQuery( )    ../lib-database.php:208
9   3.6782  2306788 trigger_error ( )   ../mysql.class.php:260

The problem is with the "tab" column, which is new in 1.8.0. At the point of
the failure, the database is at 1.5.0, i.e. it does have a conf_values table
but without the "tab" column. Yet plugin_initconfig_calendar calls the
Configuration's add() function with a valid value for $tab, so we try to
write it to the db. Oops.

I haven't had a good idea yet how to get around this. Anyone?

bye, Dirk

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel