[geeklog-devel] Constant XHTML

[Tom]

Okay,

Does this sound good to you Vinny? (asking since hopefully at some point the
GSOC Template Engine Upgrade project may happen)

We might as well use the same file then (functions.php). This way it will
get included and old themes will still work most of the time (with the
default setting of error reporting) even if they do not include the new
functions.

Could you also do a quick update in the wiki with the new functions then
(since functions.php is only mentioned in the tips section)

http://wiki.geeklog.net/index.php/Theme_Developers_Guide
http://wiki.geeklog.net/index.php/Themes_and_XHTML

Thanks

Tom



-----Original Message-----
From: geeklog-devel-bounces at lists.geeklog.net
[mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Rouslan
Placella
Sent: April-09-12 9:50 AM
To: geeklog-devel at lists.geeklog.net
Subject: Re: [geeklog-devel] Constant XHTML

On 09/04/12 14:34, Tom wrote:
> Hmmm...
> 
> I didn't think of doing it this way.
> 
> It makes sense to only have one file with functions in it.
> 
> Do we need theme_getCss_newpro and theme_getJS_newpro though? Can't 
> they just set this in theme_init_newpro?

We don't _need_ them, but I think that it's cleaner that way.

> Also, should we still partially support functions.php for now if found 
> (for a few Geeklog versions) or just the new file? We are at Geeklog 
> 2.0 so if we did do a straight switch I guess the time would be now 
> since we have other incompatibilities.

I vote for breaking things once again :)

> Tom
> 
> -----Original Message-----
> From: geeklog-devel-bounces at lists.geeklog.net
> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Rouslan 
> Placella
> Sent: April-09-12 7:47 AM
> To: Geeklog Development
> Subject: Re: [geeklog-devel] Constant XHTML
> 
> How about dropping functions.php and having a file with actual 
> functions in it for the theme?
> 
> e.g.:
> // returns an array, where one of the entries is the doctype
> theme_getConfig_newpro()
> // returns an array of CSS files
> theme_getCss_newpro()
> // returns an array of JS files
> theme_getJS_newpro()
> // other stuff
> theme_init_newpro()
> 
> Then we can include the file at any point and only call the functions 
> when needed.
> 
> Bye,
> Rouslan
> 
> 
> On 05/04/12 14:57, Tom wrote:
>> Hey Rouslan,
>>
>>  
>>
>> After thinking about it a bit more. Did you want to go this route?
>>
>>  
>>
>> In the future I see us wanting to know more about the themes 
>> themselves, like what version of Geeklog it is for, author, etc. and 
>> this would be a good spot to put this information.
>>
>>  
>>
>> Tom
>>
>>  
>>
>>  
>>
>> From: geeklog-devel-bounces at lists.geeklog.net
>> [mailto:geeklog-devel-bounces at lists.geeklog.net] On Behalf Of Joe 
>> Mucchiello
>> Sent: March-29-12 9:20 PM
>> To: Geeklog Development
>> Subject: Re: [geeklog-devel] Constant XHTML
>>
>>  
>>
>>> 2) Create a new theme file that contains the doc type info that can 
>>> be loaded before the language files.
>>
>>  
>>
>> I would think this would be the cleanest solution. I suspect themes 
>> that don't have the file accept the default site-wide doctype.
>>
>>  
>>
>> I would also make this a .php file as there might be other $_CONF 
>> vars the theme needs control of.
>>
>>
>>
>>
>>
>> _______________________________________________
>> geeklog-devel mailing list
>> geeklog-devel at lists.geeklog.net
>> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
> 
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel
> 
> _______________________________________________
> geeklog-devel mailing list
> geeklog-devel at lists.geeklog.net
> http://eight.pairlist.net/mailman/listinfo/geeklog-devel

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://eight.pairlist.net/mailman/listinfo/geeklog-devel