[geeklog-devel] Deleting comments

[Blaine Lang]

Hi Dirk,

I like any idea to reduce the size of lib-common and was not aware the 
comment functions already are some 500 lines of code.
I don't have an issue with the Plugin Api changing if thats a better option.

Blaine

----- Original Message ----- 
From: "Dirk Haun" <dirk at haun-online.de>
To: <geeklog-devel at lists.geeklog.net>
Sent: Wednesday, January 19, 2005 4:52 PM
Subject: [geeklog-devel] Deleting comments


Since Geeklog 1.3.10, deleting comments isn't done with a simple
DB_delete call any more - the relation with other comments on the same
"comment tree" has to be fixed as well. Geeklog does that for comments on
stories and polls, but not for comments in plugins (most prominent
example: File Management plugin, but there are others).

So I guess what we need is a function that deletes a comment properly and
give plugins a way to access it.

Just the other day, I was actually thinking about moving all the comment-
related functions from lib-common.php[1] into their own lib-comment.php
file. If we add a COM_deleteComment function to that, plugins could
simply include that file and delete comments properly.

The other option would be to change the PLG_handlePluginComment(...,
'delete') call yet again and only make it indicate if it's okay to delete
the comment, but let Geeklog do the actual deletion.

Vinny? Blaine?

bye, Dirk

[1] which amount for almost 10% of the code in lib-common.php, btw


-- 
http://www.haun-online.de/
http://www.tinyweb.de/

_______________________________________________
geeklog-devel mailing list
geeklog-devel at lists.geeklog.net
http://lists.geeklog.net/listinfo/geeklog-devel