[geeklog-devel] Deleting comments

[Vincent Furia]

Also the functions in comment.php could probably be moved into the
"lib-comment.php" file as well.  If you'd like, I can take a first
stab at this this coming weekend (with the weather here I should have
time to get some work done).  Though if you'd prefer to do it I won't
get hurt feelings.  Hopefully Tony won't mind me working on something
besides Geeklog-2.  ;)

If you want to get really adventurous, I could go crazy and implement
comments in a more OO fashion.

-Vinny

P.S.  For those interested, I just checked in the first part of
comments for GL2.  See
http://cvs.geeklog.net/co.php/Geeklog-2/system/Propel/Geeklog-2/Gl2Comment.php.
 Just ignore the FIXMEs. :)

On Wed, 19 Jan 2005 16:17:41 -0600, Tony Bibbs <tony at tonybibbs.com> wrote:

> Dirk Haun wrote:

> 

> >Just the other day, I was actually thinking about moving all the comment-

> >related functions from lib-common.php[1] into their own lib-comment.php

> >file. If we add a COM_deleteComment function to that, plugins could

> >simply include that file and delete comments properly.

> >

> >

> If you mean lib-comment.php that would actually be CMT_deleteComment,

> right? I'm guessing you mean not to confuse it with lib-common.php

> functions. I'm all for this. I think you could also justify HTML-related

> stuff like COM_startHeader, COM_startBlock, etc. In fact, it might be a

> good exercise to review the code in lib-common.php and determinte what

> categories of functions you can come up with and decide how to layout

> the libraries.

> 

> Only issue with this sort of stuff is it will clearly break

> compatiblity. I say you would leave the stubbed out functions in

> lib-common.php, call the new library equivalent (i.e. COM_deleteComment

> would call CMT_deleteComment) and then log a warning to error.log that

> the function is deprecated and will be removed in a future version.

> 

> Thinking out loud,

> 

> --Tony

> _______________________________________________

> geeklog-devel mailing list

> geeklog-devel at lists.geeklog.net

> http://lists.geeklog.net/listinfo/geeklog-devel

>