[geeklog-devel] Deleting comments

Dirk Haun dirk at haun-online.de
Thu Jan 20 02:00:55 EST 2005


>Only issue with this sort of stuff is it will clearly break 
>compatiblity. I say you would leave the stubbed out functions in 
>lib-common.php, call the new library equivalent (i.e. COM_deleteComment 
>would call CMT_deleteComment) and then log a warning to error.log that 
>the function is deprecated and will be removed in a future version.

That would still require lib-common.php to include the lib-comment.php
then. Since comments are only used by a few components (and plugins) I
was actually thinking about getting rid of that code entirely so that
those components that actually need it would have to include this.

if (!function_exists ('COM_comment')) {
    require_once ($_CONF['path_system'] . 'lib-comment.php');

Yeah, it would break compatibility. But then again, there are more flaws
in the plugin API regarding comments (I'll post something about them
later) and this would be a good opportunity to fix them all at once.

Vinny, I'm not opposed to having a comment.class.php instead of the lib-
comment.php if you think that makes sense.

bye, Dirk


More information about the geeklog-devel mailing list